PurleyOpenBoardPkg: Update batch file not to check the return value of timeout

Expand all Fold all

[edk2] [Patch edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Update batch file not to check the return value of timeout

Posted by Liming Gao 5 years, 9 months ago

timeout command may not work well in some environment.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
---
 Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
index a6e0605..4c4aec3 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
@@ -111,13 +111,13 @@ echo.
 echo --------------------------------------------------------------------
 echo.
 call postbuild.bat
+if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL%
 timeout 1
 echo --------------------------------------------------------------------
 echo.
 echo                          PostBuild End
 echo.
 echo --------------------------------------------------------------------
-if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL%
 
 echo %date%  %time%
 echo.
@@ -128,7 +128,6 @@ echo                                Purley Build End
 echo.
 echo --------------------------------------------------------------------------------------------
 
-if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL%
 :done
 endlocal & EXIT /b %SCRIPT_ERROR%
 
-- 
2.10.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Update batch file not to check the return value of timeout

Posted by Yao, Jiewen 5 years, 9 months ago

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Gao, Liming
> Sent: Tuesday, July 10, 2018 9:29 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [Patch edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg:
> Update batch file not to check the return value of timeout
> 
> timeout command may not work well in some environment.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> ---
>  Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
> b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
> index a6e0605..4c4aec3 100644
> --- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
> +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
> @@ -111,13 +111,13 @@ echo.
>  echo --------------------------------------------------------------------
>  echo.
>  call postbuild.bat
> +if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL%
>  timeout 1
>  echo --------------------------------------------------------------------
>  echo.
>  echo                          PostBuild End
>  echo.
>  echo --------------------------------------------------------------------
> -if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL%
> 
>  echo %date%  %time%
>  echo.
> @@ -128,7 +128,6 @@ echo                                Purley Build
> End
>  echo.
>  echo --------------------------------------------------------------------------------------------
> 
> -if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL%
>  :done
>  endlocal & EXIT /b %SCRIPT_ERROR%
> 
> --
> 2.10.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel