1. Patchew
  2. EDK2
  3. [edk2] [PATCH v4 0/9] Add platform hook for ultimate boot failure.
  4. View patch

[edk2] [PATCH v4 6/9] ArmPkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot

Ruiyu Ni posted 9 patches 7 years, 7 months ago
[edk2] [PATCH v4 6/9] ArmPkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot
Posted by Ruiyu Ni 7 years, 7 months ago 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
index 079f1552d5..f9c71d430c 100644
--- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
+++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
@@ -3,7 +3,7 @@
 
   Copyright (C) 2015-2016, Red Hat, Inc.
   Copyright (c) 2014, ARM Ltd. All rights reserved.<BR>
-  Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
   Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
 
   This program and the accompanying materials are licensed and made available
@@ -766,3 +766,19 @@ PlatformBootManagerWaitCallback (
     Print (L".");
   }
 }
+
+/**
+  The function is called when no boot option could be launched,
+  including platform recovery options and options pointing to applications
+  built into firmware volumes.
+
+  If this function returns, BDS attempts to enter an infinite loop.
+**/
+VOID
+EFIAPI
+PlatformBootManagerUnableToBoot (
+  VOID
+  )
+{
+  return;
+}
-- 
2.16.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v4 6/9] ArmPkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot
Posted by Ard Biesheuvel 7 years, 7 months ago 
On 4 July 2018 at 03:50, Ruiyu Ni <ruiyu.ni@intel.com> wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> index 079f1552d5..f9c71d430c 100644
> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> @@ -3,7 +3,7 @@
>
>    Copyright (C) 2015-2016, Red Hat, Inc.
>    Copyright (c) 2014, ARM Ltd. All rights reserved.<BR>
> -  Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
>    Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
>
>    This program and the accompanying materials are licensed and made available
> @@ -766,3 +766,19 @@ PlatformBootManagerWaitCallback (
>      Print (L".");
>    }
>  }
> +
> +/**
> +  The function is called when no boot option could be launched,
> +  including platform recovery options and options pointing to applications
> +  built into firmware volumes.
> +
> +  If this function returns, BDS attempts to enter an infinite loop.
> +**/
> +VOID
> +EFIAPI
> +PlatformBootManagerUnableToBoot (
> +  VOID
> +  )
> +{
> +  return;
> +}
> --
> 2.16.1.windows.1
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v4 6/9] ArmPkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot
Posted by Ni, Ruiyu 7 years, 6 months ago 
Can someone give a r-b for this patch?
Is Ack-by enough for a check-in?

Thanks/Ray

> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Sent: Wednesday, July 11, 2018 10:21 PM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>
> Cc: edk2-devel@lists.01.org; Leif Lindholm <leif.lindholm@linaro.org>
> Subject: Re: [PATCH v4 6/9] ArmPkg/PlatformBDS: Implement
> PlatformBootManagerUnableToBoot
> 
> On 4 July 2018 at 03:50, Ruiyu Ni <ruiyu.ni@intel.com> wrote:
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
> > ---
> >  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 18
> > +++++++++++++++++-
> >  1 file changed, 17 insertions(+), 1 deletion(-)
> >
> > diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> > b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> > index 079f1552d5..f9c71d430c 100644
> > --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> > +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> > @@ -3,7 +3,7 @@
> >
> >    Copyright (C) 2015-2016, Red Hat, Inc.
> >    Copyright (c) 2014, ARM Ltd. All rights reserved.<BR>
> > -  Copyright (c) 2004 - 2016, Intel Corporation. All rights
> > reserved.<BR>
> > +  Copyright (c) 2004 - 2018, Intel Corporation. All rights
> > + reserved.<BR>
> >    Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
> >
> >    This program and the accompanying materials are licensed and made
> > available @@ -766,3 +766,19 @@ PlatformBootManagerWaitCallback (
> >      Print (L".");
> >    }
> >  }
> > +
> > +/**
> > +  The function is called when no boot option could be launched,
> > +  including platform recovery options and options pointing to
> > +applications
> > +  built into firmware volumes.
> > +
> > +  If this function returns, BDS attempts to enter an infinite loop.
> > +**/
> > +VOID
> > +EFIAPI
> > +PlatformBootManagerUnableToBoot (
> > +  VOID
> > +  )
> > +{
> > +  return;
> > +}
> > --
> > 2.16.1.windows.1
> >
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v4 6/9] ArmPkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot
Posted by Ard Biesheuvel 7 years, 6 months ago 

> On 16 Jul 2018, at 17:07, Ni, Ruiyu <ruiyu.ni@intel.com> wrote:
> 
> Can someone give a r-b for this patch?
> Is Ack-by enough for a check-in?

Hi Ray,

Please go ahead and merge this patch with my ack.

Ard.

> 
>> -----Original Message-----
>> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Sent: Wednesday, July 11, 2018 10:21 PM
>> To: Ni, Ruiyu <ruiyu.ni@intel.com>
>> Cc: edk2-devel@lists.01.org; Leif Lindholm <leif.lindholm@linaro.org>
>> Subject: Re: [PATCH v4 6/9] ArmPkg/PlatformBDS: Implement
>> PlatformBootManagerUnableToBoot
>> 
>>> On 4 July 2018 at 03:50, Ruiyu Ni <ruiyu.ni@intel.com> wrote:
>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
>>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> 
>> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> 
>>> ---
>>> ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 18
>>> +++++++++++++++++-
>>> 1 file changed, 17 insertions(+), 1 deletion(-)
>>> 
>>> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
>>> b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
>>> index 079f1552d5..f9c71d430c 100644
>>> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
>>> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
>>> @@ -3,7 +3,7 @@
>>> 
>>>   Copyright (C) 2015-2016, Red Hat, Inc.
>>>   Copyright (c) 2014, ARM Ltd. All rights reserved.<BR>
>>> -  Copyright (c) 2004 - 2016, Intel Corporation. All rights
>>> reserved.<BR>
>>> +  Copyright (c) 2004 - 2018, Intel Corporation. All rights
>>> + reserved.<BR>
>>>   Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
>>> 
>>>   This program and the accompanying materials are licensed and made
>>> available @@ -766,3 +766,19 @@ PlatformBootManagerWaitCallback (
>>>     Print (L".");
>>>   }
>>> }
>>> +
>>> +/**
>>> +  The function is called when no boot option could be launched,
>>> +  including platform recovery options and options pointing to
>>> +applications
>>> +  built into firmware volumes.
>>> +
>>> +  If this function returns, BDS attempts to enter an infinite loop.
>>> +**/
>>> +VOID
>>> +EFIAPI
>>> +PlatformBootManagerUnableToBoot (
>>> +  VOID
>>> +  )
>>> +{
>>> +  return;
>>> +}
>>> --
>>> 2.16.1.windows.1
>>> 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.