[edk2] [patch] MdeModulePkg/DisplayUpdateProgressLib: Fix ECC issues

Dandan Bi posted 1 patch 5 years, 10 months ago
Failed in applying to current master (apply log)
.../DisplayUpdateProgressLibGraphics.c                              | 6 +++---
.../DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.c     | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
[edk2] [patch] MdeModulePkg/DisplayUpdateProgressLib: Fix ECC issues
Posted by Dandan Bi 5 years, 10 months ago
Make the comment align with Edk2 coding style.

Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 .../DisplayUpdateProgressLibGraphics.c                              | 6 +++---
 .../DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.c     | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.c b/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.c
index 007522cea08..2c916105136 100644
--- a/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.c
+++ b/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.c
@@ -1,6 +1,6 @@
-/**  @file
+/** @file
   Provides services to display completion progress of a firmware update on a
   graphical console that supports the Graphics Output Protocol.
 
   Copyright (c) 2016, Microsoft Corporation. All rights reserved.<BR>
   Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
@@ -116,17 +116,17 @@ const EFI_GRAPHICS_OUTPUT_BLT_PIXEL_UNION  mProgressBarDefaultColor = {
 // Set to TRUE if a valid Graphics Output Protocol is found and the progress
 // bar fits under the boot logo using the current graphics mode.
 //
 BOOLEAN mGraphicsGood = FALSE;
 
-/*
+/**
   Internal function used to find the bounds of the white logo (on black or
   red background).
 
   These bounds are then computed to find the block size, 0%, 100%, etc.
 
-*/
+**/
 VOID
 FindDim (
    VOID
   )
 {
diff --git a/MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.c b/MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.c
index 7aca8b89d01..960ccc015fe 100644
--- a/MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.c
+++ b/MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.c
@@ -1,6 +1,6 @@
-/**  @file
+/** @file
   Provides services to display completion progress of a firmware update on a
   text console.
 
   Copyright (c) 2016, Microsoft Corporation. All rights reserved.<BR>
   Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
-- 
2.14.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [patch] MdeModulePkg/DisplayUpdateProgressLib: Fix ECC issues
Posted by Zeng, Star 5 years, 10 months ago
Reviewed-by: Star Zeng <star.zeng@intel.com>

-----Original Message-----
From: Bi, Dandan 
Sent: Tuesday, June 5, 2018 4:36 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>
Subject: [patch] MdeModulePkg/DisplayUpdateProgressLib: Fix ECC issues

Make the comment align with Edk2 coding style.

Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 .../DisplayUpdateProgressLibGraphics.c                              | 6 +++---
 .../DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.c     | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.c b/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.c
index 007522cea08..2c916105136 100644
--- a/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.c
+++ b/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.c
@@ -1,6 +1,6 @@
-/**  @file
+/** @file
   Provides services to display completion progress of a firmware update on a
   graphical console that supports the Graphics Output Protocol.
 
   Copyright (c) 2016, Microsoft Corporation. All rights reserved.<BR>
   Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
@@ -116,17 +116,17 @@ const EFI_GRAPHICS_OUTPUT_BLT_PIXEL_UNION  mProgressBarDefaultColor = {
 // Set to TRUE if a valid Graphics Output Protocol is found and the progress
 // bar fits under the boot logo using the current graphics mode.
 //
 BOOLEAN mGraphicsGood = FALSE;
 
-/*
+/**
   Internal function used to find the bounds of the white logo (on black or
   red background).
 
   These bounds are then computed to find the block size, 0%, 100%, etc.
 
-*/
+**/
 VOID
 FindDim (
    VOID
   )
 {
diff --git a/MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.c b/MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.c
index 7aca8b89d01..960ccc015fe 100644
--- a/MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.c
+++ b/MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.c
@@ -1,6 +1,6 @@
-/**  @file
+/** @file
   Provides services to display completion progress of a firmware update on a
   text console.
 
   Copyright (c) 2016, Microsoft Corporation. All rights reserved.<BR>
   Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
-- 
2.14.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel