[edk2] [PATCH] ArmVirtPkg: add NOOPT target to platform .DSCs

Ard Biesheuvel posted 1 patch 6 years, 11 months ago
ArmVirtPkg/ArmVirtQemu.dsc       | 2 +-
ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +-
ArmVirtPkg/ArmVirtXen.dsc        | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
[edk2] [PATCH] ArmVirtPkg: add NOOPT target to platform .DSCs
Posted by Ard Biesheuvel 6 years, 11 months ago
In order to allow the ArmVirtPkg platforms to be built using the
NOOPT target, add it explicitly to the BUILD_TARGETS define.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 ArmVirtPkg/ArmVirtQemu.dsc       | 2 +-
 ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +-
 ArmVirtPkg/ArmVirtXen.dsc        | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
index f09226671827..76a83b99a303 100644
--- a/ArmVirtPkg/ArmVirtQemu.dsc
+++ b/ArmVirtPkg/ArmVirtQemu.dsc
@@ -25,7 +25,7 @@ [Defines]
   DSC_SPECIFICATION              = 0x00010005
   OUTPUT_DIRECTORY               = Build/ArmVirtQemu-$(ARCH)
   SUPPORTED_ARCHITECTURES        = AARCH64|ARM
-  BUILD_TARGETS                  = DEBUG|RELEASE
+  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
   SKUID_IDENTIFIER               = DEFAULT
   FLASH_DEFINITION               = ArmVirtPkg/ArmVirtQemu.fdf
 
diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
index cc2c5a50c925..7d9a9196d640 100644
--- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
+++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
@@ -25,7 +25,7 @@ [Defines]
   DSC_SPECIFICATION              = 0x00010005
   OUTPUT_DIRECTORY               = Build/ArmVirtQemuKernel-$(ARCH)
   SUPPORTED_ARCHITECTURES        = AARCH64|ARM
-  BUILD_TARGETS                  = DEBUG|RELEASE
+  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
   SKUID_IDENTIFIER               = DEFAULT
   FLASH_DEFINITION               = ArmVirtPkg/ArmVirtQemuKernel.fdf
 
diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc
index 9b3cc2bd5a10..175b56d10c8f 100644
--- a/ArmVirtPkg/ArmVirtXen.dsc
+++ b/ArmVirtPkg/ArmVirtXen.dsc
@@ -25,7 +25,7 @@ [Defines]
   DSC_SPECIFICATION              = 0x00010005
   OUTPUT_DIRECTORY               = Build/ArmVirtXen-$(ARCH)
   SUPPORTED_ARCHITECTURES        = AARCH64|ARM
-  BUILD_TARGETS                  = DEBUG|RELEASE
+  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
   SKUID_IDENTIFIER               = DEFAULT
   FLASH_DEFINITION               = ArmVirtPkg/ArmVirtXen.fdf
 
-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] ArmVirtPkg: add NOOPT target to platform .DSCs
Posted by Laszlo Ersek 6 years, 11 months ago
On 12/06/17 12:37, Ard Biesheuvel wrote:
> In order to allow the ArmVirtPkg platforms to be built using the
> NOOPT target, add it explicitly to the BUILD_TARGETS define.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  ArmVirtPkg/ArmVirtQemu.dsc       | 2 +-
>  ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +-
>  ArmVirtPkg/ArmVirtXen.dsc        | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index f09226671827..76a83b99a303 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -25,7 +25,7 @@ [Defines]
>    DSC_SPECIFICATION              = 0x00010005
>    OUTPUT_DIRECTORY               = Build/ArmVirtQemu-$(ARCH)
>    SUPPORTED_ARCHITECTURES        = AARCH64|ARM
> -  BUILD_TARGETS                  = DEBUG|RELEASE
> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
>    SKUID_IDENTIFIER               = DEFAULT
>    FLASH_DEFINITION               = ArmVirtPkg/ArmVirtQemu.fdf
>  
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index cc2c5a50c925..7d9a9196d640 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -25,7 +25,7 @@ [Defines]
>    DSC_SPECIFICATION              = 0x00010005
>    OUTPUT_DIRECTORY               = Build/ArmVirtQemuKernel-$(ARCH)
>    SUPPORTED_ARCHITECTURES        = AARCH64|ARM
> -  BUILD_TARGETS                  = DEBUG|RELEASE
> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
>    SKUID_IDENTIFIER               = DEFAULT
>    FLASH_DEFINITION               = ArmVirtPkg/ArmVirtQemuKernel.fdf
>  
> diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc
> index 9b3cc2bd5a10..175b56d10c8f 100644
> --- a/ArmVirtPkg/ArmVirtXen.dsc
> +++ b/ArmVirtPkg/ArmVirtXen.dsc
> @@ -25,7 +25,7 @@ [Defines]
>    DSC_SPECIFICATION              = 0x00010005
>    OUTPUT_DIRECTORY               = Build/ArmVirtXen-$(ARCH)
>    SUPPORTED_ARCHITECTURES        = AARCH64|ARM
> -  BUILD_TARGETS                  = DEBUG|RELEASE
> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
>    SKUID_IDENTIFIER               = DEFAULT
>    FLASH_DEFINITION               = ArmVirtPkg/ArmVirtXen.fdf
>  
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] ArmVirtPkg: add NOOPT target to platform .DSCs
Posted by Ard Biesheuvel 6 years, 10 months ago
On 6 December 2017 at 14:14, Laszlo Ersek <lersek@redhat.com> wrote:
> On 12/06/17 12:37, Ard Biesheuvel wrote:
>> In order to allow the ArmVirtPkg platforms to be built using the
>> NOOPT target, add it explicitly to the BUILD_TARGETS define.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>>  ArmVirtPkg/ArmVirtQemu.dsc       | 2 +-
>>  ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +-
>>  ArmVirtPkg/ArmVirtXen.dsc        | 2 +-
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
>> index f09226671827..76a83b99a303 100644
>> --- a/ArmVirtPkg/ArmVirtQemu.dsc
>> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
>> @@ -25,7 +25,7 @@ [Defines]
>>    DSC_SPECIFICATION              = 0x00010005
>>    OUTPUT_DIRECTORY               = Build/ArmVirtQemu-$(ARCH)
>>    SUPPORTED_ARCHITECTURES        = AARCH64|ARM
>> -  BUILD_TARGETS                  = DEBUG|RELEASE
>> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
>>    SKUID_IDENTIFIER               = DEFAULT
>>    FLASH_DEFINITION               = ArmVirtPkg/ArmVirtQemu.fdf
>>
>> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
>> index cc2c5a50c925..7d9a9196d640 100644
>> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
>> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
>> @@ -25,7 +25,7 @@ [Defines]
>>    DSC_SPECIFICATION              = 0x00010005
>>    OUTPUT_DIRECTORY               = Build/ArmVirtQemuKernel-$(ARCH)
>>    SUPPORTED_ARCHITECTURES        = AARCH64|ARM
>> -  BUILD_TARGETS                  = DEBUG|RELEASE
>> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
>>    SKUID_IDENTIFIER               = DEFAULT
>>    FLASH_DEFINITION               = ArmVirtPkg/ArmVirtQemuKernel.fdf
>>
>> diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc
>> index 9b3cc2bd5a10..175b56d10c8f 100644
>> --- a/ArmVirtPkg/ArmVirtXen.dsc
>> +++ b/ArmVirtPkg/ArmVirtXen.dsc
>> @@ -25,7 +25,7 @@ [Defines]
>>    DSC_SPECIFICATION              = 0x00010005
>>    OUTPUT_DIRECTORY               = Build/ArmVirtXen-$(ARCH)
>>    SUPPORTED_ARCHITECTURES        = AARCH64|ARM
>> -  BUILD_TARGETS                  = DEBUG|RELEASE
>> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
>>    SKUID_IDENTIFIER               = DEFAULT
>>    FLASH_DEFINITION               = ArmVirtPkg/ArmVirtXen.fdf
>>
>>
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks. Pushed as 80ee06cee70c
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel