On Mon, Nov 20, 2017 at 11:45:03AM +0000, Ard Biesheuvel wrote:
> Remove two pieces of legacy that are only used by platforms residing under
> Platform/ARM in edk2-platforms, and really shouldn't serve as examples for
> new contributions. So after migrating the code to edk2-platforms, remove it
> from EDK2.
1/2 should also delete
---
# FDT installation
EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf {
<LibraryClasses>
# It depends on BdsLib that depends on TimerLib
TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
}
---
from EmbeddedPkg/EmbeddedPkg.dsc
and 2/2 should delete the
---
BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf
---
resolution from the same file.
2/2 should also delete the BdsLib references from ArmPkg/ArmPkg.dsc:
---
[LibraryClasses.common]
BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf
---
and
---
[Components.common]
ArmPkg/Library/BdsLib/BdsLib.inf
---
And both should be ordered after the Android*Boot patches I just sent out.
If you do that, and fold in the above comments:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> Ard Biesheuvel (2):
> EmbeddedPkg: remove FdtPlatformDxe
> ArmPkg: remove BdsLib and remaining ARM BDS related PCDs
>
> ArmPkg/ArmPkg.dec | 8 -
> ArmPkg/Library/BdsLib/BdsAppLoader.c | 253 ----
> ArmPkg/Library/BdsLib/BdsFilePath.c | 1411 --------------------
> ArmPkg/Library/BdsLib/BdsHelper.c | 183 ---
> ArmPkg/Library/BdsLib/BdsInternal.h | 111 --
> ArmPkg/Library/BdsLib/BdsLib.inf | 69 -
> ArmPkg/Library/BdsLib/BdsLoadOption.c | 272 ----
> BeagleBoardPkg/BeagleBoardPkg.dsc | 3 -
> EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.c | 461 -------
> EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.h | 174 ---
> EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf | 64 -
> EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.uni | 109 --
> EmbeddedPkg/Drivers/FdtPlatformDxe/README.txt | 72 -
> EmbeddedPkg/Drivers/FdtPlatformDxe/ShellDumpFdt.c | 279 ----
> EmbeddedPkg/Drivers/FdtPlatformDxe/ShellSetFdt.c | 468 -------
> EmbeddedPkg/EmbeddedPkg.dec | 6 -
> 16 files changed, 3943 deletions(-)
> delete mode 100644 ArmPkg/Library/BdsLib/BdsAppLoader.c
> delete mode 100644 ArmPkg/Library/BdsLib/BdsFilePath.c
> delete mode 100644 ArmPkg/Library/BdsLib/BdsHelper.c
> delete mode 100644 ArmPkg/Library/BdsLib/BdsInternal.h
> delete mode 100644 ArmPkg/Library/BdsLib/BdsLib.inf
> delete mode 100644 ArmPkg/Library/BdsLib/BdsLoadOption.c
> delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.c
> delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.h
> delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf
> delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.uni
> delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/README.txt
> delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/ShellDumpFdt.c
> delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/ShellSetFdt.c
>
> --
> 2.11.0
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel