ShellPkg/HandleParsingLib: Remove unnecessary CatSPrint call

[edk2] [PATCH] ShellPkg/HandleParsingLib: Remove unnecessary CatSPrint call

Posted by Ruiyu Ni 6 years, 6 months ago

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
---
 ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
index 15103160d9..d343f3352e 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
@@ -259,9 +259,7 @@ LoadedImageProtocolDumpInformation(
     } else {
       SHELL_FREE_NON_NULL(FilePath);
     }
-    RetVal = CatSPrint(NULL, FileName);
-    SHELL_FREE_NON_NULL(FileName);
-    return RetVal;
+    return FileName;
   }
 
   HandleParsingHiiInit();
-- 
2.12.2.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg/HandleParsingLib: Remove unnecessary CatSPrint call

Posted by Carsey, Jaben 6 years, 6 months ago

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Monday, October 23, 2017 10:38 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [PATCH] ShellPkg/HandleParsingLib: Remove unnecessary CatSPrint
> call
> Importance: High
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
>  ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> index 15103160d9..d343f3352e 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> @@ -259,9 +259,7 @@ LoadedImageProtocolDumpInformation(
>      } else {
>        SHELL_FREE_NON_NULL(FilePath);
>      }
> -    RetVal = CatSPrint(NULL, FileName);
> -    SHELL_FREE_NON_NULL(FileName);
> -    return RetVal;
> +    return FileName;
>    }
> 
>    HandleParsingHiiInit();
> --
> 2.12.2.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel