ArmVirtPkg: drop unused Pcds from ArmVirt.dsc.inc

[edk2] [PATCH] ArmVirtPkg: drop unused Pcds from ArmVirt.dsc.inc

Posted by Leif Lindholm 6 years, 8 months ago

A block of settings has been copied around ARM platforms for years.
These are consumed only by Ebl, and since none of the ArmVirtPkg
platforms use that, drop them.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
 ArmVirtPkg/ArmVirt.dsc.inc | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index bfc40286d7..6a5544e695 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -259,18 +259,6 @@
 [PcdsFeatureFlag.common]
   gEfiMdeModulePkgTokenSpaceGuid.PcdHiiOsRuntimeSupport|FALSE
 
-  #
-  # Control what commands are supported from the UI
-  # Turn these on and off to add features or save size
-  #
-  gEmbeddedTokenSpaceGuid.PcdEmbeddedMacBoot|TRUE
-  gEmbeddedTokenSpaceGuid.PcdEmbeddedDirCmd|TRUE
-  gEmbeddedTokenSpaceGuid.PcdEmbeddedHobCmd|TRUE
-  gEmbeddedTokenSpaceGuid.PcdEmbeddedHwDebugCmd|TRUE
-  gEmbeddedTokenSpaceGuid.PcdEmbeddedPciDebugCmd|TRUE
-  gEmbeddedTokenSpaceGuid.PcdEmbeddedIoEnable|FALSE
-  gEmbeddedTokenSpaceGuid.PcdEmbeddedScriptCmd|FALSE
-
   gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE
 
   # Use the Vector Table location in CpuDxe. We will not copy the Vector Table at PcdCpuVectorBaseAddress
-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ArmVirtPkg: drop unused Pcds from ArmVirt.dsc.inc

Posted by Laszlo Ersek 6 years, 8 months ago

On 08/24/17 18:20, Leif Lindholm wrote:
> A block of settings has been copied around ARM platforms for years.
> These are consumed only by Ebl, and since none of the ArmVirtPkg
> platforms use that, drop them.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>  ArmVirtPkg/ArmVirt.dsc.inc | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index bfc40286d7..6a5544e695 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -259,18 +259,6 @@
>  [PcdsFeatureFlag.common]
>    gEfiMdeModulePkgTokenSpaceGuid.PcdHiiOsRuntimeSupport|FALSE
>  
> -  #
> -  # Control what commands are supported from the UI
> -  # Turn these on and off to add features or save size
> -  #
> -  gEmbeddedTokenSpaceGuid.PcdEmbeddedMacBoot|TRUE
> -  gEmbeddedTokenSpaceGuid.PcdEmbeddedDirCmd|TRUE
> -  gEmbeddedTokenSpaceGuid.PcdEmbeddedHobCmd|TRUE
> -  gEmbeddedTokenSpaceGuid.PcdEmbeddedHwDebugCmd|TRUE
> -  gEmbeddedTokenSpaceGuid.PcdEmbeddedPciDebugCmd|TRUE
> -  gEmbeddedTokenSpaceGuid.PcdEmbeddedIoEnable|FALSE
> -  gEmbeddedTokenSpaceGuid.PcdEmbeddedScriptCmd|FALSE
> -
>    gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE
>  
>    # Use the Vector Table location in CpuDxe. We will not copy the Vector Table at PcdCpuVectorBaseAddress
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks,
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ArmVirtPkg: drop unused Pcds from ArmVirt.dsc.inc

Posted by Ard Biesheuvel 6 years, 8 months ago

On 24 August 2017 at 17:59, Laszlo Ersek <lersek@redhat.com> wrote:
> On 08/24/17 18:20, Leif Lindholm wrote:
>> A block of settings has been copied around ARM platforms for years.
>> These are consumed only by Ebl, and since none of the ArmVirtPkg
>> platforms use that, drop them.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>> ---
>>  ArmVirtPkg/ArmVirt.dsc.inc | 12 ------------
>>  1 file changed, 12 deletions(-)
>>
>> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
>> index bfc40286d7..6a5544e695 100644
>> --- a/ArmVirtPkg/ArmVirt.dsc.inc
>> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
>> @@ -259,18 +259,6 @@
>>  [PcdsFeatureFlag.common]
>>    gEfiMdeModulePkgTokenSpaceGuid.PcdHiiOsRuntimeSupport|FALSE
>>
>> -  #
>> -  # Control what commands are supported from the UI
>> -  # Turn these on and off to add features or save size
>> -  #
>> -  gEmbeddedTokenSpaceGuid.PcdEmbeddedMacBoot|TRUE
>> -  gEmbeddedTokenSpaceGuid.PcdEmbeddedDirCmd|TRUE
>> -  gEmbeddedTokenSpaceGuid.PcdEmbeddedHobCmd|TRUE
>> -  gEmbeddedTokenSpaceGuid.PcdEmbeddedHwDebugCmd|TRUE
>> -  gEmbeddedTokenSpaceGuid.PcdEmbeddedPciDebugCmd|TRUE
>> -  gEmbeddedTokenSpaceGuid.PcdEmbeddedIoEnable|FALSE
>> -  gEmbeddedTokenSpaceGuid.PcdEmbeddedScriptCmd|FALSE
>> -
>>    gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE
>>
>>    # Use the Vector Table location in CpuDxe. We will not copy the Vector Table at PcdCpuVectorBaseAddress
>>
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>

Pushed as ae9e4650cdf8a7e6790f74e54a9276700dd9d894

Thanks,
Ard.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel