[v2] Re-enable the second SATA controller on Overdrive

[edk2] [PATCH v2 edk2-platforms 0/3] Re-enable the second SATA controller on Overdrive

Posted by Alan Ott 6 years, 8 months ago

Without the PCD for the second SATA Controller being specified, the boot
will hang. These patches fix it.

Alan Ott (3):
  Silicon/AMD/Styx: Make PcdSataPortMode 32 bits
  Silicon/AMD/Styx: Use PcdSataPortMode properly for two controllers
  Platform/AMD/OverdriveBoard: Re-enable the second SATA Controller

 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc              | 10 +++-------
 Silicon/AMD/Styx/AmdStyx.dec                                |  2 +-
 .../AMD/Styx/Drivers/StyxSataPlatformDxe/InitController.c   | 13 +++++++++----
 3 files changed, 13 insertions(+), 12 deletions(-)

-- 
2.9.3

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 edk2-platforms 0/3] Re-enable the second SATA controller on Overdrive

Posted by Ard Biesheuvel 6 years, 8 months ago

On 20 August 2017 at 20:33, Alan Ott <alan@softiron.com> wrote:
> Without the PCD for the second SATA Controller being specified, the boot
> will hang. These patches fix it.
>
> Alan Ott (3):
>   Silicon/AMD/Styx: Make PcdSataPortMode 32 bits
>   Silicon/AMD/Styx: Use PcdSataPortMode properly for two controllers
>   Platform/AMD/OverdriveBoard: Re-enable the second SATA Controller
>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 edk2-platforms 0/3] Re-enable the second SATA controller on Overdrive

Posted by Leif Lindholm 6 years, 7 months ago

On Sun, Aug 20, 2017 at 03:33:32PM -0400, Alan Ott wrote:
> Without the PCD for the second SATA Controller being specified, the boot
> will hang. These patches fix it.

Given Ard's RB, I'm happy for this to go in.
However, would you be happy to contribute these under TianoCore
Contribution Agreement 1.1 rather than 1.0?

If so, please confirm here and I can fold in the change before
pushing.

/
    Leif

> Alan Ott (3):
>   Silicon/AMD/Styx: Make PcdSataPortMode 32 bits
>   Silicon/AMD/Styx: Use PcdSataPortMode properly for two controllers
>   Platform/AMD/OverdriveBoard: Re-enable the second SATA Controller
> 
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc              | 10 +++-------
>  Silicon/AMD/Styx/AmdStyx.dec                                |  2 +-
>  .../AMD/Styx/Drivers/StyxSataPlatformDxe/InitController.c   | 13 +++++++++----
>  3 files changed, 13 insertions(+), 12 deletions(-)
> 
> -- 
> 2.9.3
> 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 edk2-platforms 0/3] Re-enable the second SATA controller on Overdrive

Posted by Alan Ott 6 years, 7 months ago

On 08/21/2017 10:12 AM, Leif Lindholm wrote:
> On Sun, Aug 20, 2017 at 03:33:32PM -0400, Alan Ott wrote:
>> Without the PCD for the second SATA Controller being specified, the boot
>> will hang. These patches fix it.
>
> Given Ard's RB, I'm happy for this to go in.
> However, would you be happy to contribute these under TianoCore
> Contribution Agreement 1.1 rather than 1.0?
>
> If so, please confirm here and I can fold in the change before
> pushing.

Contributed-under: TianoCore Contribution Agreement 1.1

Thanks Leif!

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 edk2-platforms 0/3] Re-enable the second SATA controller on Overdrive

Posted by Leif Lindholm 6 years, 7 months ago

On Mon, Aug 21, 2017 at 10:20:11AM -0400, Alan Ott wrote:
> On 08/21/2017 10:12 AM, Leif Lindholm wrote:
> > On Sun, Aug 20, 2017 at 03:33:32PM -0400, Alan Ott wrote:
> > > Without the PCD for the second SATA Controller being specified, the boot
> > > will hang. These patches fix it.
> > 
> > Given Ard's RB, I'm happy for this to go in.
> > However, would you be happy to contribute these under TianoCore
> > Contribution Agreement 1.1 rather than 1.0?
> > 
> > If so, please confirm here and I can fold in the change before
> > pushing.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> 
> Thanks Leif!

Thanks, Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Series pushed as 7d9c49468..b263c30e5.

/
    Leif
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel