1. Patchew
  2. EDK2
  3. View series

[edk2] [PATCH 0/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol

Ruiyu Ni posted 3 patches 6 years, 9 months ago
Failed in applying to current master (apply log)
.../Universal/ResetSystemRuntimeDxe/ResetSystem.c  | 146 +++++++++++++++++++--
.../Universal/ResetSystemRuntimeDxe/ResetSystem.h  |  21 ++-
.../ResetSystemRuntimeDxe.inf                      |   5 +-
MdePkg/Include/Protocol/ResetNotification.h        |  86 ++++++++++++
MdePkg/MdePkg.dec                                  |   3 +
5 files changed, 247 insertions(+), 14 deletions(-)
create mode 100644 MdePkg/Include/Protocol/ResetNotification.h
[edk2] [PATCH 0/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol
Posted by Ruiyu Ni 6 years, 9 months ago 
Ruiyu Ni (3):
  MdePkg: Add ResetNotification protocol definition
  MdeModulePkg/ResetSystem: Remove unnecessary global variable
  MdeModulePkg/ResetSystem: Implement ResetNotification protocol

 .../Universal/ResetSystemRuntimeDxe/ResetSystem.c  | 146 +++++++++++++++++++--
 .../Universal/ResetSystemRuntimeDxe/ResetSystem.h  |  21 ++-
 .../ResetSystemRuntimeDxe.inf                      |   5 +-
 MdePkg/Include/Protocol/ResetNotification.h        |  86 ++++++++++++
 MdePkg/MdePkg.dec                                  |   3 +
 5 files changed, 247 insertions(+), 14 deletions(-)
 create mode 100644 MdePkg/Include/Protocol/ResetNotification.h

-- 
2.12.2.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol
Posted by Laszlo Ersek 6 years, 9 months ago 
Ard, Leif,

On 06/29/17 10:32, Ruiyu Ni wrote:
> Ruiyu Ni (3):
>   MdePkg: Add ResetNotification protocol definition
>   MdeModulePkg/ResetSystem: Remove unnecessary global variable
>   MdeModulePkg/ResetSystem: Implement ResetNotification protocol
> 
>  .../Universal/ResetSystemRuntimeDxe/ResetSystem.c  | 146 +++++++++++++++++++--
>  .../Universal/ResetSystemRuntimeDxe/ResetSystem.h  |  21 ++-
>  .../ResetSystemRuntimeDxe.inf                      |   5 +-
>  MdePkg/Include/Protocol/ResetNotification.h        |  86 ++++++++++++
>  MdePkg/MdePkg.dec                                  |   3 +
>  5 files changed, 247 insertions(+), 14 deletions(-)
>  create mode 100644 MdePkg/Include/Protocol/ResetNotification.h
> 

I think we should
- either port this feature (patch 3/3) to EmbeddedPkg/ResetRuntimeDxe,
- or else rebase all platforms that consume EmbeddedPkg/ResetRuntimeDxe
to MdeModulePkg/Universal/ResetSystemRuntimeDxe, and delete
EmbeddedPkg/ResetRuntimeDxe from the tree.

What do you guys think?

Other producers of gEfiResetArchProtocolGuid could be affected as well
(just from a quick grep):
- DuetPkg/AcpiResetDxe
- EmulatorPkg/ResetRuntimeDxe
- Nt32Pkg/ResetRuntimeDxe

Thanks
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol
Posted by Ard Biesheuvel 6 years, 9 months ago 
On 1 July 2017 at 21:04, Laszlo Ersek <lersek@redhat.com> wrote:
> Ard, Leif,
>
> On 06/29/17 10:32, Ruiyu Ni wrote:
>> Ruiyu Ni (3):
>>   MdePkg: Add ResetNotification protocol definition
>>   MdeModulePkg/ResetSystem: Remove unnecessary global variable
>>   MdeModulePkg/ResetSystem: Implement ResetNotification protocol
>>
>>  .../Universal/ResetSystemRuntimeDxe/ResetSystem.c  | 146 +++++++++++++++++++--
>>  .../Universal/ResetSystemRuntimeDxe/ResetSystem.h  |  21 ++-
>>  .../ResetSystemRuntimeDxe.inf                      |   5 +-
>>  MdePkg/Include/Protocol/ResetNotification.h        |  86 ++++++++++++
>>  MdePkg/MdePkg.dec                                  |   3 +
>>  5 files changed, 247 insertions(+), 14 deletions(-)
>>  create mode 100644 MdePkg/Include/Protocol/ResetNotification.h
>>
>
> I think we should
> - either port this feature (patch 3/3) to EmbeddedPkg/ResetRuntimeDxe,
> - or else rebase all platforms that consume EmbeddedPkg/ResetRuntimeDxe
> to MdeModulePkg/Universal/ResetSystemRuntimeDxe, and delete
> EmbeddedPkg/ResetRuntimeDxe from the tree.
>
> What do you guys think?
>

I would happily get rid of EmbeddedPkg/ResetRuntimeDxe, given that I
can't really tell why it is there in the first place. Anyone have a
clue?

> Other producers of gEfiResetArchProtocolGuid could be affected as well
> (just from a quick grep):
> - DuetPkg/AcpiResetDxe
> - EmulatorPkg/ResetRuntimeDxe
> - Nt32Pkg/ResetRuntimeDxe
>
> Thanks
> Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol
Posted by Leif Lindholm 6 years, 9 months ago 
On Sat, Jul 01, 2017 at 11:04:08PM +0200, Laszlo Ersek wrote:
> Ard, Leif,
> 
> On 06/29/17 10:32, Ruiyu Ni wrote:
> > Ruiyu Ni (3):
> >   MdePkg: Add ResetNotification protocol definition
> >   MdeModulePkg/ResetSystem: Remove unnecessary global variable
> >   MdeModulePkg/ResetSystem: Implement ResetNotification protocol
> > 
> >  .../Universal/ResetSystemRuntimeDxe/ResetSystem.c  | 146 +++++++++++++++++++--
> >  .../Universal/ResetSystemRuntimeDxe/ResetSystem.h  |  21 ++-
> >  .../ResetSystemRuntimeDxe.inf                      |   5 +-
> >  MdePkg/Include/Protocol/ResetNotification.h        |  86 ++++++++++++
> >  MdePkg/MdePkg.dec                                  |   3 +
> >  5 files changed, 247 insertions(+), 14 deletions(-)
> >  create mode 100644 MdePkg/Include/Protocol/ResetNotification.h
> > 
> 
> I think we should
> - either port this feature (patch 3/3) to EmbeddedPkg/ResetRuntimeDxe,
> - or else rebase all platforms that consume EmbeddedPkg/ResetRuntimeDxe
> to MdeModulePkg/Universal/ResetSystemRuntimeDxe, and delete
> EmbeddedPkg/ResetRuntimeDxe from the tree.
> 
> What do you guys think?

I think deleting the EmbeddedPkg one, and making the current consumers
implement ResetSystemLib instead of EfiResetSystemLib would be an
improvement.

At a quick skim, the only functionality I can see added in
EmbeddedPkg/ResetRuntimeDxe is the LibInitializeResetSystem
function. The only (ARM) platform I can see doing anything useful
there is the Armada ... and that code could move.

/
    Leif

> Other producers of gEfiResetArchProtocolGuid could be affected as well
> (just from a quick grep):
> - DuetPkg/AcpiResetDxe
> - EmulatorPkg/ResetRuntimeDxe
> - Nt32Pkg/ResetRuntimeDxe
> 
> Thanks
> Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol
Posted by Laszlo Ersek 6 years, 9 months ago 
On 07/03/17 14:09, Leif Lindholm wrote:
> On Sat, Jul 01, 2017 at 11:04:08PM +0200, Laszlo Ersek wrote:
>> Ard, Leif,
>>
>> On 06/29/17 10:32, Ruiyu Ni wrote:
>>> Ruiyu Ni (3):
>>>   MdePkg: Add ResetNotification protocol definition
>>>   MdeModulePkg/ResetSystem: Remove unnecessary global variable
>>>   MdeModulePkg/ResetSystem: Implement ResetNotification protocol
>>>
>>>  .../Universal/ResetSystemRuntimeDxe/ResetSystem.c  | 146 +++++++++++++++++++--
>>>  .../Universal/ResetSystemRuntimeDxe/ResetSystem.h  |  21 ++-
>>>  .../ResetSystemRuntimeDxe.inf                      |   5 +-
>>>  MdePkg/Include/Protocol/ResetNotification.h        |  86 ++++++++++++
>>>  MdePkg/MdePkg.dec                                  |   3 +
>>>  5 files changed, 247 insertions(+), 14 deletions(-)
>>>  create mode 100644 MdePkg/Include/Protocol/ResetNotification.h
>>>
>>
>> I think we should
>> - either port this feature (patch 3/3) to EmbeddedPkg/ResetRuntimeDxe,
>> - or else rebase all platforms that consume EmbeddedPkg/ResetRuntimeDxe
>> to MdeModulePkg/Universal/ResetSystemRuntimeDxe, and delete
>> EmbeddedPkg/ResetRuntimeDxe from the tree.
>>
>> What do you guys think?
> 
> I think deleting the EmbeddedPkg one, and making the current consumers
> implement ResetSystemLib instead of EfiResetSystemLib would be an
> improvement.

Looks like you and Ard agree this is the best way forward. (I also
agree, I just wasn't sure if it would be your shared preference, due to
the conversion of dependent platforms possibly needing a lot of work.)

Ard, do you want me to file a BZ for the ArmVirtPkg conversion? (I can't
volunteer to actually do the conversion right now; my plate is full.)

Thanks,
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol
Posted by Ard Biesheuvel 6 years, 9 months ago 
On 3 July 2017 at 18:30, Laszlo Ersek <lersek@redhat.com> wrote:
> On 07/03/17 14:09, Leif Lindholm wrote:
>> On Sat, Jul 01, 2017 at 11:04:08PM +0200, Laszlo Ersek wrote:
>>> Ard, Leif,
>>>
>>> On 06/29/17 10:32, Ruiyu Ni wrote:
>>>> Ruiyu Ni (3):
>>>>   MdePkg: Add ResetNotification protocol definition
>>>>   MdeModulePkg/ResetSystem: Remove unnecessary global variable
>>>>   MdeModulePkg/ResetSystem: Implement ResetNotification protocol
>>>>
>>>>  .../Universal/ResetSystemRuntimeDxe/ResetSystem.c  | 146 +++++++++++++++++++--
>>>>  .../Universal/ResetSystemRuntimeDxe/ResetSystem.h  |  21 ++-
>>>>  .../ResetSystemRuntimeDxe.inf                      |   5 +-
>>>>  MdePkg/Include/Protocol/ResetNotification.h        |  86 ++++++++++++
>>>>  MdePkg/MdePkg.dec                                  |   3 +
>>>>  5 files changed, 247 insertions(+), 14 deletions(-)
>>>>  create mode 100644 MdePkg/Include/Protocol/ResetNotification.h
>>>>
>>>
>>> I think we should
>>> - either port this feature (patch 3/3) to EmbeddedPkg/ResetRuntimeDxe,
>>> - or else rebase all platforms that consume EmbeddedPkg/ResetRuntimeDxe
>>> to MdeModulePkg/Universal/ResetSystemRuntimeDxe, and delete
>>> EmbeddedPkg/ResetRuntimeDxe from the tree.
>>>
>>> What do you guys think?
>>
>> I think deleting the EmbeddedPkg one, and making the current consumers
>> implement ResetSystemLib instead of EfiResetSystemLib would be an
>> improvement.
>
> Looks like you and Ard agree this is the best way forward. (I also
> agree, I just wasn't sure if it would be your shared preference, due to
> the conversion of dependent platforms possibly needing a lot of work.)
>
> Ard, do you want me to file a BZ for the ArmVirtPkg conversion? (I can't
> volunteer to actually do the conversion right now; my plate is full.)
>

I already sent the patch a couple of hours ago, but if we need a BZ
entry as well [for documentation purposes], please go ahead and file
one.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol
Posted by Laszlo Ersek 6 years, 9 months ago 
On 07/03/17 19:31, Ard Biesheuvel wrote:
> On 3 July 2017 at 18:30, Laszlo Ersek <lersek@redhat.com> wrote:
>> On 07/03/17 14:09, Leif Lindholm wrote:
>>> On Sat, Jul 01, 2017 at 11:04:08PM +0200, Laszlo Ersek wrote:
>>>> Ard, Leif,
>>>>
>>>> On 06/29/17 10:32, Ruiyu Ni wrote:
>>>>> Ruiyu Ni (3):
>>>>>   MdePkg: Add ResetNotification protocol definition
>>>>>   MdeModulePkg/ResetSystem: Remove unnecessary global variable
>>>>>   MdeModulePkg/ResetSystem: Implement ResetNotification protocol
>>>>>
>>>>>  .../Universal/ResetSystemRuntimeDxe/ResetSystem.c  | 146 +++++++++++++++++++--
>>>>>  .../Universal/ResetSystemRuntimeDxe/ResetSystem.h  |  21 ++-
>>>>>  .../ResetSystemRuntimeDxe.inf                      |   5 +-
>>>>>  MdePkg/Include/Protocol/ResetNotification.h        |  86 ++++++++++++
>>>>>  MdePkg/MdePkg.dec                                  |   3 +
>>>>>  5 files changed, 247 insertions(+), 14 deletions(-)
>>>>>  create mode 100644 MdePkg/Include/Protocol/ResetNotification.h
>>>>>
>>>>
>>>> I think we should
>>>> - either port this feature (patch 3/3) to EmbeddedPkg/ResetRuntimeDxe,
>>>> - or else rebase all platforms that consume EmbeddedPkg/ResetRuntimeDxe
>>>> to MdeModulePkg/Universal/ResetSystemRuntimeDxe, and delete
>>>> EmbeddedPkg/ResetRuntimeDxe from the tree.
>>>>
>>>> What do you guys think?
>>>
>>> I think deleting the EmbeddedPkg one, and making the current consumers
>>> implement ResetSystemLib instead of EfiResetSystemLib would be an
>>> improvement.
>>
>> Looks like you and Ard agree this is the best way forward. (I also
>> agree, I just wasn't sure if it would be your shared preference, due to
>> the conversion of dependent platforms possibly needing a lot of work.)
>>
>> Ard, do you want me to file a BZ for the ArmVirtPkg conversion? (I can't
>> volunteer to actually do the conversion right now; my plate is full.)
>>
> 
> I already sent the patch a couple of hours ago,

Yup, looking at it right now, thanks!

> but if we need a BZ
> entry as well [for documentation purposes], please go ahead and file
> one.

Nah I'm just in the middle of my usual post-PTO email crisis.

Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.