[edk2] [PATCH v3 0/5] Fix undefined behavior in signed left shift

Hao Wu posted 5 patches 7 years, 6 months ago
Failed in applying to current master (apply log)
IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Atapi.c  | 6 +++---
MdeModulePkg/Bus/Pci/IdeBusPei/AtapiPeim.c         | 4 ++--
MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c       | 4 ++--
MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 6 +++---
MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c          | 6 +++---
5 files changed, 13 insertions(+), 13 deletions(-)
[edk2] [PATCH v3 0/5] Fix undefined behavior in signed left shift
Posted by Hao Wu 7 years, 6 months ago
After searching the whole code base, more cases are found related with:
'LastLba3 << 24'

Send a new patch series (V3 based on the patch for ScsiDisk) to fix the
suspicious undefined behavior in signed left shift.

Cc: Feng Tian <feng.tian@intel.com>

Hao Wu (5):
  MdeModulePkg/ScsiDiskDxe: Fix undefined behavior in signed left shift
  MdeModulePkg/IdeBusPei: Fix undefined behavior in signed left shift
  MdeModulePkg/UfsBlkIoPei: Fix undefined behavior in signed left shift
  MdeModulePkg/UsbBotPei: Fix undefined behavior in signed left shift
  IntelFWMdlPkg/IdeBusDxe: Fix undefined behavior in signed left shift

 IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Atapi.c  | 6 +++---
 MdeModulePkg/Bus/Pci/IdeBusPei/AtapiPeim.c         | 4 ++--
 MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c       | 4 ++--
 MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 6 +++---
 MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c          | 6 +++---
 5 files changed, 13 insertions(+), 13 deletions(-)

-- 
2.12.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v3 0/5] Fix undefined behavior in signed left shift
Posted by Tian, Feng 7 years, 6 months ago
Series reviewed-by: Feng Tian <feng.tian@intel.com>

-----Original Message-----
From: Wu, Hao A 
Sent: Wednesday, April 12, 2017 9:52 AM
To: edk2-devel@lists.01.org; guoheyi@huawei.com
Cc: Wu, Hao A <hao.a.wu@intel.com>; Tian, Feng <feng.tian@intel.com>
Subject: [PATCH v3 0/5] Fix undefined behavior in signed left shift

After searching the whole code base, more cases are found related with:
'LastLba3 << 24'

Send a new patch series (V3 based on the patch for ScsiDisk) to fix the suspicious undefined behavior in signed left shift.

Cc: Feng Tian <feng.tian@intel.com>

Hao Wu (5):
  MdeModulePkg/ScsiDiskDxe: Fix undefined behavior in signed left shift
  MdeModulePkg/IdeBusPei: Fix undefined behavior in signed left shift
  MdeModulePkg/UfsBlkIoPei: Fix undefined behavior in signed left shift
  MdeModulePkg/UsbBotPei: Fix undefined behavior in signed left shift
  IntelFWMdlPkg/IdeBusDxe: Fix undefined behavior in signed left shift

 IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Atapi.c  | 6 +++---
 MdeModulePkg/Bus/Pci/IdeBusPei/AtapiPeim.c         | 4 ++--
 MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c       | 4 ++--
 MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 6 +++---
 MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c          | 6 +++---
 5 files changed, 13 insertions(+), 13 deletions(-)

--
2.12.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v3 0/5] Fix undefined behavior in signed left shift
Posted by Tian, Feng 7 years, 6 months ago
PS: lt's a typo on pkg name: IntelFWMdlPkg/IdeBusDxe: Fix undefined behavior in signed left shift

-----Original Message-----
From: Tian, Feng 
Sent: Wednesday, April 12, 2017 9:53 AM
To: Wu, Hao A <hao.a.wu@intel.com>; edk2-devel@lists.01.org; guoheyi@huawei.com
Cc: Tian, Feng <feng.tian@intel.com>
Subject: RE: [PATCH v3 0/5] Fix undefined behavior in signed left shift

Series reviewed-by: Feng Tian <feng.tian@intel.com>

-----Original Message-----
From: Wu, Hao A 
Sent: Wednesday, April 12, 2017 9:52 AM
To: edk2-devel@lists.01.org; guoheyi@huawei.com
Cc: Wu, Hao A <hao.a.wu@intel.com>; Tian, Feng <feng.tian@intel.com>
Subject: [PATCH v3 0/5] Fix undefined behavior in signed left shift

After searching the whole code base, more cases are found related with:
'LastLba3 << 24'

Send a new patch series (V3 based on the patch for ScsiDisk) to fix the suspicious undefined behavior in signed left shift.

Cc: Feng Tian <feng.tian@intel.com>

Hao Wu (5):
  MdeModulePkg/ScsiDiskDxe: Fix undefined behavior in signed left shift
  MdeModulePkg/IdeBusPei: Fix undefined behavior in signed left shift
  MdeModulePkg/UfsBlkIoPei: Fix undefined behavior in signed left shift
  MdeModulePkg/UsbBotPei: Fix undefined behavior in signed left shift
  IntelFWMdlPkg/IdeBusDxe: Fix undefined behavior in signed left shift

 IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Atapi.c  | 6 +++---
 MdeModulePkg/Bus/Pci/IdeBusPei/AtapiPeim.c         | 4 ++--
 MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c       | 4 ++--
 MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 6 +++---
 MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c          | 6 +++---
 5 files changed, 13 insertions(+), 13 deletions(-)

--
2.12.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel