MdeModulePkg/PiSmmCore: Fix potentially uninitialized local variable

[edk2] [PATCH] MdeModulePkg/PiSmmCore: Fix potentially uninitialized local variable

Posted by Hao Wu 7 years, 6 months ago

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 MdeModulePkg/Core/PiSmmCore/Pool.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/Core/PiSmmCore/Pool.c b/MdeModulePkg/Core/PiSmmCore/Pool.c
index f734b3f72d..43ce869d1e 100644
--- a/MdeModulePkg/Core/PiSmmCore/Pool.c
+++ b/MdeModulePkg/Core/PiSmmCore/Pool.c
@@ -1,7 +1,7 @@
 /** @file
   SMM Memory pool management functions.
 
-  Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials are licensed and made available 
   under the terms and conditions of the BSD License which accompanies this 
   distribution.  The full text of the license may be found at        
@@ -136,6 +136,7 @@ InternalAllocPoolByIndex (
   EFI_PHYSICAL_ADDRESS  Address;
   SMM_POOL_TYPE         SmmPoolType;
 
+  Address     = 0;
   SmmPoolType = UefiMemoryTypeToSmmPoolType(PoolType);
 
   ASSERT (PoolIndex <= MAX_POOL_INDEX);
@@ -227,6 +228,8 @@ SmmInternalAllocatePool (
   EFI_PHYSICAL_ADDRESS  Address;
   UINTN                 PoolIndex;
 
+  Address = 0;
+
   if (PoolType != EfiRuntimeServicesCode &&
       PoolType != EfiRuntimeServicesData) {
     return EFI_INVALID_PARAMETER;
-- 
2.12.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: Fix potentially uninitialized local variable

Posted by Yao, Jiewen 7 years, 6 months ago

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Wu, Hao A
> Sent: Monday, April 10, 2017 2:15 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH] MdeModulePkg/PiSmmCore: Fix potentially uninitialized local
> variable
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
>  MdeModulePkg/Core/PiSmmCore/Pool.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Core/PiSmmCore/Pool.c
> b/MdeModulePkg/Core/PiSmmCore/Pool.c
> index f734b3f72d..43ce869d1e 100644
> --- a/MdeModulePkg/Core/PiSmmCore/Pool.c
> +++ b/MdeModulePkg/Core/PiSmmCore/Pool.c
> @@ -1,7 +1,7 @@
>  /** @file
>    SMM Memory pool management functions.
> 
> -  Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.<BR>
>    This program and the accompanying materials are licensed and made available
>    under the terms and conditions of the BSD License which accompanies this
>    distribution.  The full text of the license may be found at
> @@ -136,6 +136,7 @@ InternalAllocPoolByIndex (
>    EFI_PHYSICAL_ADDRESS  Address;
>    SMM_POOL_TYPE         SmmPoolType;
> 
> +  Address     = 0;
>    SmmPoolType = UefiMemoryTypeToSmmPoolType(PoolType);
> 
>    ASSERT (PoolIndex <= MAX_POOL_INDEX);
> @@ -227,6 +228,8 @@ SmmInternalAllocatePool (
>    EFI_PHYSICAL_ADDRESS  Address;
>    UINTN                 PoolIndex;
> 
> +  Address = 0;
> +
>    if (PoolType != EfiRuntimeServicesCode &&
>        PoolType != EfiRuntimeServicesData) {
>      return EFI_INVALID_PARAMETER;
> --
> 2.12.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel