[edk2] [PATCH v2 00/11] Add StrToGuid/HexToBytes/Ipv4/Ipv6 in BaseLib

Ruiyu Ni posted 11 patches 116 weeks ago
Failed in applying to current master (apply log)
MdeModulePkg/Application/CapsuleApp/AppSupport.c   |  140 +--
MdeModulePkg/Application/CapsuleApp/CapsuleApp.c   |   27 +-
MdeModulePkg/Include/Library/NetLib.h              |    5 +-
MdeModulePkg/Library/DxeNetLib/DxeNetLib.c         |  382 +------
MdePkg/Include/Base.h                              |   16 +-
MdePkg/Include/Library/BaseLib.h                   |  445 ++++++++
MdePkg/Include/Uefi/UefiBaseType.h                 |   10 +-
MdePkg/Library/BaseLib/SafeString.c                | 1204 ++++++++++++++++++++
.../Library/UefiDevicePathLib/DevicePathFromText.c |  213 +---
.../SecureBootConfigDxe/SecureBootConfigImpl.c     |   12 +-
.../SecureBootConfigDxe/SecureBootConfigImpl.h     |   22 +-
.../SecureBootConfigDxe/SecureBootConfigMisc.c     |  141 +--
.../Library/UefiShellDebug1CommandsLib/DmpStore.c  |    7 +-
.../Library/UefiShellDebug1CommandsLib/SetVar.c    |   12 +-
.../UefiShellDebug1CommandsLib.c                   |  119 +-
.../UefiShellDebug1CommandsLib.h                   |   32 +-
.../Library/IniParsingLib/IniParsingLib.c          |  148 +--
17 files changed, 1740 insertions(+), 1195 deletions(-)

[edk2] [PATCH v2 00/11] Add StrToGuid/HexToBytes/Ipv4/Ipv6 in BaseLib

Posted by Ruiyu Ni 116 weeks ago
The patch set adds StrToGuid/StrHexToBytes/StrToIPv4Address
/StrToIPv6Address and the accordingly ASCII versioins to BaseLib.
It also changes all existing consumers to use the new APIs.

v2: Return UNSUPPORTED for cases when the string is malformatted.
    Update consumer code to use RETURN_STATUS receive the returned
    status instead of embedding the function call in RETURN_ERROR().

Ruiyu Ni (11):
  MdePkg: Define IPv4_ADDRESS and IPv6_ADDRESS in Base.h
  MdePkg/UefiDevicePathLib: Rename StrToGuid to avoid link failure
  SignedCapsulePkg/IniParsing: Rename StrToGuid to avoid link failure
  MdePkg/BaseLib: Add StrToGuid/StrHexToBytes/StrToIpv[4/6]Address
  MdePkg/BaseLib: Add AsciiStrToGuid/HexToBytes/ToIpv[4/6]Address
  MdePkg/UefiDevicePathLib: Use BaseLib string conversion services
  MdeModulePkg/CapsuleApp: Use StrToGuid in BaseLib
  SecurityPkg/SecureBootConfigDxe: Use StrToGuid in BaseLib
  ShellPkg/Debug1CommandLib: Use StrToGuid/StrHexToBytes in BaseLib
  SignedCapsulePkg/IniParsingLib: Use AsciiStrToGuid in BaseLib
  MdeModulePkg/NetLib: Use StrToIpv4/6Address in BaseLib

 MdeModulePkg/Application/CapsuleApp/AppSupport.c   |  140 +--
 MdeModulePkg/Application/CapsuleApp/CapsuleApp.c   |   27 +-
 MdeModulePkg/Include/Library/NetLib.h              |    5 +-
 MdeModulePkg/Library/DxeNetLib/DxeNetLib.c         |  382 +------
 MdePkg/Include/Base.h                              |   16 +-
 MdePkg/Include/Library/BaseLib.h                   |  445 ++++++++
 MdePkg/Include/Uefi/UefiBaseType.h                 |   10 +-
 MdePkg/Library/BaseLib/SafeString.c                | 1204 ++++++++++++++++++++
 .../Library/UefiDevicePathLib/DevicePathFromText.c |  213 +---
 .../SecureBootConfigDxe/SecureBootConfigImpl.c     |   12 +-
 .../SecureBootConfigDxe/SecureBootConfigImpl.h     |   22 +-
 .../SecureBootConfigDxe/SecureBootConfigMisc.c     |  141 +--
 .../Library/UefiShellDebug1CommandsLib/DmpStore.c  |    7 +-
 .../Library/UefiShellDebug1CommandsLib/SetVar.c    |   12 +-
 .../UefiShellDebug1CommandsLib.c                   |  119 +-
 .../UefiShellDebug1CommandsLib.h                   |   32 +-
 .../Library/IniParsingLib/IniParsingLib.c          |  148 +--
 17 files changed, 1740 insertions(+), 1195 deletions(-)

-- 
2.9.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 00/11] Add StrToGuid/HexToBytes/Ipv4/Ipv6 in BaseLib

Posted by Gao, Liming 115 weeks ago
The change in MdePkg are good to me. Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Ruiyu Ni
>Sent: Monday, February 27, 2017 3:22 PM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [PATCH v2 00/11] Add StrToGuid/HexToBytes/Ipv4/Ipv6 in
>BaseLib
>
>The patch set adds StrToGuid/StrHexToBytes/StrToIPv4Address
>/StrToIPv6Address and the accordingly ASCII versioins to BaseLib.
>It also changes all existing consumers to use the new APIs.
>
>v2: Return UNSUPPORTED for cases when the string is malformatted.
>    Update consumer code to use RETURN_STATUS receive the returned
>    status instead of embedding the function call in RETURN_ERROR().
>
>Ruiyu Ni (11):
>  MdePkg: Define IPv4_ADDRESS and IPv6_ADDRESS in Base.h
>  MdePkg/UefiDevicePathLib: Rename StrToGuid to avoid link failure
>  SignedCapsulePkg/IniParsing: Rename StrToGuid to avoid link failure
>  MdePkg/BaseLib: Add StrToGuid/StrHexToBytes/StrToIpv[4/6]Address
>  MdePkg/BaseLib: Add AsciiStrToGuid/HexToBytes/ToIpv[4/6]Address
>  MdePkg/UefiDevicePathLib: Use BaseLib string conversion services
>  MdeModulePkg/CapsuleApp: Use StrToGuid in BaseLib
>  SecurityPkg/SecureBootConfigDxe: Use StrToGuid in BaseLib
>  ShellPkg/Debug1CommandLib: Use StrToGuid/StrHexToBytes in BaseLib
>  SignedCapsulePkg/IniParsingLib: Use AsciiStrToGuid in BaseLib
>  MdeModulePkg/NetLib: Use StrToIpv4/6Address in BaseLib
>
> MdeModulePkg/Application/CapsuleApp/AppSupport.c   |  140 +--
> MdeModulePkg/Application/CapsuleApp/CapsuleApp.c   |   27 +-
> MdeModulePkg/Include/Library/NetLib.h              |    5 +-
> MdeModulePkg/Library/DxeNetLib/DxeNetLib.c         |  382 +------
> MdePkg/Include/Base.h                              |   16 +-
> MdePkg/Include/Library/BaseLib.h                   |  445 ++++++++
> MdePkg/Include/Uefi/UefiBaseType.h                 |   10 +-
> MdePkg/Library/BaseLib/SafeString.c                | 1204
>++++++++++++++++++++
> .../Library/UefiDevicePathLib/DevicePathFromText.c |  213 +---
> .../SecureBootConfigDxe/SecureBootConfigImpl.c     |   12 +-
> .../SecureBootConfigDxe/SecureBootConfigImpl.h     |   22 +-
> .../SecureBootConfigDxe/SecureBootConfigMisc.c     |  141 +--
> .../Library/UefiShellDebug1CommandsLib/DmpStore.c  |    7 +-
> .../Library/UefiShellDebug1CommandsLib/SetVar.c    |   12 +-
> .../UefiShellDebug1CommandsLib.c                   |  119 +-
> .../UefiShellDebug1CommandsLib.h                   |   32 +-
> .../Library/IniParsingLib/IniParsingLib.c          |  148 +--
> 17 files changed, 1740 insertions(+), 1195 deletions(-)
>
>--
>2.9.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel