[edk2] [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy

hegdenag posted 2 patches 131 weeks ago
Failed in applying to current master (apply log)
NetworkPkg/IScsiDxe/IScsiDriver.c |  8 +++++++-
NetworkPkg/IScsiDxe/IScsiDriver.h | 19 +++++++++++--------
NetworkPkg/NetworkPkg.dec         |  5 +++--
3 files changed, 21 insertions(+), 11 deletions(-)

[edk2] [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy

Posted by hegdenag 131 weeks ago
v2: Updated list of reviewers.

Today, iSCSI driver checks whether there are AIP instances
installed by iSCSI HBA adapter and if yes, the iSCSI driver
will return EFI_ABORTED in its driver binding Start. 
We can not guarantee the existence of AIP instances always during
iSCSI DBStart. Hence, we might end up doing a iScsiStart even if
the intent of the customer was to use only iSCSI on HBA.
The series of patch will define a new PCD value for the PCD 
PcdIScsiAIPNetworkBootPolicy, "Always use iSCSI HBA and ignore
UEFI iSCSI", update iScsiStart to check this PCD value and return
EFI_ABORT in this case even before checking for AIP instances.

hegdenag (2):
  NetworkPkg/iSCSIDxe: Update the condition for IScsiStart Abort
  NetworkPkg/NetworkPkg.dec: Update comments for the PCD

 NetworkPkg/IScsiDxe/IScsiDriver.c |  8 +++++++-
 NetworkPkg/IScsiDxe/IScsiDriver.h | 19 +++++++++++--------
 NetworkPkg/NetworkPkg.dec         |  5 +++--
 3 files changed, 21 insertions(+), 11 deletions(-)

-- 
2.8.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy

Posted by Wu, Jiaxin 131 weeks ago
Series Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>



> -----Original Message-----
> From: hegdenag [mailto:nagaraj-p.hegde@hpe.com]
> Sent: Monday, February 13, 2017 3:20 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Ye, Ting <ting.ye@intel.com>; Zhang,
> Lubo <lubo.zhang@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; sriram-
> s@hpe.com
> Subject: [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy
> 
> v2: Updated list of reviewers.
> 
> Today, iSCSI driver checks whether there are AIP instances
> installed by iSCSI HBA adapter and if yes, the iSCSI driver
> will return EFI_ABORTED in its driver binding Start.
> We can not guarantee the existence of AIP instances always during
> iSCSI DBStart. Hence, we might end up doing a iScsiStart even if
> the intent of the customer was to use only iSCSI on HBA.
> The series of patch will define a new PCD value for the PCD
> PcdIScsiAIPNetworkBootPolicy, "Always use iSCSI HBA and ignore
> UEFI iSCSI", update iScsiStart to check this PCD value and return
> EFI_ABORT in this case even before checking for AIP instances.
> 
> hegdenag (2):
>   NetworkPkg/iSCSIDxe: Update the condition for IScsiStart Abort
>   NetworkPkg/NetworkPkg.dec: Update comments for the PCD
> 
>  NetworkPkg/IScsiDxe/IScsiDriver.c |  8 +++++++-
>  NetworkPkg/IScsiDxe/IScsiDriver.h | 19 +++++++++++--------
>  NetworkPkg/NetworkPkg.dec         |  5 +++--
>  3 files changed, 21 insertions(+), 11 deletions(-)
> 
> --
> 2.8.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy

Posted by Subramanian, Sriram 131 weeks ago
Series Reviewed-by: Sriram Subramanian <sriram-s@hpe.com>

-----Original Message-----
From: Hegde, Nagaraj P 
Sent: Monday, February 13, 2017 12:50 PM
To: edk2-devel@lists.01.org
Cc: jiaxin.wu@intel.com; ting.ye@intel.com; lubo.zhang@intel.com; siyuan.fu@intel.com; Subramanian, Sriram <sriram-s@hpe.com>
Subject: [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy

v2: Updated list of reviewers.

Today, iSCSI driver checks whether there are AIP instances
installed by iSCSI HBA adapter and if yes, the iSCSI driver
will return EFI_ABORTED in its driver binding Start. 
We can not guarantee the existence of AIP instances always during
iSCSI DBStart. Hence, we might end up doing a iScsiStart even if
the intent of the customer was to use only iSCSI on HBA.
The series of patch will define a new PCD value for the PCD 
PcdIScsiAIPNetworkBootPolicy, "Always use iSCSI HBA and ignore
UEFI iSCSI", update iScsiStart to check this PCD value and return
EFI_ABORT in this case even before checking for AIP instances.

hegdenag (2):
  NetworkPkg/iSCSIDxe: Update the condition for IScsiStart Abort
  NetworkPkg/NetworkPkg.dec: Update comments for the PCD

 NetworkPkg/IScsiDxe/IScsiDriver.c |  8 +++++++-
 NetworkPkg/IScsiDxe/IScsiDriver.h | 19 +++++++++++--------
 NetworkPkg/NetworkPkg.dec         |  5 +++--
 3 files changed, 21 insertions(+), 11 deletions(-)

-- 
2.8.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy

Posted by Zhang, Lubo 131 weeks ago
Series Reviewed-by: Zhang Lubo <lubo.zhang@intel.com>

-----Original Message-----
From: hegdenag [mailto:nagaraj-p.hegde@hpe.com] 
Sent: Monday, February 13, 2017 3:20 PM
To: edk2-devel@lists.01.org
Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Ye, Ting <ting.ye@intel.com>; Zhang, Lubo <lubo.zhang@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; sriram-s@hpe.com
Subject: [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy

v2: Updated list of reviewers.

Today, iSCSI driver checks whether there are AIP instances installed by iSCSI HBA adapter and if yes, the iSCSI driver will return EFI_ABORTED in its driver binding Start. 
We can not guarantee the existence of AIP instances always during iSCSI DBStart. Hence, we might end up doing a iScsiStart even if the intent of the customer was to use only iSCSI on HBA.
The series of patch will define a new PCD value for the PCD PcdIScsiAIPNetworkBootPolicy, "Always use iSCSI HBA and ignore UEFI iSCSI", update iScsiStart to check this PCD value and return EFI_ABORT in this case even before checking for AIP instances.

hegdenag (2):
  NetworkPkg/iSCSIDxe: Update the condition for IScsiStart Abort
  NetworkPkg/NetworkPkg.dec: Update comments for the PCD

 NetworkPkg/IScsiDxe/IScsiDriver.c |  8 +++++++-  NetworkPkg/IScsiDxe/IScsiDriver.h | 19 +++++++++++--------
 NetworkPkg/NetworkPkg.dec         |  5 +++--
 3 files changed, 21 insertions(+), 11 deletions(-)

--
2.8.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy

Posted by Ye, Ting 131 weeks ago
Series Reviewed-by: Ye Ting <ting.ye@intel.com> 

-----Original Message-----
From: hegdenag [mailto:nagaraj-p.hegde@hpe.com] 
Sent: Monday, February 13, 2017 3:20 PM
To: edk2-devel@lists.01.org
Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Ye, Ting <ting.ye@intel.com>; Zhang, Lubo <lubo.zhang@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; sriram-s@hpe.com
Subject: [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy

v2: Updated list of reviewers.

Today, iSCSI driver checks whether there are AIP instances installed by iSCSI HBA adapter and if yes, the iSCSI driver will return EFI_ABORTED in its driver binding Start. 
We can not guarantee the existence of AIP instances always during iSCSI DBStart. Hence, we might end up doing a iScsiStart even if the intent of the customer was to use only iSCSI on HBA.
The series of patch will define a new PCD value for the PCD PcdIScsiAIPNetworkBootPolicy, "Always use iSCSI HBA and ignore UEFI iSCSI", update iScsiStart to check this PCD value and return EFI_ABORT in this case even before checking for AIP instances.

hegdenag (2):
  NetworkPkg/iSCSIDxe: Update the condition for IScsiStart Abort
  NetworkPkg/NetworkPkg.dec: Update comments for the PCD

 NetworkPkg/IScsiDxe/IScsiDriver.c |  8 +++++++-  NetworkPkg/IScsiDxe/IScsiDriver.h | 19 +++++++++++--------
 NetworkPkg/NetworkPkg.dec         |  5 +++--
 3 files changed, 21 insertions(+), 11 deletions(-)

--
2.8.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy

Posted by Fu, Siyuan 131 weeks ago
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>


-----Original Message-----
From: hegdenag [mailto:nagaraj-p.hegde@hpe.com] 
Sent: 2017年2月13日 15:20
To: edk2-devel@lists.01.org
Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Ye, Ting <ting.ye@intel.com>; Zhang, Lubo <lubo.zhang@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; sriram-s@hpe.com
Subject: [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy

v2: Updated list of reviewers.

Today, iSCSI driver checks whether there are AIP instances installed by iSCSI HBA adapter and if yes, the iSCSI driver will return EFI_ABORTED in its driver binding Start. 
We can not guarantee the existence of AIP instances always during iSCSI DBStart. Hence, we might end up doing a iScsiStart even if the intent of the customer was to use only iSCSI on HBA.
The series of patch will define a new PCD value for the PCD PcdIScsiAIPNetworkBootPolicy, "Always use iSCSI HBA and ignore UEFI iSCSI", update iScsiStart to check this PCD value and return EFI_ABORT in this case even before checking for AIP instances.

hegdenag (2):
  NetworkPkg/iSCSIDxe: Update the condition for IScsiStart Abort
  NetworkPkg/NetworkPkg.dec: Update comments for the PCD

 NetworkPkg/IScsiDxe/IScsiDriver.c |  8 +++++++-  NetworkPkg/IScsiDxe/IScsiDriver.h | 19 +++++++++++--------
 NetworkPkg/NetworkPkg.dec         |  5 +++--
 3 files changed, 21 insertions(+), 11 deletions(-)

--
2.8.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel