SynQuacer drivers test the ControllerHandle correctly

[edk2-devel] [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly

Posted by Masami Hiramatsu 3 years, 1 month ago

Hello,

Here are the patches to fix the SynQuacer related drivers to test
whether the ControllerHandle is managed by that driver correctly.
These bugs are found by edk2-test.

Thank you,

---

Kazuhiko Sakamoto (4):
      Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by this driver
      Silicon/SynQuacerI2cDxe: Test the ControllerHandle is managed by this driver
      Silicon/AtSha204a: Test the ControllerHandle is managed by this driver
      Silicon/ChaosKeyDxe: Test the ControllerHandle is managed by this driver


 Silicon/Atmel/AtSha204a/AtSha204aDriver.h          |    1 +
 Silicon/Atmel/AtSha204a/ComponentName.c            |   13 +++++++++++++
 Silicon/Atmel/AtSha204a/DriverBinding.c            |    1 -
 Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h      |    1 +
 Silicon/Openmoko/ChaosKeyDxe/ComponentName.c       |   13 +++++++++++++
 Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c       |    1 -
 .../Drivers/Net/NetsecDxe/ComponentName.c          |   13 +++++++++++++
 .../Drivers/Net/NetsecDxe/DriverBinding.c          |    1 -
 .../SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h    |    1 +
 .../Drivers/SynQuacerI2cDxe/ComponentName.c        |   13 +++++++++++++
 .../Drivers/SynQuacerI2cDxe/DriverBinding.c        |    2 +-
 .../Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h      |    1 +
 12 files changed, 57 insertions(+), 4 deletions(-)

--
Masami Hiramatsu <masami.hiramatsu@linaro.org>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81857): https://edk2.groups.io/g/devel/message/81857
Mute This Topic: https://groups.io/mt/86281577/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly

Posted by Leif Lindholm 3 years ago

Hi Masami,

Apologies for delay.

Thank you, this set looks good.
However, you cannot make legal statements on behalf of Sakamoto-san,
only yourself. If you are happy with that, I could drop their
Signed-off-by: statements before I push. They would retain the
authorship.

Best Regards,

Leif

On Wed, Oct 13, 2021 at 14:36:43 +0900, Masami Hiramatsu wrote:
> Hello,
> 
> Here are the patches to fix the SynQuacer related drivers to test
> whether the ControllerHandle is managed by that driver correctly.
> These bugs are found by edk2-test.
> 
> Thank you,
> 
> ---
> 
> Kazuhiko Sakamoto (4):
>       Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by this driver
>       Silicon/SynQuacerI2cDxe: Test the ControllerHandle is managed by this driver
>       Silicon/AtSha204a: Test the ControllerHandle is managed by this driver
>       Silicon/ChaosKeyDxe: Test the ControllerHandle is managed by this driver
> 
> 
>  Silicon/Atmel/AtSha204a/AtSha204aDriver.h          |    1 +
>  Silicon/Atmel/AtSha204a/ComponentName.c            |   13 +++++++++++++
>  Silicon/Atmel/AtSha204a/DriverBinding.c            |    1 -
>  Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h      |    1 +
>  Silicon/Openmoko/ChaosKeyDxe/ComponentName.c       |   13 +++++++++++++
>  Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c       |    1 -
>  .../Drivers/Net/NetsecDxe/ComponentName.c          |   13 +++++++++++++
>  .../Drivers/Net/NetsecDxe/DriverBinding.c          |    1 -
>  .../SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h    |    1 +
>  .../Drivers/SynQuacerI2cDxe/ComponentName.c        |   13 +++++++++++++
>  .../Drivers/SynQuacerI2cDxe/DriverBinding.c        |    2 +-
>  .../Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h      |    1 +
>  12 files changed, 57 insertions(+), 4 deletions(-)
> 
> --
> Masami Hiramatsu <masami.hiramatsu@linaro.org>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82746): https://edk2.groups.io/g/devel/message/82746
Mute This Topic: https://groups.io/mt/86281577/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly

Posted by Samer El-Haj-Mahmoud 3 years ago

For situations like this, maybe " Co-authored-by" can be used?

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif
> Lindholm via groups.io
> Sent: Wednesday, October 27, 2021 7:22 AM
> To: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; devel@edk2.groups.io;
> Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>
> Subject: Re: [edk2-devel] [PATCH 0/4] SynQuacer drivers test the
> ControllerHandle correctly
>
> Hi Masami,
>
> Apologies for delay.
>
> Thank you, this set looks good.
> However, you cannot make legal statements on behalf of Sakamoto-san,
> only yourself. If you are happy with that, I could drop their
> Signed-off-by: statements before I push. They would retain the
> authorship.
>
> Best Regards,
>
> Leif
>
> On Wed, Oct 13, 2021 at 14:36:43 +0900, Masami Hiramatsu wrote:
> > Hello,
> >
> > Here are the patches to fix the SynQuacer related drivers to test
> > whether the ControllerHandle is managed by that driver correctly.
> > These bugs are found by edk2-test.
> >
> > Thank you,
> >
> > ---
> >
> > Kazuhiko Sakamoto (4):
> >       Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by
> this driver
> >       Silicon/SynQuacerI2cDxe: Test the ControllerHandle is managed by this
> driver
> >       Silicon/AtSha204a: Test the ControllerHandle is managed by this driver
> >       Silicon/ChaosKeyDxe: Test the ControllerHandle is managed by this
> driver
> >
> >
> >  Silicon/Atmel/AtSha204a/AtSha204aDriver.h          |    1 +
> >  Silicon/Atmel/AtSha204a/ComponentName.c            |   13 +++++++++++++
> >  Silicon/Atmel/AtSha204a/DriverBinding.c            |    1 -
> >  Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h      |    1 +
> >  Silicon/Openmoko/ChaosKeyDxe/ComponentName.c       |   13
> +++++++++++++
> >  Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c       |    1 -
> >  .../Drivers/Net/NetsecDxe/ComponentName.c          |   13 +++++++++++++
> >  .../Drivers/Net/NetsecDxe/DriverBinding.c          |    1 -
> >  .../SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h    |    1 +
> >  .../Drivers/SynQuacerI2cDxe/ComponentName.c        |   13
> +++++++++++++
> >  .../Drivers/SynQuacerI2cDxe/DriverBinding.c        |    2 +-
> >  .../Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h      |    1 +
> >  12 files changed, 57 insertions(+), 4 deletions(-)
> >
> > --
> > Masami Hiramatsu <masami.hiramatsu@linaro.org>
>
>
> 
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82752): https://edk2.groups.io/g/devel/message/82752
Mute This Topic: https://groups.io/mt/86281577/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly

Posted by Leif Lindholm 3 years ago

There is a case for that tag, but it is not this one.

I'm not asking Masami to drop his S-o-b, and Sakamoto-san maintains
their authorship (via the From: tag) - so both will be acknowledged in
the end result.

On Wed, Oct 27, 2021 at 13:55:56 +0000, Samer El-Haj-Mahmoud wrote:
> For situations like this, maybe " Co-authored-by" can be used?
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif
> > Lindholm via groups.io
> > Sent: Wednesday, October 27, 2021 7:22 AM
> > To: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> > Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; devel@edk2.groups.io;
> > Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>
> > Subject: Re: [edk2-devel] [PATCH 0/4] SynQuacer drivers test the
> > ControllerHandle correctly
> >
> > Hi Masami,
> >
> > Apologies for delay.
> >
> > Thank you, this set looks good.
> > However, you cannot make legal statements on behalf of Sakamoto-san,
> > only yourself. If you are happy with that, I could drop their
> > Signed-off-by: statements before I push. They would retain the
> > authorship.
> >
> > Best Regards,
> >
> > Leif
> >
> > On Wed, Oct 13, 2021 at 14:36:43 +0900, Masami Hiramatsu wrote:
> > > Hello,
> > >
> > > Here are the patches to fix the SynQuacer related drivers to test
> > > whether the ControllerHandle is managed by that driver correctly.
> > > These bugs are found by edk2-test.
> > >
> > > Thank you,
> > >
> > > ---
> > >
> > > Kazuhiko Sakamoto (4):
> > >       Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by
> > this driver
> > >       Silicon/SynQuacerI2cDxe: Test the ControllerHandle is managed by this
> > driver
> > >       Silicon/AtSha204a: Test the ControllerHandle is managed by this driver
> > >       Silicon/ChaosKeyDxe: Test the ControllerHandle is managed by this
> > driver
> > >
> > >
> > >  Silicon/Atmel/AtSha204a/AtSha204aDriver.h          |    1 +
> > >  Silicon/Atmel/AtSha204a/ComponentName.c            |   13 +++++++++++++
> > >  Silicon/Atmel/AtSha204a/DriverBinding.c            |    1 -
> > >  Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h      |    1 +
> > >  Silicon/Openmoko/ChaosKeyDxe/ComponentName.c       |   13
> > +++++++++++++
> > >  Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c       |    1 -
> > >  .../Drivers/Net/NetsecDxe/ComponentName.c          |   13 +++++++++++++
> > >  .../Drivers/Net/NetsecDxe/DriverBinding.c          |    1 -
> > >  .../SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h    |    1 +
> > >  .../Drivers/SynQuacerI2cDxe/ComponentName.c        |   13
> > +++++++++++++
> > >  .../Drivers/SynQuacerI2cDxe/DriverBinding.c        |    2 +-
> > >  .../Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h      |    1 +
> > >  12 files changed, 57 insertions(+), 4 deletions(-)
> > >
> > > --
> > > Masami Hiramatsu <masami.hiramatsu@linaro.org>
> >
> >
> > 
> >
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82754): https://edk2.groups.io/g/devel/message/82754
Mute This Topic: https://groups.io/mt/86281577/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly

Posted by Masami Hiramatsu 3 years ago

Hi Leif,

Thank you for your reply!

2021年10月27日(水) 20:21 Leif Lindholm <leif@nuviainc.com>:
>
> Hi Masami,
>
> Apologies for delay.
>
> Thank you, this set looks good.
> However, you cannot make legal statements on behalf of Sakamoto-san,
> only yourself. If you are happy with that, I could drop their
> Signed-off-by: statements before I push. They would retain the
> authorship.

Actually I got this patch from Sakamoto-san with the Signed-off-by, so I sent
it via my own internal tree. OK, next time I will ask Sakamoto-san to send it
by himself, or just report to me and I write the patch.

Thank you,

>
> Best Regards,
>
> Leif
>
> On Wed, Oct 13, 2021 at 14:36:43 +0900, Masami Hiramatsu wrote:
> > Hello,
> >
> > Here are the patches to fix the SynQuacer related drivers to test
> > whether the ControllerHandle is managed by that driver correctly.
> > These bugs are found by edk2-test.
> >
> > Thank you,
> >
> > ---
> >
> > Kazuhiko Sakamoto (4):
> >       Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by this driver
> >       Silicon/SynQuacerI2cDxe: Test the ControllerHandle is managed by this driver
> >       Silicon/AtSha204a: Test the ControllerHandle is managed by this driver
> >       Silicon/ChaosKeyDxe: Test the ControllerHandle is managed by this driver
> >
> >
> >  Silicon/Atmel/AtSha204a/AtSha204aDriver.h          |    1 +
> >  Silicon/Atmel/AtSha204a/ComponentName.c            |   13 +++++++++++++
> >  Silicon/Atmel/AtSha204a/DriverBinding.c            |    1 -
> >  Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h      |    1 +
> >  Silicon/Openmoko/ChaosKeyDxe/ComponentName.c       |   13 +++++++++++++
> >  Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c       |    1 -
> >  .../Drivers/Net/NetsecDxe/ComponentName.c          |   13 +++++++++++++
> >  .../Drivers/Net/NetsecDxe/DriverBinding.c          |    1 -
> >  .../SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h    |    1 +
> >  .../Drivers/SynQuacerI2cDxe/ComponentName.c        |   13 +++++++++++++
> >  .../Drivers/SynQuacerI2cDxe/DriverBinding.c        |    2 +-
> >  .../Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h      |    1 +
> >  12 files changed, 57 insertions(+), 4 deletions(-)
> >
> > --
> > Masami Hiramatsu <masami.hiramatsu@linaro.org>



-- 
Masami Hiramatsu


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82763): https://edk2.groups.io/g/devel/message/82763
Mute This Topic: https://groups.io/mt/86281577/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly

Posted by Leif Lindholm 3 years ago

On Thu, Oct 28, 2021 at 09:53:34 +0900, Masami Hiramatsu wrote:
> Hi Leif,
> 
> Thank you for your reply!
> 
> 2021年10月27日(水) 20:21 Leif Lindholm <leif@nuviainc.com>:
> >
> > Hi Masami,
> >
> > Apologies for delay.
> >
> > Thank you, this set looks good.
> > However, you cannot make legal statements on behalf of Sakamoto-san,
> > only yourself. If you are happy with that, I could drop their
> > Signed-off-by: statements before I push. They would retain the
> > authorship.
> 
> Actually I got this patch from Sakamoto-san with the Signed-off-by, so I sent
> it via my own internal tree. OK, next time I will ask Sakamoto-san to send it
> by himself, or just report to me and I write the patch.
> 
> Thank you,

For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as 06489b36ab34..a4f52afa363c.

(I also dropped the Contributed-under: tags - we stopped using those
after the license transition to bsd+patent.)

Best Regards,

Leif

> >
> > Best Regards,
> >
> > Leif
> >
> > On Wed, Oct 13, 2021 at 14:36:43 +0900, Masami Hiramatsu wrote:
> > > Hello,
> > >
> > > Here are the patches to fix the SynQuacer related drivers to test
> > > whether the ControllerHandle is managed by that driver correctly.
> > > These bugs are found by edk2-test.
> > >
> > > Thank you,
> > >
> > > ---
> > >
> > > Kazuhiko Sakamoto (4):
> > >       Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by this driver
> > >       Silicon/SynQuacerI2cDxe: Test the ControllerHandle is managed by this driver
> > >       Silicon/AtSha204a: Test the ControllerHandle is managed by this driver
> > >       Silicon/ChaosKeyDxe: Test the ControllerHandle is managed by this driver
> > >
> > >
> > >  Silicon/Atmel/AtSha204a/AtSha204aDriver.h          |    1 +
> > >  Silicon/Atmel/AtSha204a/ComponentName.c            |   13 +++++++++++++
> > >  Silicon/Atmel/AtSha204a/DriverBinding.c            |    1 -
> > >  Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h      |    1 +
> > >  Silicon/Openmoko/ChaosKeyDxe/ComponentName.c       |   13 +++++++++++++
> > >  Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c       |    1 -
> > >  .../Drivers/Net/NetsecDxe/ComponentName.c          |   13 +++++++++++++
> > >  .../Drivers/Net/NetsecDxe/DriverBinding.c          |    1 -
> > >  .../SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h    |    1 +
> > >  .../Drivers/SynQuacerI2cDxe/ComponentName.c        |   13 +++++++++++++
> > >  .../Drivers/SynQuacerI2cDxe/DriverBinding.c        |    2 +-
> > >  .../Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h      |    1 +
> > >  12 files changed, 57 insertions(+), 4 deletions(-)
> > >
> > > --
> > > Masami Hiramatsu <masami.hiramatsu@linaro.org>
> 
> 
> 
> -- 
> Masami Hiramatsu


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83005): https://edk2.groups.io/g/devel/message/83005
Mute This Topic: https://groups.io/mt/86281577/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-