Fix some issues on SynQuacer

[edk2-devel] [edk2-platforms PATCH v2 0/2] Fix some issues on SynQuacer

Posted by Masami Hiramatsu 3 years, 4 months ago

Hello,

Here is the 2nd version of the patches to fix 2 issues on SynQuacer platform support.
I and Sakamoto-san found these issues in edk2-test testcases on SynQuacer
DeveloperBox platfrom.

Previous version are here;

https://edk2.groups.io/g/devel/message/77085
https://edk2.groups.io/g/devel/message/77086

In this version, I grouped these 2 patches and update patch changelog.

[1/2] Fixes OpteeRng driver to check invalid parameter correctly.
      Without this fix, edk2-test BBTestGetRNGConformanceTestCheckpoint1
      reports an error.

[2/2] Fixes Pcf8563RealTimeClockLib to clear unused Nanosecond field.
      Without this fix, edk2-test BBTestGetTimeInterfaceTest and
      BBTestSetTimeInterfaceTest failed. Moreover, 'date' and 'time'
      commands on UEFI shell can not set the time.

Thank you,

---

Masami Hiramatsu (2):
      Silicon/SynQuacer/OpteeRngDxe: Fix invalid parameter check
      Silicon/NXP/Pcf8563RealTimeClockLib: Clear Nanosecond field in GetTime


 .../Pcf8563RealTimeClockLib.c                      |    2 ++
 .../SynQuacer/Drivers/OpteeRngDxe/OpteeRng.c       |    5 ++---
 2 files changed, 4 insertions(+), 3 deletions(-)

--
Masami Hiramatsu <masami.hiramatsu@linaro.org>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78166): https://edk2.groups.io/g/devel/message/78166
Mute This Topic: https://groups.io/mt/84454408/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH v2 0/2] Fix some issues on SynQuacer

Posted by Ard Biesheuvel 3 years, 4 months ago

On Mon, 26 Jul 2021 at 10:28, Masami Hiramatsu
<masami.hiramatsu@linaro.org> wrote:
>
> Hello,
>
> Here is the 2nd version of the patches to fix 2 issues on SynQuacer platform support.
> I and Sakamoto-san found these issues in edk2-test testcases on SynQuacer
> DeveloperBox platfrom.
>
> Previous version are here;
>
> https://edk2.groups.io/g/devel/message/77085
> https://edk2.groups.io/g/devel/message/77086
>
> In this version, I grouped these 2 patches and update patch changelog.
>
> [1/2] Fixes OpteeRng driver to check invalid parameter correctly.
>       Without this fix, edk2-test BBTestGetRNGConformanceTestCheckpoint1
>       reports an error.
>
> [2/2] Fixes Pcf8563RealTimeClockLib to clear unused Nanosecond field.
>       Without this fix, edk2-test BBTestGetTimeInterfaceTest and
>       BBTestSetTimeInterfaceTest failed. Moreover, 'date' and 'time'
>       commands on UEFI shell can not set the time.
>
> Thank you,
>
> ---
>
> Masami Hiramatsu (2):
>       Silicon/SynQuacer/OpteeRngDxe: Fix invalid parameter check
>       Silicon/NXP/Pcf8563RealTimeClockLib: Clear Nanosecond field in GetTime
>

Thank you Masami.

Pushed as 194269223294..c131fed73d37



>
>  .../Pcf8563RealTimeClockLib.c                      |    2 ++
>  .../SynQuacer/Drivers/OpteeRngDxe/OpteeRng.c       |    5 ++---
>  2 files changed, 4 insertions(+), 3 deletions(-)
>
> --
> Masami Hiramatsu <masami.hiramatsu@linaro.org>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78279): https://edk2.groups.io/g/devel/message/78279
Mute This Topic: https://groups.io/mt/84454408/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH v2 0/2] Fix some issues on SynQuacer

Posted by Masami Hiramatsu 3 years, 4 months ago

2021年7月28日(水) 19:44 Ard Biesheuvel <ardb@kernel.org>:
>
> On Mon, 26 Jul 2021 at 10:28, Masami Hiramatsu
> <masami.hiramatsu@linaro.org> wrote:
> >
> > Hello,
> >
> > Here is the 2nd version of the patches to fix 2 issues on SynQuacer platform support.
> > I and Sakamoto-san found these issues in edk2-test testcases on SynQuacer
> > DeveloperBox platfrom.
> >
> > Previous version are here;
> >
> > https://edk2.groups.io/g/devel/message/77085
> > https://edk2.groups.io/g/devel/message/77086
> >
> > In this version, I grouped these 2 patches and update patch changelog.
> >
> > [1/2] Fixes OpteeRng driver to check invalid parameter correctly.
> >       Without this fix, edk2-test BBTestGetRNGConformanceTestCheckpoint1
> >       reports an error.
> >
> > [2/2] Fixes Pcf8563RealTimeClockLib to clear unused Nanosecond field.
> >       Without this fix, edk2-test BBTestGetTimeInterfaceTest and
> >       BBTestSetTimeInterfaceTest failed. Moreover, 'date' and 'time'
> >       commands on UEFI shell can not set the time.
> >
> > Thank you,
> >
> > ---
> >
> > Masami Hiramatsu (2):
> >       Silicon/SynQuacer/OpteeRngDxe: Fix invalid parameter check
> >       Silicon/NXP/Pcf8563RealTimeClockLib: Clear Nanosecond field in GetTime
> >
>
> Thank you Masami.
>
> Pushed as 194269223294..c131fed73d37

Thank you Ard!

-- 
Masami Hiramatsu


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78280): https://edk2.groups.io/g/devel/message/78280
Mute This Topic: https://groups.io/mt/84454408/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-