ArmPkg/ArmDisassemblerLib: fix incorrect comparison

[edk2-devel] [PATCH EDK2 v1 0/1] ArmPkg/ArmDisassemblerLib: fix incorrect comparison

wenyi,xie via groups.io posted 1 patch 3 years, 4 months ago

Download series mbox

Failed in applying to current master (apply log)

ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[edk2-devel] [PATCH EDK2 v1 0/1] ArmPkg/ArmDisassemblerLib: fix incorrect comparison

Posted by wenyi,xie via groups.io 3 years, 4 months ago

Main Changes :
As shift = (OpCode >> 5) & 0x3, shift will never be larger than 0x3,
so the comparison between shift and 0x12 will always be false. The right
shift type of ASR is 0x2, so 0x12 should to changed to 0x2.

Wenyi Xie (1):
  ArmPkg/ArmDisassemblerLib: fix incorrect comparison

 ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.20.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68457): https://edk2.groups.io/g/devel/message/68457
Mute This Topic: https://groups.io/mt/78802482/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-