1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount

Vijayenthiran Subramaniam posted 1 patch 3 years, 6 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
1 file changed, 2 insertions(+)
[edk2-devel] [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount
Posted by Vijayenthiran Subramaniam 3 years, 6 months ago 
Commit e8fe2026dd79 (“Platform/ARM/SgiPkg: Use chip count constant on
rdn1edgex2 platform”) used the PcdChipCount constant but did not declare
its use in the ACPI table module. Fix this by listing it in the list of
PCDs to be looked up.

Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
---

Resending PATCH-v3 [1] with Reviewed-bys added.

[1]: https://edk2.groups.io/g/devel/topic/77339902

Changes since v2:
  - Rebased to latest master and repost.

Changes since v1:
  - Add commit id in commit message for which this patch fixes the build
    failure.

 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
index 974d9db543..d44f02ab0c 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
@@ -45,6 +45,8 @@
   gArmSgiTokenSpaceGuid.PcdDramBlock2Base
   gArmSgiTokenSpaceGuid.PcdDramBlock2Size
 
+  gArmSgiTokenSpaceGuid.PcdChipCount
+
   gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
   gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
   gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65927): https://edk2.groups.io/g/devel/message/65927
Mute This Topic: https://groups.io/mt/77340686/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount
Posted by Vijayenthiran Subramaniam 3 years, 6 months ago 
Hi all,

On Tue, Oct 6, 2020 at 1:42 PM Vijayenthiran Subramaniam
<vijayenthiran.subramaniam@arm.com> wrote:
>
> Commit e8fe2026dd79 (“Platform/ARM/SgiPkg: Use chip count constant on
> rdn1edgex2 platform”) used the PcdChipCount constant but did not declare
> its use in the ACPI table module. Fix this by listing it in the list of
> PCDs to be looked up.
>
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>
> Resending PATCH-v3 [1] with Reviewed-bys added.
>
> [1]: https://edk2.groups.io/g/devel/topic/77339902
>
> Changes since v2:
>   - Rebased to latest master and repost.
>
> Changes since v1:
>   - Add commit id in commit message for which this patch fixes the build
>     failure.
>
>  Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> index 974d9db543..d44f02ab0c 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> @@ -45,6 +45,8 @@
>    gArmSgiTokenSpaceGuid.PcdDramBlock2Base
>    gArmSgiTokenSpaceGuid.PcdDramBlock2Size
>
> +  gArmSgiTokenSpaceGuid.PcdChipCount
> +
>    gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
>    gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
>    gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> --
> 2.17.1

A kindly reminder for this patch.

Regards,
Vijayenthiran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66210): https://edk2.groups.io/g/devel/message/66210
Mute This Topic: https://groups.io/mt/77340686/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount
Posted by Vijayenthiran Subramaniam 3 years, 5 months ago 
Hi all,

On Wed, Oct 14, 2020 at 7:33 AM Vijayenthiran Subramanian
<vijayenthiran.subramaniam@arm.com> wrote:
>
> Hi all,
>
> On Tue, Oct 6, 2020 at 1:42 PM Vijayenthiran Subramaniam
> <vijayenthiran.subramaniam@arm.com> wrote:
> >
> > Commit e8fe2026dd79 (“Platform/ARM/SgiPkg: Use chip count constant on
> > rdn1edgex2 platform”) used the PcdChipCount constant but did not declare
> > its use in the ACPI table module. Fix this by listing it in the list of
> > PCDs to be looked up.
> >
> > Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> > Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
> > Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> > ---
> >
> > Resending PATCH-v3 [1] with Reviewed-bys added.
> >
> > [1]: https://edk2.groups.io/g/devel/topic/77339902
> >
> > Changes since v2:
> >   - Rebased to latest master and repost.
> >
> > Changes since v1:
> >   - Add commit id in commit message for which this patch fixes the build
> >     failure.
> >
> >  Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > index 974d9db543..d44f02ab0c 100644
> > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > @@ -45,6 +45,8 @@
> >    gArmSgiTokenSpaceGuid.PcdDramBlock2Base
> >    gArmSgiTokenSpaceGuid.PcdDramBlock2Size
> >
> > +  gArmSgiTokenSpaceGuid.PcdChipCount
> > +
> >    gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
> >    gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
> >    gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> > --
> > 2.17.1
>
> A kindly reminder for this patch.
>
> Regards,
> Vijayenthiran

A gentle reminder to take a look at this patch.

Regards,
Vijayenthiran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67378): https://edk2.groups.io/g/devel/message/67378
Mute This Topic: https://groups.io/mt/77340686/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount
Posted by Ard Biesheuvel 3 years, 5 months ago 
On 11/12/20 9:09 AM, Vijayenthiran Subramanian wrote:
> Hi all,
> 
> On Wed, Oct 14, 2020 at 7:33 AM Vijayenthiran Subramanian
> <vijayenthiran.subramaniam@arm.com> wrote:
>>
>> Hi all,
>>
>> On Tue, Oct 6, 2020 at 1:42 PM Vijayenthiran Subramaniam
>> <vijayenthiran.subramaniam@arm.com> wrote:
>>>
>>> Commit e8fe2026dd79 (“Platform/ARM/SgiPkg: Use chip count constant on
>>> rdn1edgex2 platform”) used the PcdChipCount constant but did not declare
>>> its use in the ACPI table module. Fix this by listing it in the list of
>>> PCDs to be looked up.
>>>
>>> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
>>> Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
>>> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>>> ---
>>>
>>> Resending PATCH-v3 [1] with Reviewed-bys added.
>>>
>>> [1]: https://edk2.groups.io/g/devel/topic/77339902
>>>
>>> Changes since v2:
>>>    - Rebased to latest master and repost.
>>>
>>> Changes since v1:
>>>    - Add commit id in commit message for which this patch fixes the build
>>>      failure.
>>>
>>>   Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
>>> index 974d9db543..d44f02ab0c 100644
>>> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
>>> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
>>> @@ -45,6 +45,8 @@
>>>     gArmSgiTokenSpaceGuid.PcdDramBlock2Base
>>>     gArmSgiTokenSpaceGuid.PcdDramBlock2Size
>>>
>>> +  gArmSgiTokenSpaceGuid.PcdChipCount
>>> +
>>>     gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
>>>     gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
>>>     gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
>>> --
>>> 2.17.1
>>
>> A kindly reminder for this patch.
>>
>> Regards,
>> Vijayenthiran
> 
> A gentle reminder to take a look at this patch.
> 

My apologies

Pushed as 1a9cbd7fe9cc..867efd012b2f



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67382): https://edk2.groups.io/g/devel/message/67382
Mute This Topic: https://groups.io/mt/77340686/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount
Posted by Vijayenthiran Subramaniam 3 years, 5 months ago 
On Thu, Nov 12, 2020 at 9:12 AM Ard Biesheuvel <ard.biesheuvel@arm.com> wrote:
>
> On 11/12/20 9:09 AM, Vijayenthiran Subramanian wrote:
> > Hi all,
> >
> > On Wed, Oct 14, 2020 at 7:33 AM Vijayenthiran Subramanian
> > <vijayenthiran.subramaniam@arm.com> wrote:
> >>
> >> Hi all,
> >>
> >> On Tue, Oct 6, 2020 at 1:42 PM Vijayenthiran Subramaniam
> >> <vijayenthiran.subramaniam@arm.com> wrote:
> >>>
> >>> Commit e8fe2026dd79 (“Platform/ARM/SgiPkg: Use chip count constant on
> >>> rdn1edgex2 platform”) used the PcdChipCount constant but did not declare
> >>> its use in the ACPI table module. Fix this by listing it in the list of
> >>> PCDs to be looked up.
> >>>
> >>> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> >>> Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
> >>> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> >>> ---
> >>>
> >>> Resending PATCH-v3 [1] with Reviewed-bys added.
> >>>
> >>> [1]: https://edk2.groups.io/g/devel/topic/77339902
> >>>
> >>> Changes since v2:
> >>>    - Rebased to latest master and repost.
> >>>
> >>> Changes since v1:
> >>>    - Add commit id in commit message for which this patch fixes the build
> >>>      failure.
> >>>
> >>>   Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
> >>>   1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> >>> index 974d9db543..d44f02ab0c 100644
> >>> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> >>> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> >>> @@ -45,6 +45,8 @@
> >>>     gArmSgiTokenSpaceGuid.PcdDramBlock2Base
> >>>     gArmSgiTokenSpaceGuid.PcdDramBlock2Size
> >>>
> >>> +  gArmSgiTokenSpaceGuid.PcdChipCount
> >>> +
> >>>     gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
> >>>     gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
> >>>     gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> >>> --
> >>> 2.17.1
> >>
> >> A kindly reminder for this patch.
> >>
> >> Regards,
> >> Vijayenthiran
> >
> > A gentle reminder to take a look at this patch.
> >
>
> My apologies
>
> Pushed as 1a9cbd7fe9cc..867efd012b2f

Thanks Ard.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67394): https://edk2.groups.io/g/devel/message/67394
Mute This Topic: https://groups.io/mt/77340686/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.