1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2

Vijayenthiran Subramaniam posted 1 patch 3 years, 8 months ago
Failed in applying to current master (apply log)
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
1 file changed, 2 insertions(+)
[edk2-devel] [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2
Posted by Vijayenthiran Subramaniam 3 years, 8 months ago 
PcdChipCount constant is used to define the maximum number chips
included in the multi-chip configuration. Add this constant to the
RDN1EdgeX2 ACPI tables build information (INF) file to allow this
constant to be used in the RDN1EdgeX2 ACPI tables.

Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
---
 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
index 974d9db543..d44f02ab0c 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
@@ -45,6 +45,8 @@
   gArmSgiTokenSpaceGuid.PcdDramBlock2Base
   gArmSgiTokenSpaceGuid.PcdDramBlock2Size
 
+  gArmSgiTokenSpaceGuid.PcdChipCount
+
   gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
   gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
   gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64443): https://edk2.groups.io/g/devel/message/64443
Mute This Topic: https://groups.io/mt/76288010/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2
Posted by Leif Lindholm 3 years, 8 months ago 
On Wed, Aug 19, 2020 at 20:23:43 +0530, Vijayenthiran Subramaniam wrote:
> PcdChipCount constant is used to define the maximum number chips
> included in the multi-chip configuration. Add this constant to the
> RDN1EdgeX2 ACPI tables build information (INF) file to allow this
> constant to be used in the RDN1EdgeX2 ACPI tables.

This patch fixes a build failure, the commit message should say so,
and refer to which commit it fixes.

Also, this fixes a build failure introduced 3.5 months ago, and no one
noticed until now. Are we sure this platform belongs upstream?

/
    Leif

> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> ---
>  Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> index 974d9db543..d44f02ab0c 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> @@ -45,6 +45,8 @@
>    gArmSgiTokenSpaceGuid.PcdDramBlock2Base
>    gArmSgiTokenSpaceGuid.PcdDramBlock2Size
>  
> +  gArmSgiTokenSpaceGuid.PcdChipCount
> +
>    gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
>    gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
>    gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> -- 
> 2.17.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64490): https://edk2.groups.io/g/devel/message/64490
Mute This Topic: https://groups.io/mt/76288010/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2
Posted by Vijayenthiran Subramaniam 3 years, 8 months ago 
Hi Leif,

On Thu, Aug 20, 2020 at 10:00 AM Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Wed, Aug 19, 2020 at 20:23:43 +0530, Vijayenthiran Subramaniam wrote:
> > PcdChipCount constant is used to define the maximum number chips
> > included in the multi-chip configuration. Add this constant to the
> > RDN1EdgeX2 ACPI tables build information (INF) file to allow this
> > constant to be used in the RDN1EdgeX2 ACPI tables.
>
> This patch fixes a build failure, the commit message should say so,
> and refer to which commit it fixes.
>

Okay, I will do that.

> Also, this fixes a build failure introduced 3.5 months ago, and no one
> noticed until now. Are we sure this platform belongs upstream?
>

This was noticed after the patch was merged upstream. This probably
slipped through during the patch rework and rebase. This was fixed
outside of the upstream code but missed to get this merged upstream.

Regards,
Vijayenthiran

> /
>     Leif
>
> > Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> > ---
> >  Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > index 974d9db543..d44f02ab0c 100644
> > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > @@ -45,6 +45,8 @@
> >    gArmSgiTokenSpaceGuid.PcdDramBlock2Base
> >    gArmSgiTokenSpaceGuid.PcdDramBlock2Size
> >
> > +  gArmSgiTokenSpaceGuid.PcdChipCount
> > +
> >    gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
> >    gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
> >    gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> > --
> > 2.17.1
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64544): https://edk2.groups.io/g/devel/message/64544
Mute This Topic: https://groups.io/mt/76288010/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2
Posted by Vijay S 3 years, 8 months ago 
Hi Leif

On Thu, Aug 20, 2020 at 10:00 AM Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Wed, Aug 19, 2020 at 20:23:43 +0530, Vijayenthiran Subramaniam wrote:
> > PcdChipCount constant is used to define the maximum number chips
> > included in the multi-chip configuration. Add this constant to the
> > RDN1EdgeX2 ACPI tables build information (INF) file to allow this
> > constant to be used in the RDN1EdgeX2 ACPI tables.
>
> This patch fixes a build failure, the commit message should say so,
> and refer to which commit it fixes.
>

Okay, I will do that.

> Also, this fixes a build failure introduced 3.5 months ago, and no one
> noticed until now. Are we sure this platform belongs upstream?

This was noticed after the patch was merged upstream. This probably
slipped through during the patch rework and rebase. This was fixed
outside of the upstream code but missed to get this merged upstream.

Regards,
Vijayenthiran

>
> /
>     Leif
>
> > Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> > ---
> >  Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > index 974d9db543..d44f02ab0c 100644
> > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > @@ -45,6 +45,8 @@
> >    gArmSgiTokenSpaceGuid.PcdDramBlock2Base
> >    gArmSgiTokenSpaceGuid.PcdDramBlock2Size
> >
> > +  gArmSgiTokenSpaceGuid.PcdChipCount
> > +
> >    gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
> >    gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
> >    gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> > --
> > 2.17.1
> >
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64543): https://edk2.groups.io/g/devel/message/64543
Mute This Topic: https://groups.io/mt/76288010/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2
Posted by Ard Biesheuvel 3 years, 8 months ago 
(+ Sami)

On 8/19/20 4:53 PM, Vijayenthiran Subramaniam wrote:
> PcdChipCount constant is used to define the maximum number chips
> included in the multi-chip configuration. Add this constant to the
> RDN1EdgeX2 ACPI tables build information (INF) file to allow this
> constant to be used in the RDN1EdgeX2 ACPI tables.
> 
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> ---
>   Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> index 974d9db543..d44f02ab0c 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> @@ -45,6 +45,8 @@
>     gArmSgiTokenSpaceGuid.PcdDramBlock2Base
>     gArmSgiTokenSpaceGuid.PcdDramBlock2Size
>   
> +  gArmSgiTokenSpaceGuid.PcdChipCount
> +
>     gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
>     gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
>     gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64488): https://edk2.groups.io/g/devel/message/64488
Mute This Topic: https://groups.io/mt/76288010/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2
Posted by Sami Mujawar 3 years, 8 months ago 
It might be worth mentioning that this patch fixes the build issue with commit https://github.com/tianocore/edk2-platforms/commit/e8fe2026dd7936c8c1661ec9289766f3b0c6d382

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

-----Original Message-----
From: Ard Biesheuvel <ard.biesheuvel@arm.com>
Sent: 20 August 2020 09:10 AM
To: Vijayenthiran Subramaniam <Vijayenthiran.Subramaniam@arm.com>; devel@edk2.groups.io; leif@nuviainc.com
Cc: Thomas Abraham <thomas.abraham@arm.com>; Aditya Angadi <Aditya.Angadi@arm.com>; Richard Storer <Richard.Storer@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>
Subject: Re: [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2

(+ Sami)

On 8/19/20 4:53 PM, Vijayenthiran Subramaniam wrote:
> PcdChipCount constant is used to define the maximum number chips
> included in the multi-chip configuration. Add this constant to the
> RDN1EdgeX2 ACPI tables build information (INF) file to allow this
> constant to be used in the RDN1EdgeX2 ACPI tables.
>
> Signed-off-by: Vijayenthiran Subramaniam
> <vijayenthiran.subramaniam@arm.com>
> ---
>   Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> index 974d9db543..d44f02ab0c 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> @@ -45,6 +45,8 @@
>     gArmSgiTokenSpaceGuid.PcdDramBlock2Base
>     gArmSgiTokenSpaceGuid.PcdDramBlock2Size
>
> +  gArmSgiTokenSpaceGuid.PcdChipCount
> +
>     gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
>     gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
>     gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64503): https://edk2.groups.io/g/devel/message/64503
Mute This Topic: https://groups.io/mt/76288010/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.