Thanks Leif,
We will take care of same in future patches.
> -----Original Message-----
> From: Leif Lindholm <leif@nuviainc.com>
> Sent: Friday, July 24, 2020 10:17 PM
> To: Meenakshi Aggarwal (OSS) <meenakshi.aggarwal@oss.nxp.com>
> Cc: ard.biesheuvel@arm.com; michael.d.kinney@intel.com;
> devel@edk2.groups.io; Varun Sethi <V.Sethi@nxp.com>
> Subject: Re: [edk2-platforms] [PATCH v3 0/2] Add USB driver support
>
> On Fri, Jul 10, 2020 at 01:33:54 +0530, Meenakshi Aggarwal wrote:
> > This patchset implement USB driver for DWC3 controller and enable USB
> > for LX2160A Platform.
> >
> > Changes in v2:
> > - Indentation changes
> > - Incorporated review comments
> > - create EndOfDxe event and initialize USB in EndOfDxe
> > callback function.
> >
> > Changes in v3:
> > - Passing Usb initialization function as init function
> > of RegisterNonDiscoverableMmioDevice()
> >
> > Meenakshi Aggarwal (2):
> > Silicon/NXP: Add DWC3 USB controller initialization driver
> > Platform/NXP:LX2160: Enable support of USB controller
>
> For series:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
>
> However, in future, please rebase patches onto current master before
> sumitting later revisions. This set conflicted with 7c552c1a2611
> ("Platform/NXP: LX2160aRdbPkg: Enable PlatformDxe driver") which was
> pushed on 3 July.
>
> Pushed (together with SATA series previously reviewed) as:
> b972f17b329a..7de21b6aa3e0
>
> > Silicon/NXP/NxpQoriqLs.dec | 5 +
> > Silicon/NXP/LX2160A/LX2160A.dsc.inc | 4 +
> > Silicon/NXP/NxpQoriqLs.dsc.inc | 12 +
> > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 1 +
> > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 18 +-
> > Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf | 45 ++++
> > Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.h | 138 ++++++++++
> > Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.c | 275
> ++++++++++++++++++++
> > 8 files changed, 495 insertions(+), 3 deletions(-) create mode
> > 100644 Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf
> > create mode 100644 Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.h
> > create mode 100644 Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.c
> >
> > --
> > 1.9.1
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#63298): https://edk2.groups.io/g/devel/message/63298
Mute This Topic: https://groups.io/mt/75403794/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-