[edk2-devel] [edk2-platforms][PATCH v2 0/4] Platform: Add initial support for N1SDP board

Pranav Madhu posted 4 patches 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/1593190493-17450-1-git-send-email-pranav.madhu@arm.com
Silicon/ARM/N1Sdp/N1SdpPlatform.dec                |   49 +
Platform/ARM/N1SdpPkg/N1SdpPlatform.dsc            |  250 ++++
Platform/ARM/N1SdpPkg/N1SdpPlatform.fdf            |  294 ++++
.../N1SdpPciExpressLib/N1SdpPciExpressLib.inf      |   39 +
.../Library/PciHostBridgeLib/PciHostBridgeLib.inf  |   49 +
.../ARM/N1Sdp/Library/PlatformLib/PlatformLib.inf  |   56 +
Silicon/ARM/N1Sdp/Include/N1SdpPlatform.h          |   68 +
.../N1SdpPciExpressLib/N1SdpPciExpressLib.c        | 1545 ++++++++++++++++++++
.../Library/PciHostBridgeLib/PciHostBridgeLib.c    |  187 +++
.../ARM/N1Sdp/Library/PlatformLib/PlatformLib.c    |   67 +
.../ARM/N1Sdp/Library/PlatformLib/PlatformLibMem.c |  151 ++
.../ARM/N1Sdp/Library/PlatformLib/AArch64/Helper.S |   84 ++
12 files changed, 2839 insertions(+)
create mode 100644 Silicon/ARM/N1Sdp/N1SdpPlatform.dec
create mode 100644 Platform/ARM/N1SdpPkg/N1SdpPlatform.dsc
create mode 100644 Platform/ARM/N1SdpPkg/N1SdpPlatform.fdf
create mode 100644 Silicon/ARM/N1Sdp/Library/N1SdpPciExpressLib/N1SdpPciExpressLib.inf
create mode 100644 Silicon/ARM/N1Sdp/Library/PciHostBridgeLib/PciHostBridgeLib.inf
create mode 100644 Silicon/ARM/N1Sdp/Library/PlatformLib/PlatformLib.inf
create mode 100644 Silicon/ARM/N1Sdp/Include/N1SdpPlatform.h
create mode 100644 Silicon/ARM/N1Sdp/Library/N1SdpPciExpressLib/N1SdpPciExpressLib.c
create mode 100644 Silicon/ARM/N1Sdp/Library/PciHostBridgeLib/PciHostBridgeLib.c
create mode 100644 Silicon/ARM/N1Sdp/Library/PlatformLib/PlatformLib.c
create mode 100644 Silicon/ARM/N1Sdp/Library/PlatformLib/PlatformLibMem.c
create mode 100644 Silicon/ARM/N1Sdp/Library/PlatformLib/AArch64/Helper.S

[edk2-devel] [edk2-platforms][PATCH v2 0/4] Platform: Add initial support for N1SDP board

Posted by Pranav Madhu 2 weeks ago
Changes since v1:
- Addressed comments from Ard.
- Split the code between Silicon and Platform directories.

Arm's N1SDP is a Arm v8.2-A Neoverse N1 CPU based reference design platform
primariliy intended for development on Arm64 based platform. This patch series
adds initial platform support for this board.

The first patch in this series adds the platform libary implementation. The
second patch adds a custom implementation of the PciExpressLib due to a PCIe
integration issue which results in all config space accesses to non-existing
BDFs resulting in a Serror (bus abort). To avoid this, the N1SDP specific
PciExpressLib implementation provides a workaround for this issue. The third
patch in this series adds the platform library for the PciHostBridge. The
fourth patch adds the initial platform support for the N1SDP platform.

Deepak Pandey (4):
  Silicon/ARM/N1SDP: Add platform library implementation
  Silicon/ARM/N1SDP: Implement n1sdp specific PciExpressLib
  Silicon/ARM/N1SDP: Implement the PciHostBridgeLib library
  Platform/ARM/N1SDP: Add initial N1SDP platform support

 Silicon/ARM/N1Sdp/N1SdpPlatform.dec                |   49 +
 Platform/ARM/N1SdpPkg/N1SdpPlatform.dsc            |  250 ++++
 Platform/ARM/N1SdpPkg/N1SdpPlatform.fdf            |  294 ++++
 .../N1SdpPciExpressLib/N1SdpPciExpressLib.inf      |   39 +
 .../Library/PciHostBridgeLib/PciHostBridgeLib.inf  |   49 +
 .../ARM/N1Sdp/Library/PlatformLib/PlatformLib.inf  |   56 +
 Silicon/ARM/N1Sdp/Include/N1SdpPlatform.h          |   68 +
 .../N1SdpPciExpressLib/N1SdpPciExpressLib.c        | 1545 ++++++++++++++++++++
 .../Library/PciHostBridgeLib/PciHostBridgeLib.c    |  187 +++
 .../ARM/N1Sdp/Library/PlatformLib/PlatformLib.c    |   67 +
 .../ARM/N1Sdp/Library/PlatformLib/PlatformLibMem.c |  151 ++
 .../ARM/N1Sdp/Library/PlatformLib/AArch64/Helper.S |   84 ++
 12 files changed, 2839 insertions(+)
 create mode 100644 Silicon/ARM/N1Sdp/N1SdpPlatform.dec
 create mode 100644 Platform/ARM/N1SdpPkg/N1SdpPlatform.dsc
 create mode 100644 Platform/ARM/N1SdpPkg/N1SdpPlatform.fdf
 create mode 100644 Silicon/ARM/N1Sdp/Library/N1SdpPciExpressLib/N1SdpPciExpressLib.inf
 create mode 100644 Silicon/ARM/N1Sdp/Library/PciHostBridgeLib/PciHostBridgeLib.inf
 create mode 100644 Silicon/ARM/N1Sdp/Library/PlatformLib/PlatformLib.inf
 create mode 100644 Silicon/ARM/N1Sdp/Include/N1SdpPlatform.h
 create mode 100644 Silicon/ARM/N1Sdp/Library/N1SdpPciExpressLib/N1SdpPciExpressLib.c
 create mode 100644 Silicon/ARM/N1Sdp/Library/PciHostBridgeLib/PciHostBridgeLib.c
 create mode 100644 Silicon/ARM/N1Sdp/Library/PlatformLib/PlatformLib.c
 create mode 100644 Silicon/ARM/N1Sdp/Library/PlatformLib/PlatformLibMem.c
 create mode 100644 Silicon/ARM/N1Sdp/Library/PlatformLib/AArch64/Helper.S

-- 
2.7.4


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61747): https://edk2.groups.io/g/devel/message/61747
Mute This Topic: https://groups.io/mt/75128451/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/4] Platform: Add initial support for N1SDP board

Posted by Thomas Abraham 2 weeks ago
On Fri, Jun 26, 2020 at 10:27 PM Pranav Madhu <pranav.madhu@arm.com> wrote:
>
> Changes since v1:
> - Addressed comments from Ard.
> - Split the code between Silicon and Platform directories.
>
> Arm's N1SDP is a Arm v8.2-A Neoverse N1 CPU based reference design platform
> primariliy intended for development on Arm64 based platform. This patch series
> adds initial platform support for this board.
>
> The first patch in this series adds the platform libary implementation. The
> second patch adds a custom implementation of the PciExpressLib due to a PCIe
> integration issue which results in all config space accesses to non-existing
> BDFs resulting in a Serror (bus abort). To avoid this, the N1SDP specific
> PciExpressLib implementation provides a workaround for this issue. The third
> patch in this series adds the platform library for the PciHostBridge. The
> fourth patch adds the initial platform support for the N1SDP platform.
>
> Deepak Pandey (4):
>   Silicon/ARM/N1SDP: Add platform library implementation
>   Silicon/ARM/N1SDP: Implement n1sdp specific PciExpressLib
>   Silicon/ARM/N1SDP: Implement the PciHostBridgeLib library
>   Platform/ARM/N1SDP: Add initial N1SDP platform support

Apart from one comment on the first patch, rest looks okay. With that fixed,

For this series:
Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>

>
>  Silicon/ARM/N1Sdp/N1SdpPlatform.dec                |   49 +
>  Platform/ARM/N1SdpPkg/N1SdpPlatform.dsc            |  250 ++++
>  Platform/ARM/N1SdpPkg/N1SdpPlatform.fdf            |  294 ++++
>  .../N1SdpPciExpressLib/N1SdpPciExpressLib.inf      |   39 +
>  .../Library/PciHostBridgeLib/PciHostBridgeLib.inf  |   49 +
>  .../ARM/N1Sdp/Library/PlatformLib/PlatformLib.inf  |   56 +
>  Silicon/ARM/N1Sdp/Include/N1SdpPlatform.h          |   68 +
>  .../N1SdpPciExpressLib/N1SdpPciExpressLib.c        | 1545 ++++++++++++++++++++
>  .../Library/PciHostBridgeLib/PciHostBridgeLib.c    |  187 +++
>  .../ARM/N1Sdp/Library/PlatformLib/PlatformLib.c    |   67 +
>  .../ARM/N1Sdp/Library/PlatformLib/PlatformLibMem.c |  151 ++
>  .../ARM/N1Sdp/Library/PlatformLib/AArch64/Helper.S |   84 ++
>  12 files changed, 2839 insertions(+)
>  create mode 100644 Silicon/ARM/N1Sdp/N1SdpPlatform.dec
>  create mode 100644 Platform/ARM/N1SdpPkg/N1SdpPlatform.dsc
>  create mode 100644 Platform/ARM/N1SdpPkg/N1SdpPlatform.fdf
>  create mode 100644 Silicon/ARM/N1Sdp/Library/N1SdpPciExpressLib/N1SdpPciExpressLib.inf
>  create mode 100644 Silicon/ARM/N1Sdp/Library/PciHostBridgeLib/PciHostBridgeLib.inf
>  create mode 100644 Silicon/ARM/N1Sdp/Library/PlatformLib/PlatformLib.inf
>  create mode 100644 Silicon/ARM/N1Sdp/Include/N1SdpPlatform.h
>  create mode 100644 Silicon/ARM/N1Sdp/Library/N1SdpPciExpressLib/N1SdpPciExpressLib.c
>  create mode 100644 Silicon/ARM/N1Sdp/Library/PciHostBridgeLib/PciHostBridgeLib.c
>  create mode 100644 Silicon/ARM/N1Sdp/Library/PlatformLib/PlatformLib.c
>  create mode 100644 Silicon/ARM/N1Sdp/Library/PlatformLib/PlatformLibMem.c
>  create mode 100644 Silicon/ARM/N1Sdp/Library/PlatformLib/AArch64/Helper.S
>
> --
> 2.7.4
>
>
> ------------
> Groups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#61747): https://edk2.groups.io/g/devel/message/61747
> Mute This Topic: https://groups.io/mt/75128451/1785013
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub  [ta.omasab@gmail.com]
> ------------
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61761): https://edk2.groups.io/g/devel/message/61761
Mute This Topic: https://groups.io/mt/75128451/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-