[edk2-devel] [PATCH edk2-platforms V2 0/2] Add SATA driver support

Meenakshi Aggarwal posted 2 patches 3 years, 10 months ago
Failed in applying to current master (apply log)
Silicon/NXP/NxpQoriqLs.dec                      |   6 +
Silicon/NXP/LX2160A/LX2160A.dsc.inc             |   5 +
Silicon/NXP/NxpQoriqLs.dsc.inc                  |  10 ++
Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc    |   2 +
Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf    |  18 ++-
Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf |  45 +++++++
Silicon/NXP/Drivers/SataInitDxe/SataInit.c      | 124 ++++++++++++++++++++
7 files changed, 207 insertions(+), 3 deletions(-)
create mode 100644 Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf
create mode 100644 Silicon/NXP/Drivers/SataInitDxe/SataInit.c
[edk2-devel] [PATCH edk2-platforms V2 0/2] Add SATA driver support
Posted by Meenakshi Aggarwal 3 years, 10 months ago
This patchset implement SATA driver for NXP Platforms enable
SATA for LX2160A Platform.

Changes in v2:
	- Incorporated review comments
	- Removed header file and define macro in .c file

Meenakshi Aggarwal (2):
  Silicon/NXP: Add SATA controller initialization driver
  Platform/NXP:LX2160: Enable support of SATA controller

 Silicon/NXP/NxpQoriqLs.dec                      |   6 +
 Silicon/NXP/LX2160A/LX2160A.dsc.inc             |   5 +
 Silicon/NXP/NxpQoriqLs.dsc.inc                  |  10 ++
 Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc    |   2 +
 Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf    |  18 ++-
 Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf |  45 +++++++
 Silicon/NXP/Drivers/SataInitDxe/SataInit.c      | 124 ++++++++++++++++++++
 7 files changed, 207 insertions(+), 3 deletions(-)
 create mode 100644 Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf
 create mode 100644 Silicon/NXP/Drivers/SataInitDxe/SataInit.c

-- 
1.9.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60935): https://edk2.groups.io/g/devel/message/60935
Mute This Topic: https://groups.io/mt/74770830/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms V2 0/2] Add SATA driver support
Posted by Leif Lindholm 3 years, 10 months ago
On Tue, Jun 09, 2020 at 20:01:03 +0530, Meenakshi Aggarwal wrote:
> This patchset implement SATA driver for NXP Platforms enable
> SATA for LX2160A Platform.
> 
> Changes in v2:
> 	- Incorporated review comments
> 	- Removed header file and define macro in .c file

For this set:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

*However*, this set does not apply cleanly without the "Add USB driver
 support" set, and that set has an outstanding question from Ard in
https://edk2.groups.io/g/devel/message/61211.

I'll leave it up to you whether we get that set merged first, or
whether you can rebase this one.

/
    Leif

> Meenakshi Aggarwal (2):
>   Silicon/NXP: Add SATA controller initialization driver
>   Platform/NXP:LX2160: Enable support of SATA controller
> 
>  Silicon/NXP/NxpQoriqLs.dec                      |   6 +
>  Silicon/NXP/LX2160A/LX2160A.dsc.inc             |   5 +
>  Silicon/NXP/NxpQoriqLs.dsc.inc                  |  10 ++
>  Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc    |   2 +
>  Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf    |  18 ++-
>  Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf |  45 +++++++
>  Silicon/NXP/Drivers/SataInitDxe/SataInit.c      | 124 ++++++++++++++++++++
>  7 files changed, 207 insertions(+), 3 deletions(-)
>  create mode 100644 Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf
>  create mode 100644 Silicon/NXP/Drivers/SataInitDxe/SataInit.c
> 
> -- 
> 1.9.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61405): https://edk2.groups.io/g/devel/message/61405
Mute This Topic: https://groups.io/mt/74770830/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms V2 0/2] Add SATA driver support
Posted by Meenakshi Aggarwal (OSS) 3 years, 10 months ago
Hi Leif,

I am working on USB patch.

Thanks,
Meenakshi

> -----Original Message----
> From: Leif Lindholm <leif@nuviainc.com>
> Sent: Wednesday, June 17, 2020 5:25 PM
> To: Meenakshi Aggarwal (OSS) <meenakshi.aggarwal@oss.nxp.com>
> Cc: ard.biesheuvel@arm.com; michael.d.kinney@intel.com;
> devel@edk2.groups.io; Varun Sethi <V.Sethi@nxp.com>
> Subject: Re: [PATCH edk2-platforms V2 0/2] Add SATA driver support
> 
> On Tue, Jun 09, 2020 at 20:01:03 +0530, Meenakshi Aggarwal wrote:
> > This patchset implement SATA driver for NXP Platforms enable SATA for
> > LX2160A Platform.
> >
> > Changes in v2:
> > 	- Incorporated review comments
> > 	- Removed header file and define macro in .c file
> 
> For this set:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> 
> *However*, this set does not apply cleanly without the "Add USB driver
> support" set, and that set has an outstanding question from Ard in
> https://edk2.groups.io/g/devel/message/61211.
> 
> I'll leave it up to you whether we get that set merged first, or whether you can
> rebase this one.
> 
> /
>     Leif
> 
> > Meenakshi Aggarwal (2):
> >   Silicon/NXP: Add SATA controller initialization driver
> >   Platform/NXP:LX2160: Enable support of SATA controller
> >
> >  Silicon/NXP/NxpQoriqLs.dec                      |   6 +
> >  Silicon/NXP/LX2160A/LX2160A.dsc.inc             |   5 +
> >  Silicon/NXP/NxpQoriqLs.dsc.inc                  |  10 ++
> >  Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc    |   2 +
> >  Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf    |  18 ++-
> >  Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf |  45 +++++++
> >  Silicon/NXP/Drivers/SataInitDxe/SataInit.c      | 124 ++++++++++++++++++++
> >  7 files changed, 207 insertions(+), 3 deletions(-)  create mode
> > 100644 Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf
> >  create mode 100644 Silicon/NXP/Drivers/SataInitDxe/SataInit.c
> >
> > --
> > 1.9.1
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61619): https://edk2.groups.io/g/devel/message/61619
Mute This Topic: https://groups.io/mt/74770830/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-