[edk2-devel] [PATCH edk2 v2 5/5] Silicon/Hisilicon/FlashFvbDxe: Declare missing GUID dependency

Ming Huang posted 5 patches 5 years, 8 months ago
There is a newer version of this series
[edk2-devel] [PATCH edk2 v2 5/5] Silicon/Hisilicon/FlashFvbDxe: Declare missing GUID dependency
Posted by Ming Huang 5 years, 8 months ago
FlashFvbDxe depends on gEfiEventVirtualAddressChangeGuid, but got
away with not declaring it in its INF because of a transitive
dependency. However, this dependency got dropped in core EDK2,
resulting in build failures of the D0x platform.

Signed-off-by: Ming Huang <huangming23@huawei.com>
---
 Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf b/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf
index 23591b8..1119361 100644
--- a/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf
+++ b/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf
@@ -38,6 +38,7 @@
   UefiRuntimeLib
 
 [Guids]
+  gEfiEventVirtualAddressChangeGuid
   gEfiSystemNvDataFvGuid
   gEfiVariableGuid
 
-- 
2.8.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60348): https://edk2.groups.io/g/devel/message/60348
Mute This Topic: https://groups.io/mt/74501285/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2 v2 5/5] Silicon/Hisilicon/FlashFvbDxe: Declare missing GUID dependency
Posted by Leif Lindholm 5 years, 8 months ago
On Wed, May 27, 2020 at 22:33:58 +0800, Ming Huang wrote:
> FlashFvbDxe depends on gEfiEventVirtualAddressChangeGuid, but got
> away with not declaring it in its INF because of a transitive
> dependency. However, this dependency got dropped in core EDK2,
> resulting in build failures of the D0x platform.
> 
> Signed-off-by: Ming Huang <huangming23@huawei.com>

This file is a prerequisite for building the remaining patches, so
should have come in as 1/5. Regardless, it has no dependencies on 1-4,
so: Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as cf2f013b9dee.

> ---
>  Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf b/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf
> index 23591b8..1119361 100644
> --- a/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf
> +++ b/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf
> @@ -38,6 +38,7 @@
>    UefiRuntimeLib
>  
>  [Guids]
> +  gEfiEventVirtualAddressChangeGuid
>    gEfiSystemNvDataFvGuid
>    gEfiVariableGuid
>  
> -- 
> 2.8.1
> 
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60888): https://edk2.groups.io/g/devel/message/60888
Mute This Topic: https://groups.io/mt/74501285/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-