[edk2-devel] [RFC edk2-platforms v1 0/3] Improve D0x

Ming Huang posted 3 patches 3 years, 11 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c      |  62 +-
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf |   8 +-
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c            | 500 ----------------
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.h            |  16 -
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.c        | 612 ++++++++++++++++++++
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.h        |  16 +
6 files changed, 689 insertions(+), 525 deletions(-)
delete mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c
delete mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.h
create mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.c
create mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.h
[edk2-devel] [RFC edk2-platforms v1 0/3] Improve D0x
Posted by Ming Huang 3 years, 11 months ago
Main Changes:
Add update sas address feature in AcpiPlatformDxe.

Ming Huang (3):
  Silicon/Hisilicon: Change updating dsdt in ready to boot event
  Silicon/Hisilicon/Acpi: Add update sas address feature
  Silicon/Hisilicon: Rename EthMac files

 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c      |  62 +-
 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf |   8 +-
 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c            | 500 ----------------
 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.h            |  16 -
 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.c        | 612 ++++++++++++++++++++
 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.h        |  16 +
 6 files changed, 689 insertions(+), 525 deletions(-)
 delete mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c
 delete mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.h
 create mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.c
 create mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.h

-- 
2.8.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60033): https://edk2.groups.io/g/devel/message/60033
Mute This Topic: https://groups.io/mt/74377142/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [RFC edk2-platforms v1 0/3] Improve D0x
Posted by Leif Lindholm 3 years, 10 months ago
On trying to build the resulting output, I found the build breaks with
/work/git/edk2-platforms/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.c:
In function ‘FlashFvbInitialize’:
/work/git/edk2-platforms/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.c:1231:20:
error: ‘gEfiEventVirtualAddressChangeGuid’ undeclared (first use in
this function); did you mean ‘EfiSetVirtualAddressMap’?
                   &gEfiEventVirtualAddressChangeGuid,
		                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
				                           EfiSetVirtualAddressMap

The error would appear identical to that resolved by
commit a327627dd3f9edc113b1de6d897222d0517834db

Could you please provide a corresponding fix?

Best Regards,

Leif

On Thu, May 21, 2020 at 22:43:01 +0800, Ming Huang wrote:
> Main Changes:
> Add update sas address feature in AcpiPlatformDxe.
> 
> Ming Huang (3):
>   Silicon/Hisilicon: Change updating dsdt in ready to boot event
>   Silicon/Hisilicon/Acpi: Add update sas address feature
>   Silicon/Hisilicon: Rename EthMac files
> 
>  Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c      |  62 +-
>  Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf |   8 +-
>  Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c            | 500 ----------------
>  Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.h            |  16 -
>  Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.c        | 612 ++++++++++++++++++++
>  Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.h        |  16 +
>  6 files changed, 689 insertions(+), 525 deletions(-)
>  delete mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c
>  delete mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.h
>  create mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.c
>  create mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.h
> 
> -- 
> 2.8.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60294): https://edk2.groups.io/g/devel/message/60294
Mute This Topic: https://groups.io/mt/74377142/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [RFC edk2-platforms v1 0/3] Improve D0x
Posted by Ming Huang 3 years, 10 months ago

在 2020/5/27 2:09, Leif Lindholm 写道:
> On trying to build the resulting output, I found the build breaks with
> /work/git/edk2-platforms/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.c:
> In function ‘FlashFvbInitialize’:
> /work/git/edk2-platforms/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.c:1231:20:
> error: ‘gEfiEventVirtualAddressChangeGuid’ undeclared (first use in
> this function); did you mean ‘EfiSetVirtualAddressMap’?
>                    &gEfiEventVirtualAddressChangeGuid,
> 		                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 				                           EfiSetVirtualAddressMap
> 
> The error would appear identical to that resolved by
> commit a327627dd3f9edc113b1de6d897222d0517834db
> 
> Could you please provide a corresponding fix?

Ok, I will add a patch in v2.

Thanks,
Ming

> 
> Best Regards,
> 
> Leif
> 
> On Thu, May 21, 2020 at 22:43:01 +0800, Ming Huang wrote:
>> Main Changes:
>> Add update sas address feature in AcpiPlatformDxe.
>>
>> Ming Huang (3):
>>   Silicon/Hisilicon: Change updating dsdt in ready to boot event
>>   Silicon/Hisilicon/Acpi: Add update sas address feature
>>   Silicon/Hisilicon: Rename EthMac files
>>
>>  Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c      |  62 +-
>>  Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf |   8 +-
>>  Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c            | 500 ----------------
>>  Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.h            |  16 -
>>  Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.c        | 612 ++++++++++++++++++++
>>  Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.h        |  16 +
>>  6 files changed, 689 insertions(+), 525 deletions(-)
>>  delete mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c
>>  delete mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.h
>>  create mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.c
>>  create mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.h
>>
>> -- 
>> 2.8.1
>>
> 
> .
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60346): https://edk2.groups.io/g/devel/message/60346
Mute This Topic: https://groups.io/mt/74377142/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-