[edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove Executable attribute from MpLib.h

Leo Duran posted 1 patch 4 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/1587506704-2232-1-git-send-email-leo.duran@amd.com
UefiCpuPkg/Library/MpInitLib/MpLib.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644 UefiCpuPkg/Library/MpInitLib/MpLib.h
[edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove Executable attribute from MpLib.h
Posted by Leo Duran 4 years ago
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2678

This patch fixes a file permission issue introduced by accident.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Leo Duran <leo.duran@amd.com>
---
 UefiCpuPkg/Library/MpInitLib/MpLib.h | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100755 => 100644 UefiCpuPkg/Library/MpInitLib/MpLib.h

diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
old mode 100755
new mode 100644
-- 
2.7.4


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57803): https://edk2.groups.io/g/devel/message/57803
Mute This Topic: https://groups.io/mt/73191992/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove Executable attribute from MpLib.h
Posted by Laszlo Ersek 4 years ago
On 04/22/20 00:05, Leo Duran wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2678
> 
> This patch fixes a file permission issue introduced by accident.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Leo Duran <leo.duran@amd.com>
> ---
>  UefiCpuPkg/Library/MpInitLib/MpLib.h | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  mode change 100755 => 100644 UefiCpuPkg/Library/MpInitLib/MpLib.h
> 
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
> old mode 100755
> new mode 100644
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks, Leo!
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57827): https://edk2.groups.io/g/devel/message/57827
Mute This Topic: https://groups.io/mt/73191992/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove Executable attribute from MpLib.h
Posted by Laszlo Ersek 3 years, 11 months ago
Eric, Ray,

can one of you please approve, and also merge, this patch?

It's been on the list for two weeks now (and you were CC'd). I didn't
want to go ahead and merge it myself without at least an ACK from one of
you.

Thanks
Laszlo

On 04/22/20 18:55, Laszlo Ersek wrote:
> On 04/22/20 00:05, Leo Duran wrote:
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2678
>>
>> This patch fixes a file permission issue introduced by accident.
>>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Signed-off-by: Leo Duran <leo.duran@amd.com>
>> ---
>>  UefiCpuPkg/Library/MpInitLib/MpLib.h | 0
>>  1 file changed, 0 insertions(+), 0 deletions(-)
>>  mode change 100755 => 100644 UefiCpuPkg/Library/MpInitLib/MpLib.h
>>
>> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
>> old mode 100755
>> new mode 100644
>>
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> Thanks, Leo!
> Laszlo
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58668): https://edk2.groups.io/g/devel/message/58668
Mute This Topic: https://groups.io/mt/73191992/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove Executable attribute from MpLib.h
Posted by Dong, Eric 3 years, 11 months ago
Acked-by: Eric Dong <eric.dong@intel.com>

Hi Laszlo,

I saw you already provided Review-by tag and I can't verify the change, so I don't add comments for this patch.

I will provide Acked-by tag for the similar case next time.

I have pushed this change.

Thanks,
Eric
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo Ersek
Sent: Wednesday, May 6, 2020 7:22 AM
To: devel@edk2.groups.io; Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
Cc: Leo Duran <leo.duran@amd.com>
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove Executable attribute from MpLib.h

Eric, Ray,

can one of you please approve, and also merge, this patch?

It's been on the list for two weeks now (and you were CC'd). I didn't
want to go ahead and merge it myself without at least an ACK from one of
you.

Thanks
Laszlo

On 04/22/20 18:55, Laszlo Ersek wrote:
> On 04/22/20 00:05, Leo Duran wrote:
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2678
>>
>> This patch fixes a file permission issue introduced by accident.
>>
>> Cc: Eric Dong <eric.dong@intel.com<mailto:eric.dong@intel.com>>
>> Cc: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>>
>> Cc: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>
>> Signed-off-by: Leo Duran <leo.duran@amd.com<mailto:leo.duran@amd.com>>
>> ---
>>  UefiCpuPkg/Library/MpInitLib/MpLib.h | 0
>>  1 file changed, 0 insertions(+), 0 deletions(-)
>>  mode change 100755 => 100644 UefiCpuPkg/Library/MpInitLib/MpLib.h
>>
>> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
>> old mode 100755
>> new mode 100644
>>
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>
>
> Thanks, Leo!
> Laszlo
>
>
>
>




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58671): https://edk2.groups.io/g/devel/message/58671
Mute This Topic: https://groups.io/mt/73191992/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove Executable attribute from MpLib.h
Posted by Laszlo Ersek 3 years, 11 months ago
On 05/06/20 03:31, Dong, Eric wrote:
> Acked-by: Eric Dong <eric.dong@intel.com>
> 
> Hi Laszlo,
> 
> I saw you already provided Review-by tag and I can't verify the change, so I don't add comments for this patch.
> 
> I will provide Acked-by tag for the similar case next time.

Thank you -- I only have an "R" role for UefiCpuPkg; I don't think I
should push any UefiCpuPkg patch without "M" approval.

> I have pushed this change.

Thank you!
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58715): https://edk2.groups.io/g/devel/message/58715
Mute This Topic: https://groups.io/mt/73191992/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-