[edk2-devel] [edk2-platforms] [PATCH v3 0/5] Platform/ARM/SgiPkg: Add support for RD-N1-Edge-Dual platform

Vijayenthiran Subramaniam posted 5 patches 32 weeks ago
Failed in applying to current master (apply log)
Platform/ARM/SgiPkg/SgiPlatform.dec                          |   1 +
Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc                 |   3 +
Platform/ARM/SgiPkg/SgiPlatform.dsc                          |   4 +
Platform/ARM/SgiPkg/SgiPlatform.fdf                          |   1 +
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf      |  59 ++++++
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf      |   1 +
Platform/ARM/SgiPkg/Include/SgiPlatform.h                    |   7 +
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c        |  61 +++++-
Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c |   8 +
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc          | 198 ++++++++++++++++++++
10 files changed, 333 insertions(+), 10 deletions(-)
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc

[edk2-devel] [edk2-platforms] [PATCH v3 0/5] Platform/ARM/SgiPkg: Add support for RD-N1-Edge-Dual platform

Posted by Vijayenthiran Subramaniam 32 weeks ago
Changes since v2:
- Rename i to Idx in Patch 2/5
- Retaining R-b in rest of the patches as there's no change

Changes since v1:
- Fix typo which caused build error

This patch series adds support for RD-N1-Edge platform with multi-chip
capability. The first patch in this series is an improvement to SgiPkg to avoid
any usage of deprecated APIs. The second patch refactors the existing code to
use lookup table in order to identify the platform. The rest of the patch adds
multi-chip support for the RD-N1-Edge platform.

Vijayenthiran Subramaniam (5):
  Platform/ARM/SgiPkg: Disable use of deprecated APIs
  Platform/ARM/SgiPkg: Use lookup table to install ACPI table
  Platform/ARM/SgiPkg: Add MultiChipMode to Platform Descriptor
  Platform/ARM/Sgi: Add ACPI tables for dual-chip RD-N1-Edge platform
  Platform/ARM/Sgi: Add initial support for RD-N1-Edge-Dual platform

 Platform/ARM/SgiPkg/SgiPlatform.dec                          |   1 +
 Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc                 |   3 +
 Platform/ARM/SgiPkg/SgiPlatform.dsc                          |   4 +
 Platform/ARM/SgiPkg/SgiPlatform.fdf                          |   1 +
 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf      |  59 ++++++
 Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf      |   1 +
 Platform/ARM/SgiPkg/Include/SgiPlatform.h                    |   7 +
 Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c        |  61 +++++-
 Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c |   8 +
 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc          | 198 ++++++++++++++++++++
 10 files changed, 333 insertions(+), 10 deletions(-)
 create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
 create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc

-- 
2.7.4


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54441): https://edk2.groups.io/g/devel/message/54441
Mute This Topic: https://groups.io/mt/71270708/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH v3 0/5] Platform/ARM/SgiPkg: Add support for RD-N1-Edge-Dual platform

Posted by Leif Lindholm 31 weeks ago
On Fri, Feb 14, 2020 at 19:11:29 +0530, Vijayenthiran Subramaniam wrote:
> Changes since v2:
> - Rename i to Idx in Patch 2/5
> - Retaining R-b in rest of the patches as there's no change
> 
> Changes since v1:
> - Fix typo which caused build error
> 
> This patch series adds support for RD-N1-Edge platform with multi-chip
> capability. The first patch in this series is an improvement to SgiPkg to avoid
> any usage of deprecated APIs. The second patch refactors the existing code to
> use lookup table in order to identify the platform. The rest of the patch adds
> multi-chip support for the RD-N1-Edge platform.

For remaining patches:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

Series pushed as 41c1d9ba3304..2fb4670d9f68.

However, while test building I noticed the SGI platform currently
fails to build with clang (version 7 in my case). This fails also
before this set however.

But could you please look into the warnings in
Platform/ARM/SgiPkg/Drivers/PlatformDxe/VirtioDevices.c
?

Regards,

Leif

> Vijayenthiran Subramaniam (5):
>   Platform/ARM/SgiPkg: Disable use of deprecated APIs
>   Platform/ARM/SgiPkg: Use lookup table to install ACPI table
>   Platform/ARM/SgiPkg: Add MultiChipMode to Platform Descriptor
>   Platform/ARM/Sgi: Add ACPI tables for dual-chip RD-N1-Edge platform
>   Platform/ARM/Sgi: Add initial support for RD-N1-Edge-Dual platform
> 
>  Platform/ARM/SgiPkg/SgiPlatform.dec                          |   1 +
>  Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc                 |   3 +
>  Platform/ARM/SgiPkg/SgiPlatform.dsc                          |   4 +
>  Platform/ARM/SgiPkg/SgiPlatform.fdf                          |   1 +
>  Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf      |  59 ++++++
>  Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf      |   1 +
>  Platform/ARM/SgiPkg/Include/SgiPlatform.h                    |   7 +
>  Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c        |  61 +++++-
>  Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c |   8 +
>  Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc          | 198 ++++++++++++++++++++
>  10 files changed, 333 insertions(+), 10 deletions(-)
>  create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
>  create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc
> 
> -- 
> 2.7.4
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54586): https://edk2.groups.io/g/devel/message/54586
Mute This Topic: https://groups.io/mt/71270708/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH v3 0/5] Platform/ARM/SgiPkg: Add support for RD-N1-Edge-Dual platform

Posted by Vijayenthiran Subramaniam 31 weeks ago
Hi Leif,

On Tue, Feb 18, 2020 at 8:34 PM Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Fri, Feb 14, 2020 at 19:11:29 +0530, Vijayenthiran Subramaniam wrote:
> > Changes since v2:
> > - Rename i to Idx in Patch 2/5
> > - Retaining R-b in rest of the patches as there's no change
> >
> > Changes since v1:
> > - Fix typo which caused build error
> >
> > This patch series adds support for RD-N1-Edge platform with multi-chip
> > capability. The first patch in this series is an improvement to SgiPkg to avoid
> > any usage of deprecated APIs. The second patch refactors the existing code to
> > use lookup table in order to identify the platform. The rest of the patch adds
> > multi-chip support for the RD-N1-Edge platform.
>
> For remaining patches:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
>
> Series pushed as 41c1d9ba3304..2fb4670d9f68.
>
> However, while test building I noticed the SGI platform currently
> fails to build with clang (version 7 in my case). This fails also
> before this set however.
>
> But could you please look into the warnings in
> Platform/ARM/SgiPkg/Drivers/PlatformDxe/VirtioDevices.c
> ?

Thanks for checking. I've posted a patch fixing this:
https://edk2.groups.io/g/devel/message/54618

>
> Regards,
>
> Leif
>
> > Vijayenthiran Subramaniam (5):
> >   Platform/ARM/SgiPkg: Disable use of deprecated APIs
> >   Platform/ARM/SgiPkg: Use lookup table to install ACPI table
> >   Platform/ARM/SgiPkg: Add MultiChipMode to Platform Descriptor
> >   Platform/ARM/Sgi: Add ACPI tables for dual-chip RD-N1-Edge platform
> >   Platform/ARM/Sgi: Add initial support for RD-N1-Edge-Dual platform
> >
> >  Platform/ARM/SgiPkg/SgiPlatform.dec                          |   1 +
> >  Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc                 |   3 +
> >  Platform/ARM/SgiPkg/SgiPlatform.dsc                          |   4 +
> >  Platform/ARM/SgiPkg/SgiPlatform.fdf                          |   1 +
> >  Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf      |  59 ++++++
> >  Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf      |   1 +
> >  Platform/ARM/SgiPkg/Include/SgiPlatform.h                    |   7 +
> >  Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c        |  61 +++++-
> >  Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c |   8 +
> >  Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc          | 198 ++++++++++++++++++++
> >  10 files changed, 333 insertions(+), 10 deletions(-)
> >  create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> >  create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc
> >
> > --
> > 2.7.4

Regards,
Vijay

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54619): https://edk2.groups.io/g/devel/message/54619
Mute This Topic: https://groups.io/mt/71270708/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-