[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md

Abner Chang posted 39 patches 6 years, 1 month ago
Only 37 patches received!
[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md
Posted by Abner Chang 6 years, 1 month ago
Add opensbi submodule.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
---
 Readme.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Readme.md b/Readme.md
index 27e4ce0..4b3d2a5 100644
--- a/Readme.md
+++ b/Readme.md
@@ -148,6 +148,7 @@ as possible as we can. Currently EDK II contains two submodules
 
 - CryptoPkg/Library/OpensslLib/openssl
 - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
+- RiscVPkg/Library/RiscVOpensbiLib/opensbi
 
 The latter one is actually required by previous one. It's inevitable
 in openssl-1.1.1 (since stable201905) for floating point parameter
-- 
2.7.4


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49515): https://edk2.groups.io/g/devel/message/49515
Mute This Topic: https://groups.io/mt/38757610/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md
Posted by Laszlo Ersek 6 years, 1 month ago
On 10/28/19 02:59, Abner Chang wrote:
> Add opensbi submodule.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> ---
>  Readme.md | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Readme.md b/Readme.md
> index 27e4ce0..4b3d2a5 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -148,6 +148,7 @@ as possible as we can. Currently EDK II contains two submodules
>  
>  - CryptoPkg/Library/OpensslLib/openssl
>  - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> +- RiscVPkg/Library/RiscVOpensbiLib/opensbi
>  
>  The latter one is actually required by previous one. It's inevitable
>  in openssl-1.1.1 (since stable201905) for floating point parameter
> 

This will take an update that's a bit more extensive -- please see "two
submodules" just above the listing, and "latter one" right after the
listing. Adding opensbi in the proposed spot breaks both statements.

Thanks
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49567): https://edk2.groups.io/g/devel/message/49567
Mute This Topic: https://groups.io/mt/38757610/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md
Posted by Abner Chang 6 years, 1 month ago

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, October 29, 2019 9:07 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm
> <leif.lindholm@linaro.org>; Michael D Kinney <michael.d.kinney@intel.com>;
> Chen, Gilbert <gilbert.chen@hpe.com>
> Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-
> staging: Revise Readme.md
> 
> On 10/28/19 02:59, Abner Chang wrote:
> > Add opensbi submodule.
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Gilbert Chen <gilbert.chen@hpe.com>
> > ---
> >  Readme.md | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Readme.md b/Readme.md
> > index 27e4ce0..4b3d2a5 100644
> > --- a/Readme.md
> > +++ b/Readme.md
> > @@ -148,6 +148,7 @@ as possible as we can. Currently EDK II contains
> > two submodules
> >
> >  - CryptoPkg/Library/OpensslLib/openssl
> >  - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> > +- RiscVPkg/Library/RiscVOpensbiLib/opensbi
> >
> >  The latter one is actually required by previous one. It's inevitable
> > in openssl-1.1.1 (since stable201905) for floating point parameter
> >
> 
> This will take an update that's a bit more extensive -- please see "two
> submodules" just above the listing, and "latter one" right after the listing.
> Adding opensbi in the proposed spot breaks both statements.

Sigh. Didn’t see it. will fix it. Thanks for catching this.

> 
> Thanks
> Laszlo
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49571): https://edk2.groups.io/g/devel/message/49571
Mute This Topic: https://groups.io/mt/38757610/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md
Posted by Leif Lindholm 6 years, 1 month ago
On Tue, Oct 29, 2019 at 02:07:20AM +0100, Laszlo Ersek wrote:
> > diff --git a/Readme.md b/Readme.md
> > index 27e4ce0..4b3d2a5 100644
> > --- a/Readme.md
> > +++ b/Readme.md
> > @@ -148,6 +148,7 @@ as possible as we can. Currently EDK II contains two submodules
> >  
> >  - CryptoPkg/Library/OpensslLib/openssl
> >  - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> > +- RiscVPkg/Library/RiscVOpensbiLib/opensbi
> >  
> >  The latter one is actually required by previous one. It's inevitable
> >  in openssl-1.1.1 (since stable201905) for floating point parameter
> 
> This will take an update that's a bit more extensive -- please see "two
> submodules" just above the listing, and "latter one" right after the
> listing. Adding opensbi in the proposed spot breaks both statements.

This suggests the surrounding language should change.

Could we merge this to master?:

From 39f08033c934b3e631c40e373aa6a351323ab4aa Mon Sep 17 00:00:00 2001
From: Leif Lindholm <leif.lindholm@linaro.org>
Date: Tue, 29 Oct 2019 09:54:36 +0800
Subject: [PATCH 1/1] Readme.md: remove positional references from submodule description

Remove references to the number of submodules in the tree, as well as
reword the referring to specific submodules as "former" and "previous".
This means we won't need to keep updating the surrounding text if we
add/remove submodules.

Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
 Readme.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Readme.md b/Readme.md
index 27e4ce07719b..9bf60bede8ec 100644
--- a/Readme.md
+++ b/Readme.md
@@ -144,12 +144,12 @@ Signed-off-by: Contributor Name <contributor@example.com>
 # Submodules
 
 Submodule in EDK II is allowed but submodule chain should be avoided
-as possible as we can. Currently EDK II contains two submodules
+as possible as we can. Currently EDK II contains the following submodules
 
 - CryptoPkg/Library/OpensslLib/openssl
 - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
 
-The latter one is actually required by previous one. It's inevitable
+ArmSoftFloatLib is actually required by OpensslLib. It's inevitable
 in openssl-1.1.1 (since stable201905) for floating point parameter
 conversion, but should be dropped once there's no such need in future
 release of openssl.
-- 
2.20.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49574): https://edk2.groups.io/g/devel/message/49574
Mute This Topic: https://groups.io/mt/38757610/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md
Posted by Laszlo Ersek 6 years, 1 month ago
On 10/29/19 03:01, Leif Lindholm wrote:
> On Tue, Oct 29, 2019 at 02:07:20AM +0100, Laszlo Ersek wrote:
>>> diff --git a/Readme.md b/Readme.md
>>> index 27e4ce0..4b3d2a5 100644
>>> --- a/Readme.md
>>> +++ b/Readme.md
>>> @@ -148,6 +148,7 @@ as possible as we can. Currently EDK II contains two submodules
>>>  
>>>  - CryptoPkg/Library/OpensslLib/openssl
>>>  - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
>>> +- RiscVPkg/Library/RiscVOpensbiLib/opensbi
>>>  
>>>  The latter one is actually required by previous one. It's inevitable
>>>  in openssl-1.1.1 (since stable201905) for floating point parameter
>>
>> This will take an update that's a bit more extensive -- please see "two
>> submodules" just above the listing, and "latter one" right after the
>> listing. Adding opensbi in the proposed spot breaks both statements.
> 
> This suggests the surrounding language should change.
> 
> Could we merge this to master?:
> 
> From 39f08033c934b3e631c40e373aa6a351323ab4aa Mon Sep 17 00:00:00 2001
> From: Leif Lindholm <leif.lindholm@linaro.org>
> Date: Tue, 29 Oct 2019 09:54:36 +0800
> Subject: [PATCH 1/1] Readme.md: remove positional references from submodule description
> 
> Remove references to the number of submodules in the tree, as well as
> reword the referring to specific submodules as "former" and "previous".
> This means we won't need to keep updating the surrounding text if we
> add/remove submodules.
> 
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>  Readme.md | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Readme.md b/Readme.md
> index 27e4ce07719b..9bf60bede8ec 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -144,12 +144,12 @@ Signed-off-by: Contributor Name <contributor@example.com>
>  # Submodules
>  
>  Submodule in EDK II is allowed but submodule chain should be avoided
> -as possible as we can. Currently EDK II contains two submodules
> +as possible as we can. Currently EDK II contains the following submodules
>  
>  - CryptoPkg/Library/OpensslLib/openssl
>  - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
>  
> -The latter one is actually required by previous one. It's inevitable
> +ArmSoftFloatLib is actually required by OpensslLib. It's inevitable
>  in openssl-1.1.1 (since stable201905) for floating point parameter
>  conversion, but should be dropped once there's no such need in future
>  release of openssl.
> 

Good idea. When you post this in isolation for edk2, please add:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49736): https://edk2.groups.io/g/devel/message/49736
Mute This Topic: https://groups.io/mt/38757610/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md
Posted by Leif Lindholm 6 years ago
Well, there's no 0/39 for me to give a generic comment on (please use
a cover-letter).

Anything in this set I have not commented on I would consider good to
go into -staging (and pretty close to be able to go into edk2 master).

I have given a few comments that should be trivial to respin.

I have given one comment that will not be, but it needs to happen -
the include wrappers. Clearly that will have impact on other patches
as well, but as long as include statements are all that changes, that
does not need further review.

*But*, it will mean we have compartmentalised the opensbi
import, and can improve its importability upstream without having to
do this work at the same time.

/
    Leif

On Mon, Oct 28, 2019 at 09:59:17 +0800, Abner Chang wrote:
> Add opensbi submodule.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> ---
>  Readme.md | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Readme.md b/Readme.md
> index 27e4ce0..4b3d2a5 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -148,6 +148,7 @@ as possible as we can. Currently EDK II contains two submodules
>  
>  - CryptoPkg/Library/OpensslLib/openssl
>  - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> +- RiscVPkg/Library/RiscVOpensbiLib/opensbi
>  
>  The latter one is actually required by previous one. It's inevitable
>  in openssl-1.1.1 (since stable201905) for floating point parameter
> -- 
> 2.7.4
> 
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51104): https://edk2.groups.io/g/devel/message/51104
Mute This Topic: https://groups.io/mt/38757610/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md
Posted by Abner Chang 6 years ago
Palmer removed.

> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Friday, November 22, 2019 1:15 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>;
> Michael D Kinney <michael.d.kinney@intel.com>; Chen, Gilbert
> <gilbert.chen@hpe.com>; Palmer Dabbelt <palmer@sifive.com>
> Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-
> staging: Revise Readme.md
> 
> Well, there's no 0/39 for me to give a generic comment on (please use a
> cover-letter).
There is a cover letter sent with this set of patches, you probably missed it. attached here in case you would like to give comments there.

> 
> Anything in this set I have not commented on I would consider good to go
> into -staging (and pretty close to be able to go into edk2 master).
Got it.

> 
> I have given a few comments that should be trivial to respin.
> 
> I have given one comment that will not be, but it needs to happen - the
> include wrappers. Clearly that will have impact on other patches as well, but
> as long as include statements are all that changes, that does not need further
> review.
> 
> *But*, it will mean we have compartmentalised the opensbi import, and can
> improve its importability upstream without having to do this work at the
> same time.

I didn't look into this in detail yet. Let me see if any better solutions out there.

> 
> /
>     Leif
> 
> On Mon, Oct 28, 2019 at 09:59:17 +0800, Abner Chang wrote:
> > Add opensbi submodule.
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Gilbert Chen <gilbert.chen@hpe.com>
> > ---
> >  Readme.md | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Readme.md b/Readme.md
> > index 27e4ce0..4b3d2a5 100644
> > --- a/Readme.md
> > +++ b/Readme.md
> > @@ -148,6 +148,7 @@ as possible as we can. Currently EDK II contains
> > two submodules
> >
> >  - CryptoPkg/Library/OpensslLib/openssl
> >  - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> > +- RiscVPkg/Library/RiscVOpensbiLib/opensbi
> >
> >  The latter one is actually required by previous one. It's inevitable
> > in openssl-1.1.1 (since stable201905) for floating point parameter
> > --
> > 2.7.4
> >
> >
> > 
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51123): https://edk2.groups.io/g/devel/message/51123
Mute This Topic: https://groups.io/mt/38757610/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

The order of first 27 pacthes in "RISC-V-V2 PATCH v3" is identical to
"RISC-V-V2 PATCH v2", this is easier for reviewers to compare this set with v2.

This branch "RISC-V-V2" is used to contribute RISC-V architecture on EDK2.
The main changes of these series of patches are,
- Add RiscVPkg which conform with RISC-V Privilege Spec v1.10.
- Add RiscVPlatformPkg which provides common RISC-V library and driver modules
  for RISC-V platform.
- Incorporate and leverage RISC-V OpenSBI to provide EDK2 port OpenSBI library.
- Provide RISC-V platform implementation specific drivers to EDK2 RISC-V platform
  package.
- Provide generic RISC-V SMBIOS DXE drive to create SMBIOS type 4, 7 and 44 records,
  in which the SMBIOS type 44 record is introduced in SMBIOS spec 3.3.0.

Besides of patches, you can also get code from belwo git repositories.
- edk2-platforms/devel-riscv-v2-PATCHv5 for RISC-V platform,
  https://github.com/gilbert225/edk2-platforms/tree/devel-riscv-v2-PATCHv5
- edk2-staging-riscv/RISC-V-V2-v3  for RISC-V,
  https://github.com/changab/edk2-staging-riscv/tree/RISC-V-V2-v3

KNOWN ISSUES of this set of patches.
1. 0024-BaseTools-BaseTools-changes-for-RISC-V-platform
   * Line ending ('\n') is not CRLF
     File: BaseTools/Source/Python/Common/DataType.py
     Lines:   TAB_COMPILER_MSFT = 'MSFT'
   Not caused by chages of RISC-V edk2 port, will need a sperate patch to fix
   this issue.
2. 0027-RiscVPkg-RiscVOpensbLlib-Add-submodule-opensbi
   * Tab character used
   Not caused by chages of RISC-V edk2 port. Shall we fix this in .gitmodule?

   * Line ending ('\n') is not CRLF
     File: RiscVPkg/Library/RiscVOpensbiLib/opensbi
     Line: Subproject commit be92da280d87c38a2e0adc5d3f43bab7b5468f09
   Caused by submodle itself.
3. Some patches have subject is too long issue.

Abner Chang (38):
  RiscVPkg: RISC-V processor package.
  RiscVPkg/Include: Add header files of RISC-V CPU package
  RiscVPkg/opensbi: EDK2 RISC-V OpenSBI support
  MdePkg: RISC-V RV64 binding in MdePkg
  MdePkg/Include: RISC-V definitions.
  MdeModulePkg/CapsuleRuntimeDxe: Add RISCV64 arch.
  MdePkg/BaseLib: BaseLib for RISC-V RV64 Processor.
  MdePkg/BaseCacheMaintenanceLib:     RISC-V cache maintenance
    implementation.
  MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions.
  MdePkg/BasePeCoff: Add RISC-V PE/Coff related code.
  MdePkg/BaseCpuLib: RISC-V Base CPU library     implementation.
  MdePkg/BaseSynchronizationLib: RISC-V cache related code.
  MdeModulePkg/Logo
  NetworkPkg
  RiscVPkg/Library: RISC-V CPU library
  RiscVPkg/Library: Add RISC-V exception library
  RiscVPkg/Library: Add RISC-V timer library
  RiscVPkg/Library: Add EDK2 RISC-V OpenSBI library.
  RiscVPkg/Library: RISC-V platform level     DxeIPL libraries.
  MdeModulePkg/DxeIplPeim : RISC-V platform level DxeIPL
  RiscVPkg/PeiServicesTablePointerLibOpenSbi:     RISC-V PEI Service
    Table Pointer library
  RiscVPlatformPkg/RiscVPlatformTempMemoryInit:     RISC-V Platform
    Temporary Memory library
  RiscVPkg/CpuDxe: Add RISC-V CPU DXE driver.
  BaseTools: BaseTools changes for RISC-V platform.
  BaseTools/Scripts
  RiscVPkg/SmbiosDxe: Generic SMBIOS DXE driver     for RISC-V
    platforms.
  RiscVPkg/RiscVOpensbLlib: Add submodule opensbi
  RiscVPlatformPkg/FirmwareContextProcessorSpecificLib:Add
    FirmwareContextProcessorSpecificLib module
  RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib.
  RiscVPlatformPkg/OpensbiPlatformLibNull: NULL instance of
    RiscVOpensbiPlatformLib
  RiscVPlatformPkg/PlatformMemoryTestLibNull: NULL instance of
    PlatformMemoryTestLib
  RiscVPlatformPkg/PlatformUpdateProgressLibNull: NULL instance of
    PlatformUpdateProgressLib
  RiscVPlatformPkg/PlatformBootManagerLib: Platform Boot Manager
    library.
  RiscVPkg/RiscVPlatformTimerLibNull: NULL instance of RISC-V platform
    timer library.
  RiscVPlatformPkg: Add RiscVPlatformPkg
  edk2-staging:RISC-V-V2: Add RiscVEdk2Readme.md
  edk2-staging: Revise Maintainers.txt for RISC-V packages
  edk2-staging: Revise Readme.md

Anup Patel (1):
  RiscVPlatformPkg/SecMain: RISC-V SecMain module.

 MdePkg/MdePkg.dec                                  |   5 +-
 RiscVPkg/RiscVPkg.dec                              |  41 ++
 RiscVPlatformPkg/RiscVPlatformPkg.dec              |  72 +++
 NetworkPkg/Network.dsc.inc                         |   2 +-
 RiscVPkg/RiscVPkg.dsc                              |  92 ++++
 RiscVPlatformPkg/RiscVPlatformPkg.dsc              |  73 +++
 MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf            |  13 +-
 MdeModulePkg/Logo/Logo.inf                         |   2 +-
 .../CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf        |   9 +-
 .../BaseCacheMaintenanceLib.inf                    |   4 +
 MdePkg/Library/BaseCpuLib/BaseCpuLib.inf           |   6 +-
 .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf      |  12 +-
 MdePkg/Library/BaseLib/BaseLib.inf                 |  18 +-
 MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf     |   5 +
 .../BaseSynchronizationLib.inf                     |   5 +
 .../PeiServicesTablePointerLibOpenSbi.inf          |  38 ++
 RiscVPkg/Library/RiscVCpuLib/RiscVCpuLib.inf       |  34 ++
 .../RiscVDxeIplHandoffLib.inf                      |  32 ++
 .../RiscVDxeIplHandoffOpenSbiLib.inf               |  33 ++
 .../CpuExceptionHandlerDxeLib.inf                  |  43 ++
 .../Library/RiscVOpensbiLib/RiscVOpensbiLib.inf    |  53 ++
 .../RiscVPlatformTimerLib.inf                      |  35 ++
 .../Library/RiscVTimerLib/BaseRiscVTimerLib.inf    |  34 ++
 RiscVPkg/Universal/CpuDxe/CpuDxe.inf               |  48 ++
 RiscVPkg/Universal/SmbiosDxe/RiscVSmbiosDxe.inf    |  55 ++
 .../FirmwareContextProcessorSpecificLib.inf        |  31 ++
 .../OpensbiPlatformLibNull.inf                     |  38 ++
 .../PlatformBootManagerLib.inf                     |  61 +++
 .../PlatformMemoryTestLibNull.inf                  |  29 +
 .../PlatformUpdateProgressLibNull.inf              |  29 +
 .../RealTimeClockLibNull/RealTimeClockLibNull.inf  |  30 ++
 .../RiscVPlatformTempMemoryInitLibNull.inf         |  34 ++
 RiscVPlatformPkg/Universal/Sec/SecMain.inf         |  72 +++
 BaseTools/Source/C/Common/PeCoffLib.h              |   9 +
 BaseTools/Source/C/GenFw/elf_common.h              |  62 +++
 .../Source/C/Include/IndustryStandard/PeImage.h    |   6 +
 MdePkg/Include/IndustryStandard/PeImage.h          |  12 +
 MdePkg/Include/Library/BaseLib.h                   |  26 +
 MdePkg/Include/Protocol/DebugSupport.h             |  55 ++
 MdePkg/Include/Protocol/PxeBaseCode.h              |   4 +
 MdePkg/Include/RiscV64/ProcessorBind.h             | 173 ++++++
 MdePkg/Include/Uefi/UefiBaseType.h                 |  13 +
 MdePkg/Include/Uefi/UefiSpec.h                     |   5 +
 .../Library/BasePeCoffLib/BasePeCoffLibInternals.h |   9 +
 RiscVPkg/Include/IndustryStandard/RiscV.h          | 118 ++++
 RiscVPkg/Include/Library/RiscVCpuLib.h             |  68 +++
 RiscVPkg/Include/Library/RiscVPlatformDxeIpl.h     |  41 ++
 RiscVPkg/Include/ProcessorSpecificHobData.h        |  97 ++++
 RiscVPkg/Include/RiscVImpl.h                       |  72 +++
 RiscVPkg/Include/SmbiosProcessorSpecificData.h     |  57 ++
 RiscVPkg/Include/sbi/SbiFirmwareContext.h          |  33 ++
 RiscVPkg/Include/sbi/sbi.h                         |  52 ++
 RiscVPkg/Include/sbi/sbi_bits.h                    |  17 +
 RiscVPkg/Include/sbi/sbi_types.h                   |  45 ++
 .../RiscVExceptionLib/CpuExceptionHandlerLib.h     |  16 +
 RiscVPkg/Universal/CpuDxe/CpuDxe.h                 | 199 +++++++
 RiscVPkg/Universal/SmbiosDxe/RiscVSmbiosDxe.h      |  23 +
 .../Library/FirmwareContextProcessorSpecificLib.h  |  42 ++
 .../Library/RiscVPlatformTempMemoryInitLib.h       |  17 +
 .../PlatformBootManagerLib/PlatformBootManager.h   | 117 ++++
 RiscVPlatformPkg/Universal/Sec/SecMain.h           |  57 ++
 BaseTools/Source/C/Common/BasePeCoff.c             |  15 +-
 BaseTools/Source/C/Common/PeCoffLoaderEx.c         |  86 +++
 BaseTools/Source/C/GenFv/GenFvInternalLib.c        | 128 ++++-
 BaseTools/Source/C/GenFw/Elf32Convert.c            |   5 +-
 BaseTools/Source/C/GenFw/Elf64Convert.c            | 282 +++++++++-
 MdeModulePkg/Core/DxeIplPeim/RiscV64/DxeLoadFunc.c |  76 +++
 .../Library/BaseCacheMaintenanceLib/RiscVCache.c   | 250 +++++++++
 MdePkg/Library/BaseIoLibIntrinsic/IoLibArm.c       | 593 ---------------------
 MdePkg/Library/BaseIoLibIntrinsic/IoLibNoIo.c      | 593 +++++++++++++++++++++
 MdePkg/Library/BaseLib/RiscV64/CpuBreakpoint.c     |  27 +
 MdePkg/Library/BaseLib/RiscV64/CpuPause.c          |  29 +
 MdePkg/Library/BaseLib/RiscV64/DisableInterrupts.c |  24 +
 MdePkg/Library/BaseLib/RiscV64/EnableInterrupts.c  |  25 +
 MdePkg/Library/BaseLib/RiscV64/GetInterruptState.c |  35 ++
 .../Library/BaseLib/RiscV64/InternalSwitchStack.c  |  55 ++
 MdePkg/Library/BaseLib/RiscV64/LongJump.c          |  32 ++
 MdePkg/Library/BasePeCoffLib/BasePeCoff.c          |   3 +-
 .../Library/BasePeCoffLib/RiscV/PeCoffLoaderEx.c   | 133 +++++
 .../PeiServicesTablePointerOpenSbi.c               | 121 +++++
 .../RiscVDxeIplHandoffLib/RiscVDxeIplHandoffLib.c  |  41 ++
 .../RiscVDxeIplHandoffOpenSbiLib.c                 | 101 ++++
 .../RiscVExceptionLib/CpuExceptionHandlerLib.c     | 191 +++++++
 RiscVPkg/Library/RiscVTimerLib/RiscVTimerLib.c     | 199 +++++++
 RiscVPkg/Universal/CpuDxe/CpuDxe.c                 | 317 +++++++++++
 RiscVPkg/Universal/SmbiosDxe/RiscVSmbiosDxe.c      | 339 ++++++++++++
 .../FirmwareContextProcessorSpecificLib.c          |  94 ++++
 .../Library/OpensbiPlatformLibNull/Platform.c      |  44 ++
 .../PlatformBootManagerLib/PlatformBootManager.c   | 243 +++++++++
 .../Library/PlatformBootManagerLib/PlatformData.c  |  49 ++
 .../PlatformMemoryTestLibNull.c                    |  29 +
 .../PlatformUpdateProgressLibNull.c                |  52 ++
 .../RealTimeClockLibNull/RealTimeClockLibNull.c    | 204 +++++++
 RiscVPlatformPkg/Universal/Sec/SecMain.c           | 523 ++++++++++++++++++
 Readme.md                                          |   1 +
 RiscVEdk2Readme.md                                 |  64 +++
 RiscVPlatformPkg/Readme.md                         |  78 +++
 .gitmodules                                        |  15 +-
 BaseTools/Conf/build_rule.template                 |  54 +-
 BaseTools/Conf/tools_def.template                  |  64 ++-
 BaseTools/Scripts/GccBaseRiscV.lds                 |  79 +++
 BaseTools/Source/Python/Common/DataType.py         |   7 +-
 BaseTools/Source/Python/Common/buildoptions.py     |   6 +-
 Maintainers.txt                                    |  15 +
 MdePkg/Library/BaseCpuLib/BaseCpuLib.uni           |   5 +-
 MdePkg/Library/BaseCpuLib/RiscV/Cpu.S              |  19 +
 MdePkg/Library/BaseLib/RiscV64/FlushCache.S        |  21 +
 .../Library/BaseLib/RiscV64/RiscVCpuBreakpoint.S   |  14 +
 MdePkg/Library/BaseLib/RiscV64/RiscVCpuPause.S     |  14 +
 MdePkg/Library/BaseLib/RiscV64/RiscVInterrupt.S    |  32 ++
 .../Library/BaseLib/RiscV64/RiscVSetJumpLongJump.S |  55 ++
 MdePkg/Library/BasePeCoffLib/BasePeCoffLib.uni     |   2 +
 .../RiscV64/SynchronizationAsm.S                   |  78 +++
 .../PeiServicesTablePointerLibOpenSbi.uni          |  23 +
 RiscVPkg/Library/RiscVCpuLib/Cpu.S                 | 115 ++++
 .../RiscVExceptionLib/CpuExceptionHandlerLib.uni   |  13 +
 .../RiscVExceptionLib/SupervisorTrapHandler.S      |  88 +++
 RiscVPkg/Library/RiscVOpensbiLib/opensbi           |   1 +
 .../RiscVPlatformTimerLibNull.S                    |  40 ++
 RiscVPkg/RiscVPkg.uni                              |  13 +
 RiscVPkg/RiscVPkgExtra.uni                         |  13 +
 RiscVPkg/Universal/CpuDxe/CpuDxe.uni               |  13 +
 RiscVPkg/Universal/CpuDxe/CpuDxeExtra.uni          |  14 +
 RiscVPkg/Universal/SmbiosDxe/RiscVSmbiosDxe.uni    |  12 +
 .../Universal/SmbiosDxe/RiscVSmbiosDxeExtra.uni    |  13 +
 .../Library/PlatformBootManagerLib/Strings.uni     |  28 +
 .../Riscv64/TempMemInit.S                          |  26 +
 RiscVPlatformPkg/RiscVPlatformPkg.uni              |  15 +
 RiscVPlatformPkg/RiscVPlatformPkgExtra.uni         |  12 +
 RiscVPlatformPkg/Universal/Sec/Riscv64/SecEntry.S  | 442 +++++++++++++++
 130 files changed, 8320 insertions(+), 655 deletions(-)
 create mode 100644 RiscVPkg/RiscVPkg.dec
 create mode 100644 RiscVPlatformPkg/RiscVPlatformPkg.dec
 create mode 100644 RiscVPkg/RiscVPkg.dsc
 create mode 100644 RiscVPlatformPkg/RiscVPlatformPkg.dsc
 create mode 100644 RiscVPkg/Library/PeiServicesTablePointerLibOpenSbi/PeiServicesTablePointerLibOpenSbi.inf
 create mode 100644 RiscVPkg/Library/RiscVCpuLib/RiscVCpuLib.inf
 create mode 100644 RiscVPkg/Library/RiscVDxeIplHandoffLib/RiscVDxeIplHandoffLib.inf
 create mode 100644 RiscVPkg/Library/RiscVDxeIplHandoffOpenSbiLib/RiscVDxeIplHandoffOpenSbiLib.inf
 create mode 100644 RiscVPkg/Library/RiscVExceptionLib/CpuExceptionHandlerDxeLib.inf
 create mode 100644 RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf
 create mode 100644 RiscVPkg/Library/RiscVPlatformTimerLibNull/RiscVPlatformTimerLib.inf
 create mode 100644 RiscVPkg/Library/RiscVTimerLib/BaseRiscVTimerLib.inf
 create mode 100644 RiscVPkg/Universal/CpuDxe/CpuDxe.inf
 create mode 100644 RiscVPkg/Universal/SmbiosDxe/RiscVSmbiosDxe.inf
 create mode 100644 RiscVPlatformPkg/Library/FirmwareContextProcessorSpecificLib/FirmwareContextProcessorSpecificLib.inf
 create mode 100644 RiscVPlatformPkg/Library/OpensbiPlatformLibNull/OpensbiPlatformLibNull.inf
 create mode 100644 RiscVPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
 create mode 100644 RiscVPlatformPkg/Library/PlatformMemoryTestLibNull/PlatformMemoryTestLibNull.inf
 create mode 100644 RiscVPlatformPkg/Library/PlatformUpdateProgressLibNull/PlatformUpdateProgressLibNull.inf
 create mode 100644 RiscVPlatformPkg/Library/RealTimeClockLibNull/RealTimeClockLibNull.inf
 create mode 100644 RiscVPlatformPkg/Library/RiscVPlatformTempMemoryInitLibNull/RiscVPlatformTempMemoryInitLibNull.inf
 create mode 100644 RiscVPlatformPkg/Universal/Sec/SecMain.inf
 create mode 100644 MdePkg/Include/RiscV64/ProcessorBind.h
 create mode 100644 RiscVPkg/Include/IndustryStandard/RiscV.h
 create mode 100644 RiscVPkg/Include/Library/RiscVCpuLib.h
 create mode 100644 RiscVPkg/Include/Library/RiscVPlatformDxeIpl.h
 create mode 100644 RiscVPkg/Include/ProcessorSpecificHobData.h
 create mode 100644 RiscVPkg/Include/RiscVImpl.h
 create mode 100644 RiscVPkg/Include/SmbiosProcessorSpecificData.h
 create mode 100644 RiscVPkg/Include/sbi/SbiFirmwareContext.h
 create mode 100644 RiscVPkg/Include/sbi/sbi.h
 create mode 100644 RiscVPkg/Include/sbi/sbi_bits.h
 create mode 100644 RiscVPkg/Include/sbi/sbi_types.h
 create mode 100644 RiscVPkg/Library/RiscVExceptionLib/CpuExceptionHandlerLib.h
 create mode 100644 RiscVPkg/Universal/CpuDxe/CpuDxe.h
 create mode 100644 RiscVPkg/Universal/SmbiosDxe/RiscVSmbiosDxe.h
 create mode 100644 RiscVPlatformPkg/Include/Library/FirmwareContextProcessorSpecificLib.h
 create mode 100644 RiscVPlatformPkg/Include/Library/RiscVPlatformTempMemoryInitLib.h
 create mode 100644 RiscVPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.h
 create mode 100644 RiscVPlatformPkg/Universal/Sec/SecMain.h
 create mode 100644 MdeModulePkg/Core/DxeIplPeim/RiscV64/DxeLoadFunc.c
 create mode 100644 MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c
 delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibArm.c
 create mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibNoIo.c
 create mode 100644 MdePkg/Library/BaseLib/RiscV64/CpuBreakpoint.c
 create mode 100644 MdePkg/Library/BaseLib/RiscV64/CpuPause.c
 create mode 100644 MdePkg/Library/BaseLib/RiscV64/DisableInterrupts.c
 create mode 100644 MdePkg/Library/BaseLib/RiscV64/EnableInterrupts.c
 create mode 100644 MdePkg/Library/BaseLib/RiscV64/GetInterruptState.c
 create mode 100644 MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c
 create mode 100644 MdePkg/Library/BaseLib/RiscV64/LongJump.c
 create mode 100644 MdePkg/Library/BasePeCoffLib/RiscV/PeCoffLoaderEx.c
 create mode 100644 RiscVPkg/Library/PeiServicesTablePointerLibOpenSbi/PeiServicesTablePointerOpenSbi.c
 create mode 100644 RiscVPkg/Library/RiscVDxeIplHandoffLib/RiscVDxeIplHandoffLib.c
 create mode 100644 RiscVPkg/Library/RiscVDxeIplHandoffOpenSbiLib/RiscVDxeIplHandoffOpenSbiLib.c
 create mode 100644 RiscVPkg/Library/RiscVExceptionLib/CpuExceptionHandlerLib.c
 create mode 100644 RiscVPkg/Library/RiscVTimerLib/RiscVTimerLib.c
 create mode 100644 RiscVPkg/Universal/CpuDxe/CpuDxe.c
 create mode 100644 RiscVPkg/Universal/SmbiosDxe/RiscVSmbiosDxe.c
 create mode 100644 RiscVPlatformPkg/Library/FirmwareContextProcessorSpecificLib/FirmwareContextProcessorSpecificLib.c
 create mode 100644 RiscVPlatformPkg/Library/OpensbiPlatformLibNull/Platform.c
 create mode 100644 RiscVPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
 create mode 100644 RiscVPlatformPkg/Library/PlatformBootManagerLib/PlatformData.c
 create mode 100644 RiscVPlatformPkg/Library/PlatformMemoryTestLibNull/PlatformMemoryTestLibNull.c
 create mode 100644 RiscVPlatformPkg/Library/PlatformUpdateProgressLibNull/PlatformUpdateProgressLibNull.c
 create mode 100644 RiscVPlatformPkg/Library/RealTimeClockLibNull/RealTimeClockLibNull.c
 create mode 100644 RiscVPlatformPkg/Universal/Sec/SecMain.c
 create mode 100644 RiscVEdk2Readme.md
 create mode 100644 RiscVPlatformPkg/Readme.md
 create mode 100644 BaseTools/Scripts/GccBaseRiscV.lds
 create mode 100644 MdePkg/Library/BaseCpuLib/RiscV/Cpu.S
 create mode 100644 MdePkg/Library/BaseLib/RiscV64/FlushCache.S
 create mode 100644 MdePkg/Library/BaseLib/RiscV64/RiscVCpuBreakpoint.S
 create mode 100644 MdePkg/Library/BaseLib/RiscV64/RiscVCpuPause.S
 create mode 100644 MdePkg/Library/BaseLib/RiscV64/RiscVInterrupt.S
 create mode 100644 MdePkg/Library/BaseLib/RiscV64/RiscVSetJumpLongJump.S
 create mode 100644 MdePkg/Library/BaseSynchronizationLib/RiscV64/SynchronizationAsm.S
 create mode 100644 RiscVPkg/Library/PeiServicesTablePointerLibOpenSbi/PeiServicesTablePointerLibOpenSbi.uni
 create mode 100644 RiscVPkg/Library/RiscVCpuLib/Cpu.S
 create mode 100644 RiscVPkg/Library/RiscVExceptionLib/CpuExceptionHandlerLib.uni
 create mode 100644 RiscVPkg/Library/RiscVExceptionLib/SupervisorTrapHandler.S
 create mode 160000 RiscVPkg/Library/RiscVOpensbiLib/opensbi
 create mode 100644 RiscVPkg/Library/RiscVPlatformTimerLibNull/RiscVPlatformTimerLibNull.S
 create mode 100644 RiscVPkg/RiscVPkg.uni
 create mode 100644 RiscVPkg/RiscVPkgExtra.uni
 create mode 100644 RiscVPkg/Universal/CpuDxe/CpuDxe.uni
 create mode 100644 RiscVPkg/Universal/CpuDxe/CpuDxeExtra.uni
 create mode 100644 RiscVPkg/Universal/SmbiosDxe/RiscVSmbiosDxe.uni
 create mode 100644 RiscVPkg/Universal/SmbiosDxe/RiscVSmbiosDxeExtra.uni
 create mode 100644 RiscVPlatformPkg/Library/PlatformBootManagerLib/Strings.uni
 create mode 100644 RiscVPlatformPkg/Library/RiscVPlatformTempMemoryInitLibNull/Riscv64/TempMemInit.S
 create mode 100644 RiscVPlatformPkg/RiscVPlatformPkg.uni
 create mode 100644 RiscVPlatformPkg/RiscVPlatformPkgExtra.uni
 create mode 100644 RiscVPlatformPkg/Universal/Sec/Riscv64/SecEntry.S

--
2.7.4


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49483): https://edk2.groups.io/g/devel/message/49483
Mute This Topic: https://groups.io/mt/38757501/1772629
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub   [abner.chang@hpe.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md
Posted by Leif Lindholm 6 years ago
On Fri, Nov 22, 2019 at 02:05:30 +0000, Abner Chang wrote:
> Palmer removed.
> 
> > -----Original Message-----
> > From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> > Sent: Friday, November 22, 2019 1:15 AM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang@hpe.com>
> > Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>;
> > Michael D Kinney <michael.d.kinney@intel.com>; Chen, Gilbert
> > <gilbert.chen@hpe.com>; Palmer Dabbelt <palmer@sifive.com>
> > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-
> > staging: Revise Readme.md
> > 
> > Well, there's no 0/39 for me to give a generic comment on (please use a
> > cover-letter).
>
> There is a cover letter sent with this set of patches, you probably
> missed it. attached here in case you would like to give comments
> there.

Ah, having the original made it possible for me to find it in gmail.
I think you forgot to cc me on the cover letter(s - the same for the
edk2-platforms one), while I was Cc:d on each of the individual
patches.

(I can find the edk2-platforms one as well now.)

/
    Leif

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51177): https://edk2.groups.io/g/devel/message/51177
Mute This Topic: https://groups.io/mt/38757610/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md
Posted by Abner Chang 6 years ago
Oops. You are right. Just forward that email to all in CCed.

-----Original Message-----
From: Leif Lindholm [mailto:leif.lindholm@linaro.org] 
Sent: Friday, November 22, 2019 5:43 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Michael D Kinney <michael.d.kinney@intel.com>; Chen, Gilbert <gilbert.chen@hpe.com>
Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md

On Fri, Nov 22, 2019 at 02:05:30 +0000, Abner Chang wrote:
> Palmer removed.
> 
> > -----Original Message-----
> > From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> > Sent: Friday, November 22, 2019 1:15 AM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) 
> > <abner.chang@hpe.com>
> > Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; 
> > Michael D Kinney <michael.d.kinney@intel.com>; Chen, Gilbert 
> > <gilbert.chen@hpe.com>; Palmer Dabbelt <palmer@sifive.com>
> > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] 
> > edk2-
> > staging: Revise Readme.md
> > 
> > Well, there's no 0/39 for me to give a generic comment on (please 
> > use a cover-letter).
>
> There is a cover letter sent with this set of patches, you probably 
> missed it. attached here in case you would like to give comments 
> there.

Ah, having the original made it possible for me to find it in gmail.
I think you forgot to cc me on the cover letter(s - the same for the edk2-platforms one), while I was Cc:d on each of the individual patches.

(I can find the edk2-platforms one as well now.)

/
    Leif

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51186): https://edk2.groups.io/g/devel/message/51186
Mute This Topic: https://groups.io/mt/38757610/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-