1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section

Liming Gao posted 1 patch 4 years, 6 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
Maintainers.txt | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
[edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
Posted by Liming Gao 4 years, 6 months ago 
ShellBinPkg is generated for each edk2 stable tag release.

Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 Maintainers.txt | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index f348d70df3..f75b35d5a8 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -82,6 +82,12 @@ EDK II Releases:
 W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning
 M: Liming Gao <liming.gao@intel.com>
 
+W: https://github.com/tianocore/edk2/releases/download/edk2-stable20XXXX/ShellBinPkg.zip
+M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
+M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
+M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
+M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
+
 EDK II Architectures:
 ---------------------
 ARM, AARCH64
@@ -421,13 +427,6 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
 M: Ray Ni <ray.ni@intel.com>
 M: Zhichao Gao <zhichao.gao@intel.com>
 
-Maintainers for stable Shell binaries generation
-when need to publish Shell binaries with edk2 release:
-M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
-M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
-M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
-M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
-
 SignedCapsulePkg
 F: SignedCapsulePkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
-- 
2.13.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47885): https://edk2.groups.io/g/devel/message/47885
Mute This Topic: https://groups.io/mt/34271643/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
Posted by Philippe Mathieu-Daudé 4 years, 6 months ago 
Hi Liming,

On 9/24/19 3:19 AM, Liming Gao wrote:
> ShellBinPkg is generated for each edk2 stable tag release.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  Maintainers.txt | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index f348d70df3..f75b35d5a8 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -82,6 +82,12 @@ EDK II Releases:
>  W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning
>  M: Liming Gao <liming.gao@intel.com>
>  

Shouldn't you keep the F: tag too? Maybe:

 ShellPkg
 (stable)
 F: ShellPkg/


> +W: https://github.com/tianocore/edk2/releases/download/edk2-stable20XXXX/ShellBinPkg.zip
> +M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
> +M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
> +M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
> +M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
> +
>  EDK II Architectures:
>  ---------------------
>  ARM, AARCH64
> @@ -421,13 +427,6 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
>  M: Ray Ni <ray.ni@intel.com>
>  M: Zhichao Gao <zhichao.gao@intel.com>
>  
> -Maintainers for stable Shell binaries generation
> -when need to publish Shell binaries with edk2 release:
> -M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
> -M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
> -M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
> -M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
> -
>  SignedCapsulePkg
>  F: SignedCapsulePkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47916): https://edk2.groups.io/g/devel/message/47916
Mute This Topic: https://groups.io/mt/34271643/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
Posted by Laszlo Ersek 4 years, 6 months ago 
On 09/24/19 12:41, Philippe Mathieu-Daudé wrote:
> Hi Liming,
> 
> On 9/24/19 3:19 AM, Liming Gao wrote:
>> ShellBinPkg is generated for each edk2 stable tag release.
>>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Signed-off-by: Liming Gao <liming.gao@intel.com>
>> ---
>>  Maintainers.txt | 13 ++++++-------
>>  1 file changed, 6 insertions(+), 7 deletions(-)
>>
>> diff --git a/Maintainers.txt b/Maintainers.txt
>> index f348d70df3..f75b35d5a8 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -82,6 +82,12 @@ EDK II Releases:
>>  W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning
>>  M: Liming Gao <liming.gao@intel.com>
>>  
> 
> Shouldn't you keep the F: tag too? Maybe:
> 
>  ShellPkg
>  (stable)
>  F: ShellPkg/

I think we should keep "F:" only if the related "M:" entries work as
expected, with the "BaseTools/Scripts/GetMaintainer.py" script.

(I haven't checked.)

Thanks
Laszlo

> 
> 
>> +W: https://github.com/tianocore/edk2/releases/download/edk2-stable20XXXX/ShellBinPkg.zip
>> +M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
>> +M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
>> +M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
>> +M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
>> +
>>  EDK II Architectures:
>>  ---------------------
>>  ARM, AARCH64
>> @@ -421,13 +427,6 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
>>  M: Ray Ni <ray.ni@intel.com>
>>  M: Zhichao Gao <zhichao.gao@intel.com>
>>  
>> -Maintainers for stable Shell binaries generation
>> -when need to publish Shell binaries with edk2 release:
>> -M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
>> -M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
>> -M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
>> -M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
>> -
>>  SignedCapsulePkg
>>  F: SignedCapsulePkg/
>>  W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47968): https://edk2.groups.io/g/devel/message/47968
Mute This Topic: https://groups.io/mt/34271643/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
Posted by Liming Gao 4 years, 6 months ago 
Philipe:

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Philippe Mathieu-Daudé
> Sent: Tuesday, September 24, 2019 6:41 PM
> To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
> 
> Hi Liming,
> 
> On 9/24/19 3:19 AM, Liming Gao wrote:
> > ShellBinPkg is generated for each edk2 stable tag release.
> >
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > ---
> >  Maintainers.txt | 13 ++++++-------
> >  1 file changed, 6 insertions(+), 7 deletions(-)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt
> > index f348d70df3..f75b35d5a8 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -82,6 +82,12 @@ EDK II Releases:
> >  W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning
> >  M: Liming Gao <liming.gao@intel.com>
> >
> 
> Shouldn't you keep the F: tag too? Maybe:
> 
>  ShellPkg
>  (stable)
>  F: ShellPkg/
> 
ShellBinPkg doesn't exist in Edk2 repo. It will be generated for stable tag release. 
Base on previous discussion, I list it into EDK II Releases section. 

Thanks
Liming
> 
> > +W: https://github.com/tianocore/edk2/releases/download/edk2-stable20XXXX/ShellBinPkg.zip
> > +M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
> > +M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
> > +M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
> > +M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
> > +
> >  EDK II Architectures:
> >  ---------------------
> >  ARM, AARCH64
> > @@ -421,13 +427,6 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
> >  M: Ray Ni <ray.ni@intel.com>
> >  M: Zhichao Gao <zhichao.gao@intel.com>
> >
> > -Maintainers for stable Shell binaries generation
> > -when need to publish Shell binaries with edk2 release:
> > -M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
> > -M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
> > -M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
> > -M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
> > -
> >  SignedCapsulePkg
> >  F: SignedCapsulePkg/
> >  W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
> >
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47959): https://edk2.groups.io/g/devel/message/47959
Mute This Topic: https://groups.io/mt/34271643/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
Posted by Philippe Mathieu-Daudé 4 years, 6 months ago 
On 9/24/19 5:08 PM, Gao, Liming wrote:
> Philipe:
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Philippe Mathieu-Daudé
>> Sent: Tuesday, September 24, 2019 6:41 PM
>> To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
>>
>> Hi Liming,
>>
>> On 9/24/19 3:19 AM, Liming Gao wrote:
>>> ShellBinPkg is generated for each edk2 stable tag release.
>>>
>>> Cc: Andrew Fish <afish@apple.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Signed-off-by: Liming Gao <liming.gao@intel.com>
>>> ---
>>>  Maintainers.txt | 13 ++++++-------
>>>  1 file changed, 6 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/Maintainers.txt b/Maintainers.txt
>>> index f348d70df3..f75b35d5a8 100644
>>> --- a/Maintainers.txt
>>> +++ b/Maintainers.txt
>>> @@ -82,6 +82,12 @@ EDK II Releases:
>>>  W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning
>>>  M: Liming Gao <liming.gao@intel.com>
>>>
>>
>> Shouldn't you keep the F: tag too? Maybe:
>>
>>  ShellPkg
>>  (stable)
>>  F: ShellPkg/
>>
> ShellBinPkg doesn't exist in Edk2 repo. It will be generated for stable tag release. 
> Base on previous discussion, I list it into EDK II Releases section. 

I should have written "F: ShellBinPkg/", I was thinking someone run this
command in tarball extracted from stable:

./BaseTools/Scripts/GetMaintainer.py ShellBinPkg/...

> 
> Thanks
> Liming
>>
>>> +W: https://github.com/tianocore/edk2/releases/download/edk2-stable20XXXX/ShellBinPkg.zip
>>> +M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
>>> +M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
>>> +M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
>>> +M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
>>> +
>>>  EDK II Architectures:
>>>  ---------------------
>>>  ARM, AARCH64
>>> @@ -421,13 +427,6 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
>>>  M: Ray Ni <ray.ni@intel.com>
>>>  M: Zhichao Gao <zhichao.gao@intel.com>
>>>
>>> -Maintainers for stable Shell binaries generation
>>> -when need to publish Shell binaries with edk2 release:
>>> -M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
>>> -M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
>>> -M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
>>> -M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
>>> -
>>>  SignedCapsulePkg
>>>  F: SignedCapsulePkg/
>>>  W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
>>>
>>
>> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47960): https://edk2.groups.io/g/devel/message/47960
Mute This Topic: https://groups.io/mt/34271643/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
Posted by Liming Gao 4 years, 6 months ago 

> -----Original Message-----
> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> Sent: Tuesday, September 24, 2019 11:13 PM
> To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
> 
> On 9/24/19 5:08 PM, Gao, Liming wrote:
> > Philipe:
> >
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Philippe Mathieu-Daudé
> >> Sent: Tuesday, September 24, 2019 6:41 PM
> >> To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>
> >> Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> >> Subject: Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
> >>
> >> Hi Liming,
> >>
> >> On 9/24/19 3:19 AM, Liming Gao wrote:
> >>> ShellBinPkg is generated for each edk2 stable tag release.
> >>>
> >>> Cc: Andrew Fish <afish@apple.com>
> >>> Cc: Laszlo Ersek <lersek@redhat.com>
> >>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> >>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >>> Signed-off-by: Liming Gao <liming.gao@intel.com>
> >>> ---
> >>>  Maintainers.txt | 13 ++++++-------
> >>>  1 file changed, 6 insertions(+), 7 deletions(-)
> >>>
> >>> diff --git a/Maintainers.txt b/Maintainers.txt
> >>> index f348d70df3..f75b35d5a8 100644
> >>> --- a/Maintainers.txt
> >>> +++ b/Maintainers.txt
> >>> @@ -82,6 +82,12 @@ EDK II Releases:
> >>>  W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning
> >>>  M: Liming Gao <liming.gao@intel.com>
> >>>
> >>
> >> Shouldn't you keep the F: tag too? Maybe:
> >>
> >>  ShellPkg
> >>  (stable)
> >>  F: ShellPkg/
> >>
> > ShellBinPkg doesn't exist in Edk2 repo. It will be generated for stable tag release.
> > Base on previous discussion, I list it into EDK II Releases section.
> 
> I should have written "F: ShellBinPkg/", I was thinking someone run this
> command in tarball extracted from stable:
> 
> ./BaseTools/Scripts/GetMaintainer.py ShellBinPkg/...

GetMaintainer.py bases on git commit. But, there is no git commit for ShellBinPkg. 
So, the above command doesn't work. 

Thanks
Liming
> 
> >
> > Thanks
> > Liming
> >>
> >>> +W: https://github.com/tianocore/edk2/releases/download/edk2-stable20XXXX/ShellBinPkg.zip
> >>> +M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
> >>> +M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
> >>> +M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
> >>> +M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
> >>> +
> >>>  EDK II Architectures:
> >>>  ---------------------
> >>>  ARM, AARCH64
> >>> @@ -421,13 +427,6 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
> >>>  M: Ray Ni <ray.ni@intel.com>
> >>>  M: Zhichao Gao <zhichao.gao@intel.com>
> >>>
> >>> -Maintainers for stable Shell binaries generation
> >>> -when need to publish Shell binaries with edk2 release:
> >>> -M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
> >>> -M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
> >>> -M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
> >>> -M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
> >>> -
> >>>  SignedCapsulePkg
> >>>  F: SignedCapsulePkg/
> >>>  W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
> >>>
> >>
> >> 
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47961): https://edk2.groups.io/g/devel/message/47961
Mute This Topic: https://groups.io/mt/34271643/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
Posted by Philippe Mathieu-Daudé 4 years, 6 months ago 
On 9/24/19 5:17 PM, Gao, Liming wrote:
>> -----Original Message-----
>> From: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Sent: Tuesday, September 24, 2019 11:13 PM
>> To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
>>
>> On 9/24/19 5:08 PM, Gao, Liming wrote:
>>> Philipe:
>>>
>>>> -----Original Message-----
>>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Philippe Mathieu-Daudé
>>>> Sent: Tuesday, September 24, 2019 6:41 PM
>>>> To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>
>>>> Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
>>>> Subject: Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
>>>>
>>>> Hi Liming,
>>>>
>>>> On 9/24/19 3:19 AM, Liming Gao wrote:
>>>>> ShellBinPkg is generated for each edk2 stable tag release.
>>>>>
>>>>> Cc: Andrew Fish <afish@apple.com>
>>>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>>>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>>>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>>>> Signed-off-by: Liming Gao <liming.gao@intel.com>
>>>>> ---
>>>>>  Maintainers.txt | 13 ++++++-------
>>>>>  1 file changed, 6 insertions(+), 7 deletions(-)
>>>>>
>>>>> diff --git a/Maintainers.txt b/Maintainers.txt
>>>>> index f348d70df3..f75b35d5a8 100644
>>>>> --- a/Maintainers.txt
>>>>> +++ b/Maintainers.txt
>>>>> @@ -82,6 +82,12 @@ EDK II Releases:
>>>>>  W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning
>>>>>  M: Liming Gao <liming.gao@intel.com>
>>>>>
>>>>
>>>> Shouldn't you keep the F: tag too? Maybe:
>>>>
>>>>  ShellPkg
>>>>  (stable)
>>>>  F: ShellPkg/
>>>>
>>> ShellBinPkg doesn't exist in Edk2 repo. It will be generated for stable tag release.
>>> Base on previous discussion, I list it into EDK II Releases section.
>>
>> I should have written "F: ShellBinPkg/", I was thinking someone run this
>> command in tarball extracted from stable:
>>
>> ./BaseTools/Scripts/GetMaintainer.py ShellBinPkg/...
> 
> GetMaintainer.py bases on git commit. But, there is no git commit for ShellBinPkg. 
> So, the above command doesn't work. 

OK, thanks for clarifying!

> 
> Thanks
> Liming
>>
>>>
>>> Thanks
>>> Liming
>>>>
>>>>> +W: https://github.com/tianocore/edk2/releases/download/edk2-stable20XXXX/ShellBinPkg.zip
>>>>> +M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
>>>>> +M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
>>>>> +M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
>>>>> +M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
>>>>> +
>>>>>  EDK II Architectures:
>>>>>  ---------------------
>>>>>  ARM, AARCH64
>>>>> @@ -421,13 +427,6 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
>>>>>  M: Ray Ni <ray.ni@intel.com>
>>>>>  M: Zhichao Gao <zhichao.gao@intel.com>
>>>>>
>>>>> -Maintainers for stable Shell binaries generation
>>>>> -when need to publish Shell binaries with edk2 release:
>>>>> -M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
>>>>> -M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
>>>>> -M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
>>>>> -M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
>>>>> -
>>>>>  SignedCapsulePkg
>>>>>  F: SignedCapsulePkg/
>>>>>  W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
>>>>>
>>>>
>>>> 
>>>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47962): https://edk2.groups.io/g/devel/message/47962
Mute This Topic: https://groups.io/mt/34271643/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
Posted by Laszlo Ersek 4 years, 6 months ago 
Hi Liming,

On 09/24/19 03:19, Liming Gao wrote:
> ShellBinPkg is generated for each edk2 stable tag release.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  Maintainers.txt | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index f348d70df3..f75b35d5a8 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -82,6 +82,12 @@ EDK II Releases:
>  W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning
>  M: Liming Gao <liming.gao@intel.com>
>  
> +W: https://github.com/tianocore/edk2/releases/download/edk2-stable20XXXX/ShellBinPkg.zip

I'm not a fan of this link. It contains "XXXX", therefore it cannot work
with a simple click (or copy & paste). And it's not easy to notice the
"XXXX" part, and to substitute a valid stable tag identifier for it.

All the links we provide should work without manual tweaking, in my
opinion. They might not provide an immediately downloadable file (which
is fine with me), but they should not result in a 404.

How about the following:

UEFI Shell Binaries (ShellBinPkg.zip) from EDK II Releases:
-----------------------------------------------------------
W: https://github.com/tianocore/edk2/releases/
M: ...
M: ...
M: ...
M: ...

This allows users to go to the releases page, and search that page for
"ShellBinPkg.zip".

For me, the "Assets" block of the latest release is open immediately,
upon loading the page, and so searching the page for "ShellBinPkg.zip"
provides a hit at once. If a user wants an older build, they can locate
the Assets blocks under older releases, and look for "ShellBinPkg.zip"
there.

Thanks
Laszlo

> +M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
> +M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
> +M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
> +M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
> +
>  EDK II Architectures:
>  ---------------------
>  ARM, AARCH64
> @@ -421,13 +427,6 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
>  M: Ray Ni <ray.ni@intel.com>
>  M: Zhichao Gao <zhichao.gao@intel.com>
>  
> -Maintainers for stable Shell binaries generation
> -when need to publish Shell binaries with edk2 release:
> -M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
> -M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
> -M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
> -M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
> -
>  SignedCapsulePkg
>  F: SignedCapsulePkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47971): https://edk2.groups.io/g/devel/message/47971
Mute This Topic: https://groups.io/mt/34271643/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
Posted by Liming Gao 4 years, 6 months ago 
Laszlo:

>-----Original Message-----
>From: Laszlo Ersek [mailto:lersek@redhat.com]
>Sent: Wednesday, September 25, 2019 1:27 AM
>To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
>Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <leif.lindholm@linaro.org>;
>Kinney, Michael D <michael.d.kinney@intel.com>
>Subject: Re: [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II
>Releases section
>
>Hi Liming,
>
>On 09/24/19 03:19, Liming Gao wrote:
>> ShellBinPkg is generated for each edk2 stable tag release.
>>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Signed-off-by: Liming Gao <liming.gao@intel.com>
>> ---
>>  Maintainers.txt | 13 ++++++-------
>>  1 file changed, 6 insertions(+), 7 deletions(-)
>>
>> diff --git a/Maintainers.txt b/Maintainers.txt
>> index f348d70df3..f75b35d5a8 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -82,6 +82,12 @@ EDK II Releases:
>>  W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-
>Planning
>>  M: Liming Gao <liming.gao@intel.com>
>>
>> +W: https://github.com/tianocore/edk2/releases/download/edk2-
>stable20XXXX/ShellBinPkg.zip
>
>I'm not a fan of this link. It contains "XXXX", therefore it cannot work
>with a simple click (or copy & paste). And it's not easy to notice the
>"XXXX" part, and to substitute a valid stable tag identifier for it.
>
>All the links we provide should work without manual tweaking, in my
>opinion. They might not provide an immediately downloadable file (which
>is fine with me), but they should not result in a 404.
>
>How about the following:
>
>UEFI Shell Binaries (ShellBinPkg.zip) from EDK II Releases:
>-----------------------------------------------------------
>W: https://github.com/tianocore/edk2/releases/
>M: ...
>M: ...
>M: ...
>M: ...
>

Good suggestion. I will use this style. 

Thanks
Liming

>This allows users to go to the releases page, and search that page for
>"ShellBinPkg.zip".
>
>For me, the "Assets" block of the latest release is open immediately,
>upon loading the page, and so searching the page for "ShellBinPkg.zip"
>provides a hit at once. If a user wants an older build, they can locate
>the Assets blocks under older releases, and look for "ShellBinPkg.zip"
>there.
>
>Thanks
>Laszlo
>
>> +M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
>> +M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
>> +M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
>> +M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
>> +
>>  EDK II Architectures:
>>  ---------------------
>>  ARM, AARCH64
>> @@ -421,13 +427,6 @@ W:
>https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
>>  M: Ray Ni <ray.ni@intel.com>
>>  M: Zhichao Gao <zhichao.gao@intel.com>
>>
>> -Maintainers for stable Shell binaries generation
>> -when need to publish Shell binaries with edk2 release:
>> -M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
>> -M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
>> -M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
>> -M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
>> -
>>  SignedCapsulePkg
>>  F: SignedCapsulePkg/
>>  W:
>https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48001): https://edk2.groups.io/g/devel/message/48001
Mute This Topic: https://groups.io/mt/34271643/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.