[edk2-devel] [edk2-platforms: PATCH v2 07/10] Marvell/Library: IcuLib: Fix debug information

Marcin Wojtas posted 10 patches 6 years, 5 months ago
There is a newer version of this series
[edk2-devel] [edk2-platforms: PATCH v2 07/10] Marvell/Library: IcuLib: Fix debug information
Posted by Marcin Wojtas 6 years, 5 months ago
In case the number of CP11x components exceeded the maximum
of currently supported, the user is informed with the information.
It turned out that the print arguments were incorrect - fix it.

Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
 Silicon/Marvell/Library/IcuLib/IcuLib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Silicon/Marvell/Library/IcuLib/IcuLib.c b/Silicon/Marvell/Library/IcuLib/IcuLib.c
index 422388c..8d99409 100644
--- a/Silicon/Marvell/Library/IcuLib/IcuLib.c
+++ b/Silicon/Marvell/Library/IcuLib/IcuLib.c
@@ -285,8 +285,8 @@ ArmadaIcuInitialize (
   if (CpCount > ICU_MAX_SUPPORTED_UNITS) {
     DEBUG ((DEBUG_ERROR,
       "%a: Default ICU to GIC mapping is available for maximum %d CP110 units",
-      ICU_MAX_SUPPORTED_UNITS,
-      __FUNCTION__));
+      __FUNCTION__,
+      ICU_MAX_SUPPORTED_UNITS));
     CpCount = ICU_MAX_SUPPORTED_UNITS;
   }
 
-- 
2.7.4


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45670): https://edk2.groups.io/g/devel/message/45670
Mute This Topic: https://groups.io/mt/32882740/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH v2 07/10] Marvell/Library: IcuLib: Fix debug information
Posted by Leif Lindholm 6 years, 5 months ago
On Thu, Aug 15, 2019 at 04:54:11AM +0200, Marcin Wojtas wrote:
> In case the number of CP11x components exceeded the maximum
> of currently supported, the user is informed with the information.
> It turned out that the print arguments were incorrect - fix it.

Whoops.

> Signed-off-by: Marcin Wojtas <mw@semihalf.com>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  Silicon/Marvell/Library/IcuLib/IcuLib.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Silicon/Marvell/Library/IcuLib/IcuLib.c b/Silicon/Marvell/Library/IcuLib/IcuLib.c
> index 422388c..8d99409 100644
> --- a/Silicon/Marvell/Library/IcuLib/IcuLib.c
> +++ b/Silicon/Marvell/Library/IcuLib/IcuLib.c
> @@ -285,8 +285,8 @@ ArmadaIcuInitialize (
>    if (CpCount > ICU_MAX_SUPPORTED_UNITS) {
>      DEBUG ((DEBUG_ERROR,
>        "%a: Default ICU to GIC mapping is available for maximum %d CP110 units",
> -      ICU_MAX_SUPPORTED_UNITS,
> -      __FUNCTION__));
> +      __FUNCTION__,
> +      ICU_MAX_SUPPORTED_UNITS));
>      CpCount = ICU_MAX_SUPPORTED_UNITS;
>    }
>  
> -- 
> 2.7.4
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45841): https://edk2.groups.io/g/devel/message/45841
Mute This Topic: https://groups.io/mt/32882740/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-