[v1] Armada 7k8k network improvements

[edk2-devel] [edk2-platforms: PATCH 0/4] Armada 7k8k network improvements

Posted by Marcin Wojtas 4 years, 11 months ago

Hi,

This small patchset extends PP2 NIC driver with the basic
AdapterInformationProtocol support and adds 88E1112 PHY support.
Also a minor fix is included on top.

The patches are available in the github:
https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/net-upstream-r20190503

I'm looking forward to your comments or remarks.

Best regards,
Marcin

Marcin Wojtas (3):
  Marvell/Drivers: MvPhyDxe: Improve 88E1510 initialization
  Marvell/Drivers: MvPhyDxe: Introduce 88E1112 initialization
  Marvell/Drivers: MvPhyDxe: Reset PHY only once

Tomasz Michalec (1):
  Marvel/Drivers: Pp2Dxe: Basic support for Adapter Information Protocol

 Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf   |   1 +
 Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.h |  17 ++-
 Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.h     |   3 +
 Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 111 ++++++++++----
 Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c     | 157 ++++++++++++++++++++
 Silicon/Marvell/Documentation/PortingGuide.txt  |   7 +-
 6 files changed, 265 insertions(+), 31 deletions(-)

-- 
2.7.4


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39928): https://edk2.groups.io/g/devel/message/39928
Mute This Topic: https://groups.io/mt/31476849/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH 0/4] Armada 7k8k network improvements

Posted by Ard Biesheuvel 4 years, 11 months ago

On Fri, 3 May 2019 at 01:50, Marcin Wojtas <mw@semihalf.com> wrote:
>
> Hi,
>
> This small patchset extends PP2 NIC driver with the basic
> AdapterInformationProtocol support and adds 88E1112 PHY support.
> Also a minor fix is included on top.
>
> The patches are available in the github:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/net-upstream-r20190503
>
> I'm looking forward to your comments or remarks.
>
> Best regards,
> Marcin
>
> Marcin Wojtas (3):
>   Marvell/Drivers: MvPhyDxe: Improve 88E1510 initialization
>   Marvell/Drivers: MvPhyDxe: Introduce 88E1112 initialization
>   Marvell/Drivers: MvPhyDxe: Reset PHY only once
>
> Tomasz Michalec (1):
>   Marvel/Drivers: Pp2Dxe: Basic support for Adapter Information Protocol
>

Patches 1 and 2 need some work, 3 and 4 look fine.

After this series, I am not taking any more Armada7k8k patches until
we get the long promised PCIe support :-)

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39944): https://edk2.groups.io/g/devel/message/39944
Mute This Topic: https://groups.io/mt/31476849/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH 0/4] Armada 7k8k network improvements

Posted by Marcin Wojtas 4 years, 11 months ago

pt., 3 maj 2019 o 08:37 Ard Biesheuvel <ard.biesheuvel@linaro.org> napisał(a):
>
> On Fri, 3 May 2019 at 01:50, Marcin Wojtas <mw@semihalf.com> wrote:
> >
> > Hi,
> >
> > This small patchset extends PP2 NIC driver with the basic
> > AdapterInformationProtocol support and adds 88E1112 PHY support.
> > Also a minor fix is included on top.
> >
> > The patches are available in the github:
> > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/net-upstream-r20190503
> >
> > I'm looking forward to your comments or remarks.
> >
> > Best regards,
> > Marcin
> >
> > Marcin Wojtas (3):
> >   Marvell/Drivers: MvPhyDxe: Improve 88E1510 initialization
> >   Marvell/Drivers: MvPhyDxe: Introduce 88E1112 initialization
> >   Marvell/Drivers: MvPhyDxe: Reset PHY only once
> >
> > Tomasz Michalec (1):
> >   Marvel/Drivers: Pp2Dxe: Basic support for Adapter Information Protocol
> >
>
> Patches 1 and 2 need some work, 3 and 4 look fine.
>
> After this series, I am not taking any more Armada7k8k patches until
> we get the long promised PCIe support :-)

Understood and agree :)

Thanks!
Marcin

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39946): https://edk2.groups.io/g/devel/message/39946
Mute This Topic: https://groups.io/mt/31476849/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH 0/4] Armada 7k8k network improvements

Posted by Leif Lindholm 4 years, 11 months ago

On Fri, May 03, 2019 at 01:50:12AM +0200, Marcin Wojtas wrote:
> Hi,
> 
> This small patchset extends PP2 NIC driver with the basic
> AdapterInformationProtocol support and adds 88E1112 PHY support.
> Also a minor fix is included on top.
> 
> The patches are available in the github:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/net-upstream-r20190503
> 
> I'm looking forward to your comments or remarks.

For v2, please add a comment to 0/4 on what user(or
developer)-observable effect this has on existing edk2-platforms
... platforms.

No comments (beyond Ard's) on the actual patches.

Best Regards,

Leif

> Best regards,
> Marcin
> 
> Marcin Wojtas (3):
>   Marvell/Drivers: MvPhyDxe: Improve 88E1510 initialization
>   Marvell/Drivers: MvPhyDxe: Introduce 88E1112 initialization
>   Marvell/Drivers: MvPhyDxe: Reset PHY only once
> 
> Tomasz Michalec (1):
>   Marvel/Drivers: Pp2Dxe: Basic support for Adapter Information Protocol
> 
>  Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf   |   1 +
>  Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.h |  17 ++-
>  Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.h     |   3 +
>  Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 111 ++++++++++----
>  Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c     | 157 ++++++++++++++++++++
>  Silicon/Marvell/Documentation/PortingGuide.txt  |   7 +-
>  6 files changed, 265 insertions(+), 31 deletions(-)
> 
> -- 
> 2.7.4
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39947): https://edk2.groups.io/g/devel/message/39947
Mute This Topic: https://groups.io/mt/31476849/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH 0/4] Armada 7k8k network improvements

Posted by Marcin Wojtas 4 years, 11 months ago

Hi Leif,

pt., 3 maj 2019 o 09:36 Leif Lindholm <leif.lindholm@linaro.org> napisał(a):
>
> On Fri, May 03, 2019 at 01:50:12AM +0200, Marcin Wojtas wrote:
> > Hi,
> >
> > This small patchset extends PP2 NIC driver with the basic
> > AdapterInformationProtocol support and adds 88E1112 PHY support.
> > Also a minor fix is included on top.
> >
> > The patches are available in the github:
> > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/net-upstream-r20190503
> >
> > I'm looking forward to your comments or remarks.
>
> For v2, please add a comment to 0/4 on what user(or
> developer)-observable effect this has on existing edk2-platforms
> ... platforms.
>

Not sure I get it - do you want me to describe a change between v1 and
v2 or explanation, why I submit these patches at all? Or something
else?

Best regards,
Marcin

> No comments (beyond Ard's) on the actual patches.
>
> Best Regards,
>
> Leif
>
> > Best regards,
> > Marcin
> >
> > Marcin Wojtas (3):
> >   Marvell/Drivers: MvPhyDxe: Improve 88E1510 initialization
> >   Marvell/Drivers: MvPhyDxe: Introduce 88E1112 initialization
> >   Marvell/Drivers: MvPhyDxe: Reset PHY only once
> >
> > Tomasz Michalec (1):
> >   Marvel/Drivers: Pp2Dxe: Basic support for Adapter Information Protocol
> >
> >  Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf   |   1 +
> >  Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.h |  17 ++-
> >  Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.h     |   3 +
> >  Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 111 ++++++++++----
> >  Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c     | 157 ++++++++++++++++++++
> >  Silicon/Marvell/Documentation/PortingGuide.txt  |   7 +-
> >  6 files changed, 265 insertions(+), 31 deletions(-)
> >
> > --
> > 2.7.4
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39949): https://edk2.groups.io/g/devel/message/39949
Mute This Topic: https://groups.io/mt/31476849/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH 0/4] Armada 7k8k network improvements

Posted by Leif Lindholm 4 years, 11 months ago

On Fri, May 03, 2019 at 09:51:41AM +0200, Marcin Wojtas wrote:
> Hi Leif,
> 
> pt., 3 maj 2019 o 09:36 Leif Lindholm <leif.lindholm@linaro.org> napisał(a):
> >
> > On Fri, May 03, 2019 at 01:50:12AM +0200, Marcin Wojtas wrote:
> > > Hi,
> > >
> > > This small patchset extends PP2 NIC driver with the basic
> > > AdapterInformationProtocol support and adds 88E1112 PHY support.
> > > Also a minor fix is included on top.
> > >
> > > The patches are available in the github:
> > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/net-upstream-r20190503
> > >
> > > I'm looking forward to your comments or remarks.
> >
> > For v2, please add a comment to 0/4 on what user(or
> > developer)-observable effect this has on existing edk2-platforms
> > ... platforms.
> >
> 
> Not sure I get it - do you want me to describe a change between v1 and
> v2 or explanation, why I submit these patches at all? Or something
> else?

The latter - why the patches were submitted at all.

Best Regards,

Leif

> 
> Best regards,
> Marcin
> 
> > No comments (beyond Ard's) on the actual patches.
> >
> > Best Regards,
> >
> > Leif
> >
> > > Best regards,
> > > Marcin
> > >
> > > Marcin Wojtas (3):
> > >   Marvell/Drivers: MvPhyDxe: Improve 88E1510 initialization
> > >   Marvell/Drivers: MvPhyDxe: Introduce 88E1112 initialization
> > >   Marvell/Drivers: MvPhyDxe: Reset PHY only once
> > >
> > > Tomasz Michalec (1):
> > >   Marvel/Drivers: Pp2Dxe: Basic support for Adapter Information Protocol
> > >
> > >  Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf   |   1 +
> > >  Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.h |  17 ++-
> > >  Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.h     |   3 +
> > >  Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 111 ++++++++++----
> > >  Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c     | 157 ++++++++++++++++++++
> > >  Silicon/Marvell/Documentation/PortingGuide.txt  |   7 +-
> > >  6 files changed, 265 insertions(+), 31 deletions(-)
> > >
> > > --
> > > 2.7.4
> > >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39953): https://edk2.groups.io/g/devel/message/39953
Mute This Topic: https://groups.io/mt/31476849/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-