[v1] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion

[edk2] [PATCH] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion

Star Zeng posted 1 patch 5 years, 8 months ago

Diff against v2
Download mbox

Failed in applying to current master (apply log)

There is a newer version of this series

FmpDevicePkg/FmpDxe/FmpDxe.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

Expand all Fold all

[edk2] [PATCH] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion

Posted by Star Zeng 5 years, 8 months ago

Some static tool reports "DeviceLibLowestSupportedVersion" is used,
but is uninitialized. It is false positive reporting based because
DeviceLibLowestSupportedVersion will have assigned value after
FmpDeviceGetLowestSupportedVersion() returns SUCCESS.

This patch refines the code to initialize
DeviceLibLowestSupportedVersion
to DEFAULT_LOWESTSUPPORTEDVERSION before calling
FmpDeviceGetLowestSupportedVersion().
It can pass the static tool's check.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 FmpDevicePkg/FmpDxe/FmpDxe.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
index b25a1511c70c..4868f80de2b9 100644
--- a/FmpDevicePkg/FmpDxe/FmpDxe.c
+++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
@@ -229,10 +229,8 @@ GetLowestSupportedVersion (
   //
   // Check the FmpDeviceLib
   //
-  Status = FmpDeviceGetLowestSupportedVersion (&DeviceLibLowestSupportedVersion);
-  if (EFI_ERROR (Status)) {
-    DeviceLibLowestSupportedVersion = DEFAULT_LOWESTSUPPORTEDVERSION;
-  }
+  DeviceLibLowestSupportedVersion = DEFAULT_LOWESTSUPPORTEDVERSION;
+  FmpDeviceGetLowestSupportedVersion (&DeviceLibLowestSupportedVersion);
 
   if (DeviceLibLowestSupportedVersion > ReturnLsv) {
     ReturnLsv = DeviceLibLowestSupportedVersion;
-- 
2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel