On 13 July 2018 at 16:09, Marcin Wojtas <mw@semihalf.com> wrote:
> Hi,
>
> This patchset makes use of the feature present in newest,
> publicly available ARM-TF of the Armada7k8k SoCs
> (https://github.com/MarvellEmbeddedProcessors/atf-marvell/commits/atf-v1.4-armada-18.06)
> which is a common configuration of the serdes lanes.
>
> It is triggered by the users (UEFI/U-Boot/OS) using
> the dedicated smc calls. Thanks to that the library
> could have been cleaned-up and reduced to the per-board
> configuration parsing part and calling the according
> sequences to be done in EL3.
>
> The patches are available in the github:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/comphy-upstream-r20180713
>
> I'm looking forward to review and any comments/remarks.
>
> Best regards,
> Marcin
>
> Grzegorz Jaszczyk (6):
> Marvell/Library: ComPhyLib: Configure SATA, SGMII and SFI in ARM-TF
> Marvell/Library: ComPhyLib: Configure PCIE in ARM-TF
> Marvell/Library: ComPhyLib: Configure RXAUI in ARM-TF
> Marvell/Library: ComPhyLib: Configure USB in ARM-TF
> Marvell/Library: ComPhyLib: Clean up the library after rework
> Marvell/Library: ComPhyLib: Remove both PHY and PIPE selector config
>
This looks fine except for the remarks I made in reply to patches #1 and #2
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 18 +-
> Silicon/Marvell/Library/ComPhyLib/ComPhyLib.inf | 2 +-
> Silicon/Marvell/Armada7k8k/Library/Armada7k8kSampleAtResetLib/Armada7k8kSampleAtResetLib.h | 22 -
> Silicon/Marvell/Include/Library/SampleAtResetLib.h | 7 -
> Silicon/Marvell/Library/ComPhyLib/ComPhyLib.h | 545 +-----
> Silicon/Marvell/Armada7k8k/Library/Armada7k8kSampleAtResetLib/Armada7k8kSampleAtResetLib.c | 19 -
> Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c | 1777 +-------------------
> Silicon/Marvell/Library/ComPhyLib/ComPhyLib.c | 41 +-
> Silicon/Marvell/Library/ComPhyLib/ComPhyMux.c | 132 --
> 9 files changed, 116 insertions(+), 2447 deletions(-)
> delete mode 100644 Silicon/Marvell/Library/ComPhyLib/ComPhyMux.c
>
> --
> 2.7.4
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel