[edk2] [PATCH v4 0/3] OvmfPkg: mark flash memory range as MMIO

Brijesh Singh posted 3 patches 5 years, 9 months ago
Failed in applying to current master (apply log)
.../FvbServicesRuntimeDxe.inf                      |  1 +
.../FwBlockService.c                               | 38 +-----------
.../FwBlockService.h                               |  7 +++
.../FwBlockServiceDxe.c                            | 67 ++++++++++++++++++++++
.../FwBlockServiceSmm.c                            | 13 +++++
5 files changed, 89 insertions(+), 37 deletions(-)
[edk2] [PATCH v4 0/3] OvmfPkg: mark flash memory range as MMIO
Posted by Brijesh Singh 5 years, 9 months ago
The Qemu flash range is marked as 'system ram' in EFI runtime memmap
but it is actually an IO address. The patch series updates the
EFI runtime memmap to add this range as Memory Mapped IO address.

Changes since v3:
- minor changes to address Laszlo's review feedback.

Changes since v2:
 - added cover letter and extend CC list to add all OvmfPkg
   maintainers/reviewers.

Changes since v1:
 - split the OvmfPkg single patch into three patches based on Laszlo's feedback.
  a) mark memory as MMIO for non SEV case
  b) do not adding EFI runtime mapping for SMM build
  c) clear C-bit when SEV is active for non SMM builds only

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Julien Grall <julien.grall@linaro.org>
Cc: Justen Jordan L <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>

Complete tree is available:
url: https://github.com/codomania/edk2.git
branch: qemu-flash-mmio-v4

Brijesh Singh (3):
  OvmfPkg/QemuFlashFvbServicesRuntimeDxe: mark Flash memory range as
    MMIO
  OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Do not expose MMIO in SMM
    build
  OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Restore C-bit when SEV is
    active

 .../FvbServicesRuntimeDxe.inf                      |  1 +
 .../FwBlockService.c                               | 38 +-----------
 .../FwBlockService.h                               |  7 +++
 .../FwBlockServiceDxe.c                            | 67 ++++++++++++++++++++++
 .../FwBlockServiceSmm.c                            | 13 +++++
 5 files changed, 89 insertions(+), 37 deletions(-)

-- 
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v4 0/3] OvmfPkg: mark flash memory range as MMIO
Posted by Laszlo Ersek 5 years, 9 months ago
On 07/06/18 17:00, Brijesh Singh wrote:
> The Qemu flash range is marked as 'system ram' in EFI runtime memmap
> but it is actually an IO address. The patch series updates the
> EFI runtime memmap to add this range as Memory Mapped IO address.
> 
> Changes since v3:
> - minor changes to address Laszlo's review feedback.
> 
> Changes since v2:
>  - added cover letter and extend CC list to add all OvmfPkg
>    maintainers/reviewers.
> 
> Changes since v1:
>  - split the OvmfPkg single patch into three patches based on Laszlo's feedback.
>   a) mark memory as MMIO for non SEV case
>   b) do not adding EFI runtime mapping for SMM build
>   c) clear C-bit when SEV is active for non SMM builds only
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien.grall@linaro.org>
> Cc: Justen Jordan L <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> 
> Complete tree is available:
> url: https://github.com/codomania/edk2.git
> branch: qemu-flash-mmio-v4
> 
> Brijesh Singh (3):
>   OvmfPkg/QemuFlashFvbServicesRuntimeDxe: mark Flash memory range as
>     MMIO
>   OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Do not expose MMIO in SMM
>     build
>   OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Restore C-bit when SEV is
>     active
> 
>  .../FvbServicesRuntimeDxe.inf                      |  1 +
>  .../FwBlockService.c                               | 38 +-----------
>  .../FwBlockService.h                               |  7 +++
>  .../FwBlockServiceDxe.c                            | 67 ++++++++++++++++++++++
>  .../FwBlockServiceSmm.c                            | 13 +++++
>  5 files changed, 89 insertions(+), 37 deletions(-)
> 

series
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Regression-tested-by: Laszlo Ersek <lersek@redhat.com>

Commit range 9090c8b53301..75b7aa9528bd.

Thank you for the contribution! The first two patches are a good general
improvement for non-SEV guests as well.

Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel