[edk2] [PATCH v4 0/2] add platform boot manager protocol

Haojian Zhuang posted 2 patches 6 years, 6 months ago
Failed in applying to current master (apply log)
ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 103 +++++++++++++++++++++
.../PlatformBootManagerLib.inf                     |   2 +
EmbeddedPkg/EmbeddedPkg.dec                        |   1 +
EmbeddedPkg/Include/Protocol/PlatformBootManager.h |  86 +++++++++++++++++
4 files changed, 192 insertions(+)
create mode 100644 EmbeddedPkg/Include/Protocol/PlatformBootManager.h
[edk2] [PATCH v4 0/2] add platform boot manager protocol
Posted by Haojian Zhuang 6 years, 6 months ago
Changelog:
v4:
  * Add BootCount parameter in the interface.
  * Clean the logic on boot options according to Laszlo's comment.
v3:
  * Update the name of interface.
  * Move the initialization into platform driver.
  * Fix comment style.
  * Fix minor issues with comments.
v2:
  * Avoid to use hardcoding value. Create boot options by functions.

Haojian Zhuang (2):
  EmbeddedPkg: add platform boot manager protocol
  ArmPkg/PlatformBootManagerLib: load platform boot options

 ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 103 +++++++++++++++++++++
 .../PlatformBootManagerLib.inf                     |   2 +
 EmbeddedPkg/EmbeddedPkg.dec                        |   1 +
 EmbeddedPkg/Include/Protocol/PlatformBootManager.h |  86 +++++++++++++++++
 4 files changed, 192 insertions(+)
 create mode 100644 EmbeddedPkg/Include/Protocol/PlatformBootManager.h

-- 
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v4 0/2] add platform boot manager protocol
Posted by Laszlo Ersek 6 years, 6 months ago
On 04/23/18 08:21, Haojian Zhuang wrote:
> Changelog:
> v4:
>   * Add BootCount parameter in the interface.
>   * Clean the logic on boot options according to Laszlo's comment.
> v3:
>   * Update the name of interface.
>   * Move the initialization into platform driver.
>   * Fix comment style.
>   * Fix minor issues with comments.
> v2:
>   * Avoid to use hardcoding value. Create boot options by functions.
> 
> Haojian Zhuang (2):
>   EmbeddedPkg: add platform boot manager protocol
>   ArmPkg/PlatformBootManagerLib: load platform boot options
> 
>  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 103 +++++++++++++++++++++
>  .../PlatformBootManagerLib.inf                     |   2 +
>  EmbeddedPkg/EmbeddedPkg.dec                        |   1 +
>  EmbeddedPkg/Include/Protocol/PlatformBootManager.h |  86 +++++++++++++++++
>  4 files changed, 192 insertions(+)
>  create mode 100644 EmbeddedPkg/Include/Protocol/PlatformBootManager.h
> 

(CC Leif, Ard)

For the series:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v4 0/2] add platform boot manager protocol
Posted by Leif Lindholm 6 years, 4 months ago
On Mon, Apr 23, 2018 at 10:15:41PM +0200, Laszlo Ersek wrote:
> On 04/23/18 08:21, Haojian Zhuang wrote:
> > Changelog:
> > v4:
> >   * Add BootCount parameter in the interface.
> >   * Clean the logic on boot options according to Laszlo's comment.
> > v3:
> >   * Update the name of interface.
> >   * Move the initialization into platform driver.
> >   * Fix comment style.
> >   * Fix minor issues with comments.
> > v2:
> >   * Avoid to use hardcoding value. Create boot options by functions.
> > 
> > Haojian Zhuang (2):
> >   EmbeddedPkg: add platform boot manager protocol
> >   ArmPkg/PlatformBootManagerLib: load platform boot options
> > 
> >  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 103 +++++++++++++++++++++
> >  .../PlatformBootManagerLib.inf                     |   2 +
> >  EmbeddedPkg/EmbeddedPkg.dec                        |   1 +
> >  EmbeddedPkg/Include/Protocol/PlatformBootManager.h |  86 +++++++++++++++++
> >  4 files changed, 192 insertions(+)
> >  create mode 100644 EmbeddedPkg/Include/Protocol/PlatformBootManager.h
> > 
> 
> (CC Leif, Ard)
> 
> For the series:
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks for the review Lazslo.

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Series pushed as 76022b02e8..1b6e7633ca.

I will add that the bits that go into EmbeddedPkg here do so for no
other reason than "we don't have a better place for them, and they're
certainly not ARM-specific". The case for a generic UtilityPkg is growing.

/
    Leif
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel