1. Patchew
  2. EDK2
  3. View series

[edk2] [RFC] ShellPkg/Ping: fix loss of first packet

Meenakshi posted 1 patch 6 years, 2 months ago
Failed in applying to current master (apply log)
ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
[edk2] [RFC] ShellPkg/Ping: fix loss of first packet
Posted by Meenakshi 6 years, 2 months ago 
From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>

Issue:
Reply for first ping packet was getting dropped.

Cause:
Sometimes reply message comes even before trasmit
function returns, hence missing 1st reply

Fix:
Prepare the TxList before calling Transmit function.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
---
 ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
index bec9535..46ba701 100644
--- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
+++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
@@ -784,14 +784,17 @@ PingSendEchoRequest (
   }
 
   ASSERT(Private->ProtocolPointers.Transmit != NULL);
+
+  InsertTailList (&Private->TxList, &TxInfo->Link);
+
   Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, TxInfo->Token);
 
   if (EFI_ERROR (Status)) {
+    RemoveEntryList (&TxInfo->Link);
     PingDestroyTxInfo (TxInfo, Private->IpChoice);
     return Status;
   }
 
-  InsertTailList (&Private->TxList, &TxInfo->Link);
   Private->TxCount++;
 
   return EFI_SUCCESS;
-- 
1.9.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
Posted by Carsey, Jaben 6 years, 2 months ago 
Seems good to me.  I will let Ray review also.

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Meenakshi
> Sent: Friday, February 16, 2018 12:45 AM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> Subject: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> Importance: High
> 
> From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> 
> Issue:
> Reply for first ping packet was getting dropped.
> 
> Cause:
> Sometimes reply message comes even before trasmit
> function returns, hence missing 1st reply
> 
> Fix:
> Prepare the TxList before calling Transmit function.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> ---
>  ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> index bec9535..46ba701 100644
> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> @@ -784,14 +784,17 @@ PingSendEchoRequest (
>    }
> 
>    ASSERT(Private->ProtocolPointers.Transmit != NULL);
> +
> +  InsertTailList (&Private->TxList, &TxInfo->Link);
> +
>    Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, TxInfo-
> >Token);
> 
>    if (EFI_ERROR (Status)) {
> +    RemoveEntryList (&TxInfo->Link);
>      PingDestroyTxInfo (TxInfo, Private->IpChoice);
>      return Status;
>    }
> 
> -  InsertTailList (&Private->TxList, &TxInfo->Link);
>    Private->TxCount++;
> 
>    return EFI_SUCCESS;
> --
> 1.9.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
Posted by Meenakshi Aggarwal 6 years, 1 month ago 
Hi Ray,

Please share your comments.


Thanks,
Meenakshi

> -----Original Message-----
> From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
> Sent: Friday, February 16, 2018 8:51 PM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
> <ruiyu.ni@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> Subject: RE: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> 
> Seems good to me.  I will let Ray review also.
> 
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Meenakshi
> > Sent: Friday, February 16, 2018 12:45 AM
> > To: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> > <jaben.carsey@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> > Subject: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> > Importance: High
> >
> > From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> >
> > Issue:
> > Reply for first ping packet was getting dropped.
> >
> > Cause:
> > Sometimes reply message comes even before trasmit
> > function returns, hence missing 1st reply
> >
> > Fix:
> > Prepare the TxList before calling Transmit function.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > ---
> >  ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > index bec9535..46ba701 100644
> > --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > @@ -784,14 +784,17 @@ PingSendEchoRequest (
> >    }
> >
> >    ASSERT(Private->ProtocolPointers.Transmit != NULL);
> > +
> > +  InsertTailList (&Private->TxList, &TxInfo->Link);
> > +
> >    Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, TxInfo-
> > >Token);
> >
> >    if (EFI_ERROR (Status)) {
> > +    RemoveEntryList (&TxInfo->Link);
> >      PingDestroyTxInfo (TxInfo, Private->IpChoice);
> >      return Status;
> >    }
> >
> > -  InsertTailList (&Private->TxList, &TxInfo->Link);
> >    Private->TxCount++;
> >
> >    return EFI_SUCCESS;
> > --
> > 1.9.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> s.01.org%2Fmailman%2Flistinfo%2Fedk2-
> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C1d7bd63786b
> 044ba3c9508d57550d50a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C636543912439710731&sdata=Bn%2Febt4emmCvayFNmcKCi3xJuFfV52Vq
> 4aQLVSNNti8%3D&reserved=0
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
Posted by Ni, Ruiyu 6 years, 1 month ago 
On 2/20/2018 2:18 PM, Meenakshi Aggarwal wrote:
> Hi Ray,
> 
> Please share your comments.
> 
> 
> Thanks,
> Meenakshi
> 
>> -----Original Message-----
>> From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
>> Sent: Friday, February 16, 2018 8:51 PM
>> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
>> <ruiyu.ni@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
>> Subject: RE: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
>>
>> Seems good to me.  I will let Ray review also.
>>
>> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>>
>>> -----Original Message-----
>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>>> Meenakshi
>>> Sent: Friday, February 16, 2018 12:45 AM
>>> To: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
>>> <jaben.carsey@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
>>> Subject: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
>>> Importance: High
>>>
>>> From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>>>
>>> Issue:
>>> Reply for first ping packet was getting dropped.
>>>
>>> Cause:
>>> Sometimes reply message comes even before trasmit
>>> function returns, hence missing 1st reply
>>>
>>> Fix:
>>> Prepare the TxList before calling Transmit function.
>>>
>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>>> ---
>>>   ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>> index bec9535..46ba701 100644
>>> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>> @@ -784,14 +784,17 @@ PingSendEchoRequest (
>>>     }
>>>
>>>     ASSERT(Private->ProtocolPointers.Transmit != NULL);
>>> +
>>> +  InsertTailList (&Private->TxList, &TxInfo->Link);
>>> +
>>>     Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, TxInfo-
>>>> Token);
>>>
>>>     if (EFI_ERROR (Status)) {
>>> +    RemoveEntryList (&TxInfo->Link);
>>>       PingDestroyTxInfo (TxInfo, Private->IpChoice);
>>>       return Status;
>>>     }
>>>
>>> -  InsertTailList (&Private->TxList, &TxInfo->Link);
>>>     Private->TxCount++;
>>>
>>>     return EFI_SUCCESS;
>>> --
>>> 1.9.1
>>>
>>> _______________________________________________
>>> edk2-devel mailing list
>>> edk2-devel@lists.01.org
>>>
>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
>> s.01.org%2Fmailman%2Flistinfo%2Fedk2-
>> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C1d7bd63786b
>> 044ba3c9508d57550d50a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
>> %7C636543912439710731&sdata=Bn%2Febt4emmCvayFNmcKCi3xJuFfV52Vq
>> 4aQLVSNNti8%3D&reserved=0
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>


-- 
Thanks,
Ray
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
Posted by Meenakshi Aggarwal 6 years, 1 month ago 
Hi All,

Any comments on this patch or is it good to go?

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks,
Meenakshi

> -----Original Message-----
> From: Ni, Ruiyu [mailto:ruiyu.ni@Intel.com]
> Sent: Thursday, February 22, 2018 2:03 PM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> Subject: Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> 
> On 2/20/2018 2:18 PM, Meenakshi Aggarwal wrote:
> > Hi Ray,
> >
> > Please share your comments.
> >
> >
> > Thanks,
> > Meenakshi
> >
> >> -----Original Message-----
> >> From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
> >> Sent: Friday, February 16, 2018 8:51 PM
> >> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
> >> <ruiyu.ni@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> >> Subject: RE: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> >>
> >> Seems good to me.  I will let Ray review also.
> >>
> >> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> >>
> >>> -----Original Message-----
> >>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
> Of
> >>> Meenakshi
> >>> Sent: Friday, February 16, 2018 12:45 AM
> >>> To: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> >>> <jaben.carsey@intel.com>; edk2-devel@lists.01.org;
> lersek@redhat.com
> >>> Subject: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> >>> Importance: High
> >>>
> >>> From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> >>>
> >>> Issue:
> >>> Reply for first ping packet was getting dropped.
> >>>
> >>> Cause:
> >>> Sometimes reply message comes even before trasmit
> >>> function returns, hence missing 1st reply
> >>>
> >>> Fix:
> >>> Prepare the TxList before calling Transmit function.
> >>>
> >>> Contributed-under: TianoCore Contribution Agreement 1.1
> >>> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> >>> ---
> >>>   ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
> >>>   1 file changed, 4 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >>> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >>> index bec9535..46ba701 100644
> >>> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >>> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >>> @@ -784,14 +784,17 @@ PingSendEchoRequest (
> >>>     }
> >>>
> >>>     ASSERT(Private->ProtocolPointers.Transmit != NULL);
> >>> +
> >>> +  InsertTailList (&Private->TxList, &TxInfo->Link);
> >>> +
> >>>     Status = Private->ProtocolPointers.Transmit (Private->IpProtocol,
> TxInfo-
> >>>> Token);
> >>>
> >>>     if (EFI_ERROR (Status)) {
> >>> +    RemoveEntryList (&TxInfo->Link);
> >>>       PingDestroyTxInfo (TxInfo, Private->IpChoice);
> >>>       return Status;
> >>>     }
> >>>
> >>> -  InsertTailList (&Private->TxList, &TxInfo->Link);
> >>>     Private->TxCount++;
> >>>
> >>>     return EFI_SUCCESS;
> >>> --
> >>> 1.9.1
> >>>
> >>> _______________________________________________
> >>> edk2-devel mailing list
> >>> edk2-devel@lists.01.org
> >>>
> >>
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> >> s.01.org%2Fmailman%2Flistinfo%2Fedk2-
> >>
> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C1d7bd63786b
> >>
> 044ba3c9508d57550d50a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> >>
> %7C636543912439710731&sdata=Bn%2Febt4emmCvayFNmcKCi3xJuFfV52Vq
> >> 4aQLVSNNti8%3D&reserved=0
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> 
> 
> --
> Thanks,
> Ray
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
Posted by Laszlo Ersek 6 years, 1 month ago 
On 02/23/18 10:57, Meenakshi Aggarwal wrote:
> Hi All,
> 
> Any comments on this patch or is it good to go?
> 
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Are you asking for someone to commit & push the patch?

Laszlo

>> -----Original Message-----
>> From: Ni, Ruiyu [mailto:ruiyu.ni@Intel.com]
>> Sent: Thursday, February 22, 2018 2:03 PM
>> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Carsey, Jaben
>> <jaben.carsey@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
>> Subject: Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
>>
>> On 2/20/2018 2:18 PM, Meenakshi Aggarwal wrote:
>>> Hi Ray,
>>>
>>> Please share your comments.
>>>
>>>
>>> Thanks,
>>> Meenakshi
>>>
>>>> -----Original Message-----
>>>> From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
>>>> Sent: Friday, February 16, 2018 8:51 PM
>>>> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
>>>> <ruiyu.ni@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
>>>> Subject: RE: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
>>>>
>>>> Seems good to me.  I will let Ray review also.
>>>>
>>>> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>>>>
>>>>> -----Original Message-----
>>>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
>> Of
>>>>> Meenakshi
>>>>> Sent: Friday, February 16, 2018 12:45 AM
>>>>> To: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
>>>>> <jaben.carsey@intel.com>; edk2-devel@lists.01.org;
>> lersek@redhat.com
>>>>> Subject: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
>>>>> Importance: High
>>>>>
>>>>> From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>>>>>
>>>>> Issue:
>>>>> Reply for first ping packet was getting dropped.
>>>>>
>>>>> Cause:
>>>>> Sometimes reply message comes even before trasmit
>>>>> function returns, hence missing 1st reply
>>>>>
>>>>> Fix:
>>>>> Prepare the TxList before calling Transmit function.
>>>>>
>>>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>>>> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>>>>> ---
>>>>>   ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
>>>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>>>> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>>>> index bec9535..46ba701 100644
>>>>> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>>>> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>>>> @@ -784,14 +784,17 @@ PingSendEchoRequest (
>>>>>     }
>>>>>
>>>>>     ASSERT(Private->ProtocolPointers.Transmit != NULL);
>>>>> +
>>>>> +  InsertTailList (&Private->TxList, &TxInfo->Link);
>>>>> +
>>>>>     Status = Private->ProtocolPointers.Transmit (Private->IpProtocol,
>> TxInfo-
>>>>>> Token);
>>>>>
>>>>>     if (EFI_ERROR (Status)) {
>>>>> +    RemoveEntryList (&TxInfo->Link);
>>>>>       PingDestroyTxInfo (TxInfo, Private->IpChoice);
>>>>>       return Status;
>>>>>     }
>>>>>
>>>>> -  InsertTailList (&Private->TxList, &TxInfo->Link);
>>>>>     Private->TxCount++;
>>>>>
>>>>>     return EFI_SUCCESS;
>>>>> --
>>>>> 1.9.1
>>>>>
>>>>> _______________________________________________
>>>>> edk2-devel mailing list
>>>>> edk2-devel@lists.01.org
>>>>>
>>>>
>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
>>>> s.01.org%2Fmailman%2Flistinfo%2Fedk2-
>>>>
>> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C1d7bd63786b
>>>>
>> 044ba3c9508d57550d50a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
>>>>
>> %7C636543912439710731&sdata=Bn%2Febt4emmCvayFNmcKCi3xJuFfV52Vq
>>>> 4aQLVSNNti8%3D&reserved=0
>> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
>>
>>
>> --
>> Thanks,
>> Ray

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
Posted by Meenakshi Aggarwal 6 years, 1 month ago 

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Friday, February 23, 2018 3:48 PM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
> <ruiyu.ni@Intel.com>; Carsey, Jaben <jaben.carsey@intel.com>; edk2-
> devel@lists.01.org
> Subject: Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> 
> On 02/23/18 10:57, Meenakshi Aggarwal wrote:
> > Hi All,
> >
> > Any comments on this patch or is it good to go?
> >
> > Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> > Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> 
> Are you asking for someone to commit & push the patch?
> 
I request for both, comments (if any), else please push this patch.

> Laszlo
> 
> >> -----Original Message-----
> >> From: Ni, Ruiyu [mailto:ruiyu.ni@Intel.com]
> >> Sent: Thursday, February 22, 2018 2:03 PM
> >> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Carsey, Jaben
> >> <jaben.carsey@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> >> Subject: Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> >>
> >> On 2/20/2018 2:18 PM, Meenakshi Aggarwal wrote:
> >>> Hi Ray,
> >>>
> >>> Please share your comments.
> >>>
> >>>
> >>> Thanks,
> >>> Meenakshi
> >>>
> >>>> -----Original Message-----
> >>>> From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
> >>>> Sent: Friday, February 16, 2018 8:51 PM
> >>>> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
> >>>> <ruiyu.ni@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> >>>> Subject: RE: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> >>>>
> >>>> Seems good to me.  I will let Ray review also.
> >>>>
> >>>> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> >>>>
> >>>>> -----Original Message-----
> >>>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On
> Behalf
> >> Of
> >>>>> Meenakshi
> >>>>> Sent: Friday, February 16, 2018 12:45 AM
> >>>>> To: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> >>>>> <jaben.carsey@intel.com>; edk2-devel@lists.01.org;
> >> lersek@redhat.com
> >>>>> Subject: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> >>>>> Importance: High
> >>>>>
> >>>>> From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> >>>>>
> >>>>> Issue:
> >>>>> Reply for first ping packet was getting dropped.
> >>>>>
> >>>>> Cause:
> >>>>> Sometimes reply message comes even before trasmit
> >>>>> function returns, hence missing 1st reply
> >>>>>
> >>>>> Fix:
> >>>>> Prepare the TxList before calling Transmit function.
> >>>>>
> >>>>> Contributed-under: TianoCore Contribution Agreement 1.1
> >>>>> Signed-off-by: Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>
> >>>>> ---
> >>>>>   ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
> >>>>>   1 file changed, 4 insertions(+), 1 deletion(-)
> >>>>>
> >>>>> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >>>>> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >>>>> index bec9535..46ba701 100644
> >>>>> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >>>>> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >>>>> @@ -784,14 +784,17 @@ PingSendEchoRequest (
> >>>>>     }
> >>>>>
> >>>>>     ASSERT(Private->ProtocolPointers.Transmit != NULL);
> >>>>> +
> >>>>> +  InsertTailList (&Private->TxList, &TxInfo->Link);
> >>>>> +
> >>>>>     Status = Private->ProtocolPointers.Transmit (Private->IpProtocol,
> >> TxInfo-
> >>>>>> Token);
> >>>>>
> >>>>>     if (EFI_ERROR (Status)) {
> >>>>> +    RemoveEntryList (&TxInfo->Link);
> >>>>>       PingDestroyTxInfo (TxInfo, Private->IpChoice);
> >>>>>       return Status;
> >>>>>     }
> >>>>>
> >>>>> -  InsertTailList (&Private->TxList, &TxInfo->Link);
> >>>>>     Private->TxCount++;
> >>>>>
> >>>>>     return EFI_SUCCESS;
> >>>>> --
> >>>>> 1.9.1
> >>>>>
> >>>>> _______________________________________________
> >>>>> edk2-devel mailing list
> >>>>> edk2-devel@lists.01.org
> >>>>>
> >>>>
> >>
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> >>>> s.01.org%2Fmailman%2Flistinfo%2Fedk2-
> >>>>
> >>
> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C1d7bd63786b
> >>>>
> >>
> 044ba3c9508d57550d50a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> >>>>
> >>
> %7C636543912439710731&sdata=Bn%2Febt4emmCvayFNmcKCi3xJuFfV52Vq
> >>>> 4aQLVSNNti8%3D&reserved=0
> >> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> >>
> >>
> >> --
> >> Thanks,
> >> Ray

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
Posted by Laszlo Ersek 6 years, 1 month ago 
On 02/23/18 11:26, Meenakshi Aggarwal wrote:
> 
> 
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Friday, February 23, 2018 3:48 PM
>> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
>> <ruiyu.ni@Intel.com>; Carsey, Jaben <jaben.carsey@intel.com>; edk2-
>> devel@lists.01.org
>> Subject: Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
>>
>> On 02/23/18 10:57, Meenakshi Aggarwal wrote:
>>> Hi All,
>>>
>>> Any comments on this patch or is it good to go?
>>>
>>> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>>> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
>>
>> Are you asking for someone to commit & push the patch?
>>
> I request for both, comments (if any), else please push this patch.

The patch has been on the list for ~7 days, and it has R-b's from both
ShellPkg maintainers.

I've pushed it for you now. Commit d624deb7abf9.

Thank you for the bugfix!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
Posted by Carsey, Jaben 6 years, 1 month ago 
Thanks Laszlo!

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Friday, February 23, 2018 4:02 AM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> Importance: High
> 
> On 02/23/18 11:26, Meenakshi Aggarwal wrote:
> >
> >
> >> -----Original Message-----
> >> From: Laszlo Ersek [mailto:lersek@redhat.com]
> >> Sent: Friday, February 23, 2018 3:48 PM
> >> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
> >> <ruiyu.ni@Intel.com>; Carsey, Jaben <jaben.carsey@intel.com>; edk2-
> >> devel@lists.01.org
> >> Subject: Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> >>
> >> On 02/23/18 10:57, Meenakshi Aggarwal wrote:
> >>> Hi All,
> >>>
> >>> Any comments on this patch or is it good to go?
> >>>
> >>> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> >>> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> >>
> >> Are you asking for someone to commit & push the patch?
> >>
> > I request for both, comments (if any), else please push this patch.
> 
> The patch has been on the list for ~7 days, and it has R-b's from both
> ShellPkg maintainers.
> 
> I've pushed it for you now. Commit d624deb7abf9.
> 
> Thank you for the bugfix!
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.