[edk2] [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI FPDT table

Dandan Bi posted 8 patches 6 years, 9 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
.../Include/Guid/ExtendedFirmwarePerformance.h     |  291 ++++
MdeModulePkg/Include/Guid/FirmwarePerformance.h    |   13 +-
.../DxeCorePerformanceLib/DxeCorePerformanceLib.c  | 1389 +++++++++++++++-----
.../DxeCorePerformanceLib.inf                      |   20 +-
.../DxeCorePerformanceLibInternal.h                |   17 +-
.../Library/PeiPerformanceLib/PeiPerformanceLib.c  |  565 +++++---
.../PeiPerformanceLib/PeiPerformanceLib.inf        |   14 +-
.../SmmCorePerformanceLib/SmmCorePerformanceLib.c  | 1145 +++++++++-------
.../SmmCorePerformanceLib.inf                      |   10 +-
.../SmmCorePerformanceLibInternal.h                |   11 +-
MdeModulePkg/MdeModulePkg.dec                      |   11 +-
MdeModulePkg/MdeModulePkg.uni                      |    8 +-
.../FirmwarePerformanceDxe.c                       |  271 +---
.../FirmwarePerformanceDxe.inf                     |    4 +-
.../FirmwarePerformancePei.c                       |   59 +-
.../FirmwarePerformancePei.inf                     |    5 +-
.../FirmwarePerformanceSmm.c                       |   29 +-
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c      |  609 ++++++++-
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h      |    7 +-
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni    |   11 +-
ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf |    5 +-
.../DpDynamicCommand/DpDynamicCommand.inf          |    5 +-
.../DynamicCommand/DpDynamicCommand/DpInternal.h   |    9 +-
ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c |  108 +-
.../DynamicCommand/DpDynamicCommand/DpUtilities.c  |   37 +-
.../DynamicCommand/DpDynamicCommand/Literals.c     |   24 +-
.../DynamicCommand/DpDynamicCommand/Literals.h     |    8 +-
.../DpDynamicCommand/PerformanceTokens.h           |   28 -
28 files changed, 3342 insertions(+), 1371 deletions(-)
create mode 100644 MdeModulePkg/Include/Guid/ExtendedFirmwarePerformance.h
delete mode 100644 ShellPkg/DynamicCommand/DpDynamicCommand/PerformanceTokens.h
[edk2] [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI FPDT table
Posted by Dandan Bi 6 years, 9 months ago
V2:
a.Update DxecorePerformanceLib/SmmCorePerformanceLib to report the
boot performance table address instead of records contents.
b.Update FirmwarePerformanceDxe/FirmwarePerformanceSmm to receive the address
of performance records.

This patch series also can be accessed at:
https://github.com/dandanbi/edk2/tree/NewPerformanceInfrastructureV2

These patches are to update EDKII performance infrastructure to log and dump
the performance entry as FPDT record in ACPI FPDT table.This new infrastructure
can support to dump performance data in UEFI Shell and OS both.
(1)PeiPerformanceLib/DxeCorePerformanceLib/SmmCorePerformanceLib log the
performance entry as FPDT record.
(2)FirmwarePerformancePei/FirmwarePerformanceDxe/FirmwarePerformanceSmm
install the FPDT records to the ACPI table.
(3)Update DP to dump the performance info from the FPDT records in
FPDT table.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Dandan Bi (7):
  MdeModulePkg/PeiPerformance:Updated to track FPDT record in PEI phase
  MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
  MdeModulePkg/SmmCorePerformanceLib:Track FPDT record in SMM phase
  MdeModulePkg/FirmwarePerformancePei:Add FPDT records for S3 phase
  MdeModulePkg/FirmwarePerfDxe:Enhance for new pref infrastructure
  MdeModulePkg/FirmwarePerfSmm:Enhance for new pref infrastructure
  ShellPkg/Dp: Updated to dump perf log based on FPDT table

Gao, Liming (1):
  MdeModulePkg:Add definitions for new Performance infrastructure

 .../Include/Guid/ExtendedFirmwarePerformance.h     |  291 ++++
 MdeModulePkg/Include/Guid/FirmwarePerformance.h    |   13 +-
 .../DxeCorePerformanceLib/DxeCorePerformanceLib.c  | 1389 +++++++++++++++-----
 .../DxeCorePerformanceLib.inf                      |   20 +-
 .../DxeCorePerformanceLibInternal.h                |   17 +-
 .../Library/PeiPerformanceLib/PeiPerformanceLib.c  |  565 +++++---
 .../PeiPerformanceLib/PeiPerformanceLib.inf        |   14 +-
 .../SmmCorePerformanceLib/SmmCorePerformanceLib.c  | 1145 +++++++++-------
 .../SmmCorePerformanceLib.inf                      |   10 +-
 .../SmmCorePerformanceLibInternal.h                |   11 +-
 MdeModulePkg/MdeModulePkg.dec                      |   11 +-
 MdeModulePkg/MdeModulePkg.uni                      |    8 +-
 .../FirmwarePerformanceDxe.c                       |  271 +---
 .../FirmwarePerformanceDxe.inf                     |    4 +-
 .../FirmwarePerformancePei.c                       |   59 +-
 .../FirmwarePerformancePei.inf                     |    5 +-
 .../FirmwarePerformanceSmm.c                       |   29 +-
 ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c      |  609 ++++++++-
 ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h      |    7 +-
 ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni    |   11 +-
 ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf |    5 +-
 .../DpDynamicCommand/DpDynamicCommand.inf          |    5 +-
 .../DynamicCommand/DpDynamicCommand/DpInternal.h   |    9 +-
 ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c |  108 +-
 .../DynamicCommand/DpDynamicCommand/DpUtilities.c  |   37 +-
 .../DynamicCommand/DpDynamicCommand/Literals.c     |   24 +-
 .../DynamicCommand/DpDynamicCommand/Literals.h     |    8 +-
 .../DpDynamicCommand/PerformanceTokens.h           |   28 -
 28 files changed, 3342 insertions(+), 1371 deletions(-)
 create mode 100644 MdeModulePkg/Include/Guid/ExtendedFirmwarePerformance.h
 delete mode 100644 ShellPkg/DynamicCommand/DpDynamicCommand/PerformanceTokens.h

-- 
1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2-devel] [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI FPDT table
Posted by boonewang@zhaoxin.com 4 years, 6 months ago
Hi, Dandan

I have seen an email named “ [edk2] [PATCH v2 8/8] ShellPkg/Dp: Updated to dump perf log based on FPDT table “ in mail-archive ” and I know there is an update of Dp.

But I feel uncertain that:

-  // Determine in which direction the performance counter counts. -  TimerInfo.CountUp = (BOOLEAN) (TimerInfo.EndCount >= TimerInfo.StartCount); +  TimerInfo.StartCount = 0; +  TimerInfo.EndCount   = 0xFFFF; +  TimerInfo.CountUp = TRUE;

So it looks like we would not use timer count down feature , does it mean we should use count up timer such as TSC or ACPI Timer? Maybe is there any other cause?

I am looking forward your reply! Thanks!

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58216): https://edk2.groups.io/g/devel/message/58216
Mute This Topic: https://groups.io/mt/30910590/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-