[v1] Improve D0x platforms and bug fix

[edk2] [PATCH edk2-non-osi v1 0/3] Improve D0x platforms and bug fix

Posted by Heyi Guo 6 years, 2 months ago

Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git
branch: rp-1802-osi-v1

*** BLURB HERE ***

Heyi Guo (2):
  Hisilicon D0x: Fix network interface order issue
  Hisilicon D0x: Move SnpPlatform to edk2-platforms.

Jason Zhang (1):
  Hisilicon D03/D05: Move SasPlatform to edk2-platforms

 Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 26688 -> 26592 bytes
 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3040 -> 0 bytes
 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf |  24 --------------------
 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi     | Bin 3040 -> 0 bytes
 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf     |  24 --------------------
 Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 28544 -> 28448 bytes
 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3392 -> 0 bytes
 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf |  24 --------------------
 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi     | Bin 3424 -> 0 bytes
 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf     |  24 --------------------
 10 files changed, 96 deletions(-)
 delete mode 100644 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi
 delete mode 100644 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf
 delete mode 100644 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi
 delete mode 100644 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf
 delete mode 100644 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi
 delete mode 100644 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf
 delete mode 100644 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi
 delete mode 100644 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf

-- 
1.9.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH edk2-non-osi v1 0/3] Improve D0x platforms and bug fix

Posted by Leif Lindholm 6 years, 2 months ago

On Thu, Jan 18, 2018 at 11:02:42PM +0800, Heyi Guo wrote:
> Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git
> branch: rp-1802-osi-v1
> 
> *** BLURB HERE ***

I'm happy with the layout this set, but I would have preferred if
this cover-letter instead of "*** BLURB HERE ***" pointed out
explicitly the ordering requirements with regards to the
edk2-platforms set.

However, since we don't have any source code to help guide us in what
changes have been implemented, the individual commit messages for each
patch need to be more detailed - I will comment on those separately.

/
    Leif

> Heyi Guo (2):
>   Hisilicon D0x: Fix network interface order issue
>   Hisilicon D0x: Move SnpPlatform to edk2-platforms.
> 
> Jason Zhang (1):
>   Hisilicon D03/D05: Move SasPlatform to edk2-platforms
> 
>  Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 26688 -> 26592 bytes
>  Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3040 -> 0 bytes
>  Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf |  24 --------------------
>  Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi     | Bin 3040 -> 0 bytes
>  Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf     |  24 --------------------
>  Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 28544 -> 28448 bytes
>  Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3392 -> 0 bytes
>  Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf |  24 --------------------
>  Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi     | Bin 3424 -> 0 bytes
>  Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf     |  24 --------------------
>  10 files changed, 96 deletions(-)
>  delete mode 100644 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi
>  delete mode 100644 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf
>  delete mode 100644 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi
>  delete mode 100644 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf
>  delete mode 100644 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi
>  delete mode 100644 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf
>  delete mode 100644 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi
>  delete mode 100644 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf
> 
> -- 
> 1.9.1
> 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH edk2-non-osi v1 2/3] Hisilicon D0x: Fix network interface order issue

Posted by Heyi Guo 6 years, 2 months ago

Update SnpPV660Dxe binary to fix network interface order issue.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jason Zhang <zhangjinsong2@huawei.com>
Signed-off-by: Ming Huang <huangming23@huawei.com>
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
---
 Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 26688 -> 26592 bytes
 Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 28544 -> 28448 bytes
 2 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi b/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi
index 8ce6a6d..fbdbba1 100644
Binary files a/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi and b/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi differ
diff --git a/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi b/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi
index bc7942a..54f5dba 100644
Binary files a/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi and b/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi differ
-- 
1.9.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH edk2-non-osi v1 2/3] Hisilicon D0x: Fix network interface order issue

Posted by Ard Biesheuvel 6 years, 2 months ago

On 18 January 2018 at 15:02, Heyi Guo <heyi.guo@linaro.org> wrote:
> Update SnpPV660Dxe binary to fix network interface order issue.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jason Zhang <zhangjinsong2@huawei.com>
> Signed-off-by: Ming Huang <huangming23@huawei.com>
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 26688 -> 26592 bytes
>  Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 28544 -> 28448 bytes
>  2 files changed, 0 insertions(+), 0 deletions(-)
>
> diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi b/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi
> index 8ce6a6d..fbdbba1 100644
> Binary files a/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi and b/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi differ
> diff --git a/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi b/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi
> index bc7942a..54f5dba 100644
> Binary files a/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi and b/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi differ
> --
> 1.9.1
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH edk2-non-osi v1 2/3] Hisilicon D0x: Fix network interface order issue

Posted by Leif Lindholm 6 years, 2 months ago

On Thu, Jan 18, 2018 at 11:02:44PM +0800, Heyi Guo wrote:
> Update SnpPV660Dxe binary to fix network interface order issue.

What was the issue?
What was the behaviour seen before this update?
What is the behaviour seen after this update?

/
    Leif

> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jason Zhang <zhangjinsong2@huawei.com>
> Signed-off-by: Ming Huang <huangming23@huawei.com>
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> ---
>  Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 26688 -> 26592 bytes
>  Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 28544 -> 28448 bytes
>  2 files changed, 0 insertions(+), 0 deletions(-)
> 
> diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi b/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi
> index 8ce6a6d..fbdbba1 100644
> Binary files a/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi and b/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi differ
> diff --git a/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi b/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi
> index bc7942a..54f5dba 100644
> Binary files a/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi and b/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi differ
> -- 
> 1.9.1
> 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel