1. Patchew
  2. EDK2
  3. View series

[edk2] [Patch] ShellPkg: Update the parameter type to match function interface in DmpStore

Liming Gao posted 1 patch 7 years, 1 month ago
Failed in applying to current master (apply log)
ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2] [Patch] ShellPkg: Update the parameter type to match function interface in DmpStore
Posted by Liming Gao 7 years, 1 month ago 
This fix can resolve CLANG38 build failure.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
index 062ab5d..c2b60fe 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
@@ -522,7 +522,7 @@ CascadeProcessVariables (
             Status = EFI_OUT_OF_RESOURCES;
           }
         } else {
-          Status = gEfiShellProtocol->GetGuidName(&FoundVarGuid, &GuidName);
+          Status = gEfiShellProtocol->GetGuidName(&FoundVarGuid, (CONST CHAR16 **) &GuidName);
           if (EFI_ERROR (Status)) {
             ShellPrintHiiEx (
               -1, -1, NULL, STRING_TOKEN (STR_DMPSTORE_HEADER_LINE), gShellDebug1HiiHandle,
-- 
2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] ShellPkg: Update the parameter type to match function interface in DmpStore
Posted by Ni, Ruiyu 7 years, 1 month ago 
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Friday, September 22, 2017 2:36 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [edk2] [Patch] ShellPkg: Update the parameter type to match
> function interface in DmpStore
> 
> This fix can resolve CLANG38 build failure.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> index 062ab5d..c2b60fe 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> @@ -522,7 +522,7 @@ CascadeProcessVariables (
>              Status = EFI_OUT_OF_RESOURCES;
>            }
>          } else {
> -          Status = gEfiShellProtocol->GetGuidName(&FoundVarGuid,
> &GuidName);
> +          Status = gEfiShellProtocol->GetGuidName(&FoundVarGuid, (CONST
> CHAR16 **) &GuidName);
>            if (EFI_ERROR (Status)) {
>              ShellPrintHiiEx (
>                -1, -1, NULL, STRING_TOKEN (STR_DMPSTORE_HEADER_LINE),
> gShellDebug1HiiHandle,
> --
> 2.8.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] ShellPkg: Update the parameter type to match function interface in DmpStore
Posted by Carsey, Jaben 7 years, 1 month ago 
Liming,  I agree this works, but I think Laszlo's change to make the GuidName a CONST CHAR makes more sense.

Jaben

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Thursday, September 21, 2017 11:36 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [edk2] [Patch] ShellPkg: Update the parameter type to match
> function interface in DmpStore
> Importance: High
> 
> This fix can resolve CLANG38 build failure.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> index 062ab5d..c2b60fe 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> @@ -522,7 +522,7 @@ CascadeProcessVariables (
>              Status = EFI_OUT_OF_RESOURCES;
>            }
>          } else {
> -          Status = gEfiShellProtocol->GetGuidName(&FoundVarGuid,
> &GuidName);
> +          Status = gEfiShellProtocol->GetGuidName(&FoundVarGuid, (CONST
> CHAR16 **) &GuidName);
>            if (EFI_ERROR (Status)) {
>              ShellPrintHiiEx (
>                -1, -1, NULL, STRING_TOKEN (STR_DMPSTORE_HEADER_LINE),
> gShellDebug1HiiHandle,
> --
> 2.8.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.