1. Patchew
  2. EDK2
  3. View series

[edk2] [Patch] UefiCpuPkg/Lmce.c Remove useless file.

Eric Dong posted 1 patch 6 years, 7 months ago
Failed in applying to current master (apply log)
UefiCpuPkg/Library/CpuCommonFeaturesLib/Lmce.c | 97 --------------------------
1 file changed, 97 deletions(-)
delete mode 100644 UefiCpuPkg/Library/CpuCommonFeaturesLib/Lmce.c
[edk2] [Patch] UefiCpuPkg/Lmce.c Remove useless file.
Posted by Eric Dong 6 years, 7 months ago 
Merge the code to MachineCheck.c file, remove this file.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong <eric.dong@intel.com>
---
 UefiCpuPkg/Library/CpuCommonFeaturesLib/Lmce.c | 97 --------------------------
 1 file changed, 97 deletions(-)
 delete mode 100644 UefiCpuPkg/Library/CpuCommonFeaturesLib/Lmce.c

diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/Lmce.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/Lmce.c
deleted file mode 100644
index bf7e26b..0000000
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/Lmce.c
+++ /dev/null
@@ -1,97 +0,0 @@
-/** @file
-  Local machine check exception feature.
-
-  Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
-  This program and the accompanying materials
-  are licensed and made available under the terms and conditions of the BSD License
-  which accompanies this distribution.  The full text of the license may be found at
-  http://opensource.org/licenses/bsd-license.php
-
-  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-
-**/
-
-#include "CpuCommonFeatures.h"
-
-/**
-  Detects if Local machine check exception feature supported on current 
-  processor.
-
-  @param[in]  ProcessorNumber  The index of the CPU executing this function.
-  @param[in]  CpuInfo          A pointer to the REGISTER_CPU_FEATURE_INFORMATION
-                               structure for the CPU executing this function.
-  @param[in]  ConfigData       A pointer to the configuration buffer returned
-                               by CPU_FEATURE_GET_CONFIG_DATA.  NULL if
-                               CPU_FEATURE_GET_CONFIG_DATA was not provided in
-                               RegisterCpuFeature().
-
-  @retval TRUE     Local machine check exception feature is supported.
-  @retval FALSE    Local machine check exception feature is not supported.
-
-  @note This service could be called by BSP/APs.
-**/
-BOOLEAN
-EFIAPI
-LmceSupport (
-  IN UINTN                             ProcessorNumber,
-  IN REGISTER_CPU_FEATURE_INFORMATION  *CpuInfo,
-  IN VOID                              *ConfigData  OPTIONAL
-  )
-{
-  MSR_IA32_MCG_CAP_REGISTER    McgCap;
-
-  if (!McaSupport (ProcessorNumber, CpuInfo, ConfigData)) {
-    return FALSE;
-  }
-
-  McgCap.Uint64 = AsmReadMsr64 (MSR_IA32_MCG_CAP);
-  if (ProcessorNumber == 0) {
-    DEBUG ((EFI_D_INFO, "LMCE eanble = %x\n", (BOOLEAN) (McgCap.Bits.MCG_LMCE_P != 0)));
-  }
-  return (BOOLEAN) (McgCap.Bits.MCG_LMCE_P != 0);
-}
-
-/**
-  Initializes Local machine check exception feature to specific state.
-
-  @param[in]  ProcessorNumber  The index of the CPU executing this function.
-  @param[in]  CpuInfo          A pointer to the REGISTER_CPU_FEATURE_INFORMATION
-                               structure for the CPU executing this function.
-  @param[in]  ConfigData       A pointer to the configuration buffer returned
-                               by CPU_FEATURE_GET_CONFIG_DATA.  NULL if
-                               CPU_FEATURE_GET_CONFIG_DATA was not provided in
-                               RegisterCpuFeature().
-  @param[in]  State            If TRUE, then the Local machine check exception
-                               feature must be enabled.
-                               If FALSE, then the Local machine check exception
-                               feature must be disabled.
-
-  @retval RETURN_SUCCESS       Local machine check exception feature is initialized.
-
-**/
-RETURN_STATUS
-EFIAPI
-LmceInitialize (
-  IN UINTN                             ProcessorNumber,
-  IN REGISTER_CPU_FEATURE_INFORMATION  *CpuInfo,
-  IN VOID                              *ConfigData,  OPTIONAL
-  IN BOOLEAN                           State
-  )
-{
-  MSR_IA32_FEATURE_CONTROL_REGISTER    *MsrRegister;
-
-  ASSERT (ConfigData != NULL);
-  MsrRegister = (MSR_IA32_FEATURE_CONTROL_REGISTER *) ConfigData;
-  if (MsrRegister[ProcessorNumber].Bits.Lock == 0) {
-    CPU_REGISTER_TABLE_WRITE_FIELD (
-      ProcessorNumber,
-      Msr,
-      MSR_IA32_FEATURE_CONTROL,
-      MSR_IA32_FEATURE_CONTROL_REGISTER,
-      Bits.LmceOn,
-      (State) ? 1 : 0
-      );
-  }
-  return RETURN_SUCCESS;
-}
-- 
2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] UefiCpuPkg/Lmce.c Remove useless file.
Posted by Ni, Ruiyu 6 years, 7 months ago 
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Dong, Eric
> Sent: Friday, September 1, 2017 1:59 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [Patch] UefiCpuPkg/Lmce.c Remove useless file.
> 
> Merge the code to MachineCheck.c file, remove this file.
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
>  UefiCpuPkg/Library/CpuCommonFeaturesLib/Lmce.c | 97 ----------------------
> ----
>  1 file changed, 97 deletions(-)
>  delete mode 100644 UefiCpuPkg/Library/CpuCommonFeaturesLib/Lmce.c
> 
> diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/Lmce.c
> b/UefiCpuPkg/Library/CpuCommonFeaturesLib/Lmce.c
> deleted file mode 100644
> index bf7e26b..0000000
> --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/Lmce.c
> +++ /dev/null
> @@ -1,97 +0,0 @@
> -/** @file
> -  Local machine check exception feature.
> -
> -  Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> -  This program and the accompanying materials
> -  are licensed and made available under the terms and conditions of the BSD
> License
> -  which accompanies this distribution.  The full text of the license may be
> found at
> -  http://opensource.org/licenses/bsd-license.php
> -
> -  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> -  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> -
> -**/
> -
> -#include "CpuCommonFeatures.h"
> -
> -/**
> -  Detects if Local machine check exception feature supported on current
> -  processor.
> -
> -  @param[in]  ProcessorNumber  The index of the CPU executing this
> function.
> -  @param[in]  CpuInfo          A pointer to the
> REGISTER_CPU_FEATURE_INFORMATION
> -                               structure for the CPU executing this function.
> -  @param[in]  ConfigData       A pointer to the configuration buffer returned
> -                               by CPU_FEATURE_GET_CONFIG_DATA.  NULL if
> -                               CPU_FEATURE_GET_CONFIG_DATA was not provided in
> -                               RegisterCpuFeature().
> -
> -  @retval TRUE     Local machine check exception feature is supported.
> -  @retval FALSE    Local machine check exception feature is not supported.
> -
> -  @note This service could be called by BSP/APs.
> -**/
> -BOOLEAN
> -EFIAPI
> -LmceSupport (
> -  IN UINTN                             ProcessorNumber,
> -  IN REGISTER_CPU_FEATURE_INFORMATION  *CpuInfo,
> -  IN VOID                              *ConfigData  OPTIONAL
> -  )
> -{
> -  MSR_IA32_MCG_CAP_REGISTER    McgCap;
> -
> -  if (!McaSupport (ProcessorNumber, CpuInfo, ConfigData)) {
> -    return FALSE;
> -  }
> -
> -  McgCap.Uint64 = AsmReadMsr64 (MSR_IA32_MCG_CAP);
> -  if (ProcessorNumber == 0) {
> -    DEBUG ((EFI_D_INFO, "LMCE eanble = %x\n", (BOOLEAN)
> (McgCap.Bits.MCG_LMCE_P != 0)));
> -  }
> -  return (BOOLEAN) (McgCap.Bits.MCG_LMCE_P != 0); -}
> -
> -/**
> -  Initializes Local machine check exception feature to specific state.
> -
> -  @param[in]  ProcessorNumber  The index of the CPU executing this
> function.
> -  @param[in]  CpuInfo          A pointer to the
> REGISTER_CPU_FEATURE_INFORMATION
> -                               structure for the CPU executing this function.
> -  @param[in]  ConfigData       A pointer to the configuration buffer returned
> -                               by CPU_FEATURE_GET_CONFIG_DATA.  NULL if
> -                               CPU_FEATURE_GET_CONFIG_DATA was not provided in
> -                               RegisterCpuFeature().
> -  @param[in]  State            If TRUE, then the Local machine check exception
> -                               feature must be enabled.
> -                               If FALSE, then the Local machine check exception
> -                               feature must be disabled.
> -
> -  @retval RETURN_SUCCESS       Local machine check exception feature is
> initialized.
> -
> -**/
> -RETURN_STATUS
> -EFIAPI
> -LmceInitialize (
> -  IN UINTN                             ProcessorNumber,
> -  IN REGISTER_CPU_FEATURE_INFORMATION  *CpuInfo,
> -  IN VOID                              *ConfigData,  OPTIONAL
> -  IN BOOLEAN                           State
> -  )
> -{
> -  MSR_IA32_FEATURE_CONTROL_REGISTER    *MsrRegister;
> -
> -  ASSERT (ConfigData != NULL);
> -  MsrRegister = (MSR_IA32_FEATURE_CONTROL_REGISTER *) ConfigData;
> -  if (MsrRegister[ProcessorNumber].Bits.Lock == 0) {
> -    CPU_REGISTER_TABLE_WRITE_FIELD (
> -      ProcessorNumber,
> -      Msr,
> -      MSR_IA32_FEATURE_CONTROL,
> -      MSR_IA32_FEATURE_CONTROL_REGISTER,
> -      Bits.LmceOn,
> -      (State) ? 1 : 0
> -      );
> -  }
> -  return RETURN_SUCCESS;
> -}
> --
> 2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.