[v5] *** BaseTools: Tools change to support MM Interface in PI v1.5 Specification ***

[edk2] [PATCH v5 00/10] *** BaseTools: Tools change to support MM Interface in PI v1.5 Specification ***

Posted by Supreeth Venkatesh 6 years, 10 months ago

*** 
PI v1.5 Specification Volume 4 defines Management Mode Core Interface.
In order to support Management Mode Core Interface, Module Types MM_STANDALONE, MM_CORE_STANDALONE are needed. 
PI specification v1.5 defines the following new file types:
#define EFI_FV_FILETYPE_MM_STANDALONE 0x0E
#define EFI_FV_FILETYPE_MM_CORE_STANDALONE 0x0F
The following changes are necessitated in order to support the above changes to the specification. 

Changes Since v4:
(*) Update Review Comment from Laszlo.
(*) Reword Commit subject for the patches in the set to 
convey meaningful summary. 

Changes Since v3:
(*) Update Review Comments from Liming, Felix.
(*) Directly define FV file types MM_STANDALONE / MM_CORE_STANDALONE
and module types MM_STANDALONE / MM_CORE_STANDALONE
i.e., with MM prefix instead of SMM prefix.

Changes Since v2:
Add missing EFI_FV_FILETYPE_MM_CORE_STANDALONE defined in PI Specification v1.5 VOL3, 
but not defined in VOL4.

Changes Since v1:
Corrected Version check HEX Value "0x00010032" (1 and 50), not 0x0001000A (1 and 10)
***

Supreeth Venkatesh (10):
  BaseTools/GenFfs: add FFS file types for MM modules.
  BaseTools/GenFw: recognize MM file types as EFI Boot Service Drivers.
  BaseTools/AutoGen: auto generate MM template APIs and dependencies.
  BaseTools/Common: add MM Module data types.
  BaseTools/Common: add support in FDF Parser to parse MM Modules.
  BaseTools/CommonDataClass: register MM Modules.
  BaseTools/GenFds: register MM Modules and MM FV file types.
  BaseTools/build: register MM module types with build tools.
  BaseTools/Workspace: check MM module type compatibility with PI
    version.
  BaseTools/Eot: register MM Module types with FFS class.

 BaseTools/Source/C/GenFfs/GenFfs.c                 |   8 +-
 BaseTools/Source/C/GenFw/GenFw.c                   |   5 +-
 BaseTools/Source/C/Include/Common/PiFirmwareFile.h |   2 +
 BaseTools/Source/Python/AutoGen/GenC.py            | 148 ++++++++++++++++++++-
 BaseTools/Source/Python/AutoGen/GenDepex.py        |  17 ++-
 BaseTools/Source/Python/Common/DataType.py         |   4 +-
 BaseTools/Source/Python/Common/FdfParserLite.py    |   4 +-
 .../Source/Python/CommonDataClass/CommonClass.py   |   6 +-
 .../Source/Python/CommonDataClass/PackageClass.py  |   2 +-
 BaseTools/Source/Python/Eot/FvImage.py             |   2 +
 BaseTools/Source/Python/GenFds/FdfParser.py        |   4 +-
 BaseTools/Source/Python/GenFds/Ffs.py              |   8 +-
 BaseTools/Source/Python/GenFds/FfsInfStatement.py  |   3 +
 .../Source/Python/Workspace/WorkspaceDatabase.py   |   5 +
 BaseTools/Source/Python/build/BuildReport.py       |   4 +-
 BaseTools/Source/Python/build/build.py             |   2 +-
 16 files changed, 205 insertions(+), 19 deletions(-)

-- 
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v5 00/10] *** BaseTools: Tools change to support MM Interface in PI v1.5 Specification ***

Posted by Zhu, Yonghong 6 years, 9 months ago

I pushed this series patch.

Best Regards,
Zhu Yonghong


-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Supreeth Venkatesh
Sent: Tuesday, June 27, 2017 12:48 AM
To: edk2-devel@lists.01.org
Cc: jonathan.zhang@cavium.com; Gao, Liming <liming.gao@intel.com>; leif.lindholm@linaro.org; felixp@ami.com; Kinney, Michael D <michael.d.kinney@intel.com>; jbrasen@qti.qualcomm.com
Subject: [edk2] [PATCH v5 00/10] *** BaseTools: Tools change to support MM Interface in PI v1.5 Specification ***

***
PI v1.5 Specification Volume 4 defines Management Mode Core Interface.
In order to support Management Mode Core Interface, Module Types MM_STANDALONE, MM_CORE_STANDALONE are needed. 
PI specification v1.5 defines the following new file types:
#define EFI_FV_FILETYPE_MM_STANDALONE 0x0E #define EFI_FV_FILETYPE_MM_CORE_STANDALONE 0x0F The following changes are necessitated in order to support the above changes to the specification. 

Changes Since v4:
(*) Update Review Comment from Laszlo.
(*) Reword Commit subject for the patches in the set to convey meaningful summary. 

Changes Since v3:
(*) Update Review Comments from Liming, Felix.
(*) Directly define FV file types MM_STANDALONE / MM_CORE_STANDALONE and module types MM_STANDALONE / MM_CORE_STANDALONE i.e., with MM prefix instead of SMM prefix.

Changes Since v2:
Add missing EFI_FV_FILETYPE_MM_CORE_STANDALONE defined in PI Specification v1.5 VOL3, but not defined in VOL4.

Changes Since v1:
Corrected Version check HEX Value "0x00010032" (1 and 50), not 0x0001000A (1 and 10)
***

Supreeth Venkatesh (10):
  BaseTools/GenFfs: add FFS file types for MM modules.
  BaseTools/GenFw: recognize MM file types as EFI Boot Service Drivers.
  BaseTools/AutoGen: auto generate MM template APIs and dependencies.
  BaseTools/Common: add MM Module data types.
  BaseTools/Common: add support in FDF Parser to parse MM Modules.
  BaseTools/CommonDataClass: register MM Modules.
  BaseTools/GenFds: register MM Modules and MM FV file types.
  BaseTools/build: register MM module types with build tools.
  BaseTools/Workspace: check MM module type compatibility with PI
    version.
  BaseTools/Eot: register MM Module types with FFS class.

 BaseTools/Source/C/GenFfs/GenFfs.c                 |   8 +-
 BaseTools/Source/C/GenFw/GenFw.c                   |   5 +-
 BaseTools/Source/C/Include/Common/PiFirmwareFile.h |   2 +
 BaseTools/Source/Python/AutoGen/GenC.py            | 148 ++++++++++++++++++++-
 BaseTools/Source/Python/AutoGen/GenDepex.py        |  17 ++-
 BaseTools/Source/Python/Common/DataType.py         |   4 +-
 BaseTools/Source/Python/Common/FdfParserLite.py    |   4 +-
 .../Source/Python/CommonDataClass/CommonClass.py   |   6 +-
 .../Source/Python/CommonDataClass/PackageClass.py  |   2 +-
 BaseTools/Source/Python/Eot/FvImage.py             |   2 +
 BaseTools/Source/Python/GenFds/FdfParser.py        |   4 +-
 BaseTools/Source/Python/GenFds/Ffs.py              |   8 +-
 BaseTools/Source/Python/GenFds/FfsInfStatement.py  |   3 +
 .../Source/Python/Workspace/WorkspaceDatabase.py   |   5 +
 BaseTools/Source/Python/build/BuildReport.py       |   4 +-
 BaseTools/Source/Python/build/build.py             |   2 +-
 16 files changed, 205 insertions(+), 19 deletions(-)

--
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v5 00/10] *** BaseTools: Tools change to support MM Interface in PI v1.5 Specification ***

Posted by Supreeth Venkatesh 6 years, 9 months ago

Zhu Yonghong,

Thank you.

Supreeth

-----Original Message-----
From: Zhu, Yonghong [mailto:yonghong.zhu@intel.com]
Sent: Thursday, July 6, 2017 9:57 PM
To: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>; edk2-devel@lists.01.org
Cc: jonathan.zhang@cavium.com; Gao, Liming <liming.gao@intel.com>; leif.lindholm@linaro.org; Felixp@ami.com; Kinney, Michael D <michael.d.kinney@intel.com>; jbrasen@qti.qualcomm.com; Zhu, Yonghong <yonghong.zhu@intel.com>
Subject: RE: [edk2] [PATCH v5 00/10] *** BaseTools: Tools change to support MM Interface in PI v1.5 Specification ***

I pushed this series patch.

Best Regards,
Zhu Yonghong

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Supreeth Venkatesh
Sent: Tuesday, June 27, 2017 12:48 AM
To: edk2-devel@lists.01.org
Cc: jonathan.zhang@cavium.com; Gao, Liming <liming.gao@intel.com>; leif.lindholm@linaro.org; felixp@ami.com; Kinney, Michael D <michael.d.kinney@intel.com>; jbrasen@qti.qualcomm.com
Subject: [edk2] [PATCH v5 00/10] *** BaseTools: Tools change to support MM Interface in PI v1.5 Specification ***

***
PI v1.5 Specification Volume 4 defines Management Mode Core Interface.
In order to support Management Mode Core Interface, Module Types MM_STANDALONE, MM_CORE_STANDALONE are needed.
PI specification v1.5 defines the following new file types:
#define EFI_FV_FILETYPE_MM_STANDALONE 0x0E #define EFI_FV_FILETYPE_MM_CORE_STANDALONE 0x0F The following changes are necessitated in order to support the above changes to the specification.

Changes Since v4:
(*) Update Review Comment from Laszlo.
(*) Reword Commit subject for the patches in the set to convey meaningful summary.

Changes Since v3:
(*) Update Review Comments from Liming, Felix.
(*) Directly define FV file types MM_STANDALONE / MM_CORE_STANDALONE and module types MM_STANDALONE / MM_CORE_STANDALONE i.e., with MM prefix instead of SMM prefix.

Changes Since v2:
Add missing EFI_FV_FILETYPE_MM_CORE_STANDALONE defined in PI Specification v1.5 VOL3, but not defined in VOL4.

Changes Since v1:
Corrected Version check HEX Value "0x00010032" (1 and 50), not 0x0001000A (1 and 10)
***

Supreeth Venkatesh (10):
  BaseTools/GenFfs: add FFS file types for MM modules.
  BaseTools/GenFw: recognize MM file types as EFI Boot Service Drivers.
  BaseTools/AutoGen: auto generate MM template APIs and dependencies.
  BaseTools/Common: add MM Module data types.
  BaseTools/Common: add support in FDF Parser to parse MM Modules.
  BaseTools/CommonDataClass: register MM Modules.
  BaseTools/GenFds: register MM Modules and MM FV file types.
  BaseTools/build: register MM module types with build tools.
  BaseTools/Workspace: check MM module type compatibility with PI
    version.
  BaseTools/Eot: register MM Module types with FFS class.

 BaseTools/Source/C/GenFfs/GenFfs.c                 |   8 +-
 BaseTools/Source/C/GenFw/GenFw.c                   |   5 +-
 BaseTools/Source/C/Include/Common/PiFirmwareFile.h |   2 +
 BaseTools/Source/Python/AutoGen/GenC.py            | 148 ++++++++++++++++++++-
 BaseTools/Source/Python/AutoGen/GenDepex.py        |  17 ++-
 BaseTools/Source/Python/Common/DataType.py         |   4 +-
 BaseTools/Source/Python/Common/FdfParserLite.py    |   4 +-
 .../Source/Python/CommonDataClass/CommonClass.py   |   6 +-
 .../Source/Python/CommonDataClass/PackageClass.py  |   2 +-
 BaseTools/Source/Python/Eot/FvImage.py             |   2 +
 BaseTools/Source/Python/GenFds/FdfParser.py        |   4 +-
 BaseTools/Source/Python/GenFds/Ffs.py              |   8 +-
 BaseTools/Source/Python/GenFds/FfsInfStatement.py  |   3 +
 .../Source/Python/Workspace/WorkspaceDatabase.py   |   5 +
 BaseTools/Source/Python/build/BuildReport.py       |   4 +-
 BaseTools/Source/Python/build/build.py             |   2 +-
 16 files changed, 205 insertions(+), 19 deletions(-)

--
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v5 00/10] *** BaseTools: Tools change to support MM Interface in PI v1.5 Specification ***

Posted by Laszlo Ersek 6 years, 10 months ago

On 06/26/17 18:47, Supreeth Venkatesh wrote:
> *** 
> PI v1.5 Specification Volume 4 defines Management Mode Core Interface.
> In order to support Management Mode Core Interface, Module Types MM_STANDALONE, MM_CORE_STANDALONE are needed. 
> PI specification v1.5 defines the following new file types:
> #define EFI_FV_FILETYPE_MM_STANDALONE 0x0E
> #define EFI_FV_FILETYPE_MM_CORE_STANDALONE 0x0F
> The following changes are necessitated in order to support the above changes to the specification. 
> 
> Changes Since v4:
> (*) Update Review Comment from Laszlo.
> (*) Reword Commit subject for the patches in the set to 
> convey meaningful summary. 

Thanks Supreeth, from a quick skim, the subjects look great!

Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel