1. Patchew
  2. EDK2
  3. View series

[edk2] [PATCH] ShellPkg: Fix typo errors in ifconfig help output

Tapan Shah posted 1 patch 6 years, 10 months ago
Failed in applying to current master (apply log)
.../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni    | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
[edk2] [PATCH] ShellPkg: Fix typo errors in ifconfig help output
Posted by Tapan Shah 6 years, 10 months ago 
Found few instances where IPv4 and DHCPv4 spelled incorrectly
as IP4 and DHCP4 respectively.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hpe.com>
---
 .../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni    | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni
index edadcc5..70c3465 100644
--- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni
+++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni
@@ -2,6 +2,7 @@
 //
 // (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR>
 // Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. <BR>
+// (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
 // This program and the accompanying materials
 // are licensed and made available under the terms and conditions of the BSD License
 // which accompanies this distribution. The full text of the license may be found at
@@ -157,7 +158,7 @@
 "     interfaces or the specified interface.\r\n"
 "  4. Use '-s <Name> static <IP> <SubnetMask> <GatewayMask>' with \r\n"
 "     static IPv4 address configuration for specified interface.\r\n"
-"  5. Use '-s <Name> dhcp' for DHCP4 to request the IP4 address\r\n"
+"  5. Use '-s <Name> dhcp' for DHCPv4 to request the IPv4 address\r\n"
 "     configuration dynamically for specified interface.\r\n"
 "  6. Use '-s <Name> dns <IP>' must under manual policy.\r\n"
 ".SH EXAMPLES\r\n"
@@ -166,7 +167,7 @@
 "  * To list the configuration for the eth0 interface:\r\n"
 "    fs0:\> ifconfig -l eth0\r\n"
 " \r\n"
-"  * To use DHCP4 to request the IPv4 address configuration dynamically for the\r\n"
+"  * To use DHCPv4 to request the IPv4 address configuration dynamically for the\r\n"
 "    eth0 interface:\r\n"
 "    fs0:\> ifconfig -s eth0 dhcp\r\n"
 " \r\n"
-- 
1.9.5.msysgit.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] ShellPkg: Fix typo errors in ifconfig help output
Posted by Carsey, Jaben 6 years, 10 months ago 
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Tapan Shah [mailto:tapandshah@hpe.com]
> Sent: Friday, June 09, 2017 10:11 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu
> <ruiyu.ni@intel.com>; Tapan Shah <tapandshah@hpe.com>
> Subject: [PATCH] ShellPkg: Fix typo errors in ifconfig help output
> Importance: High
> 
> Found few instances where IPv4 and DHCPv4 spelled incorrectly
> as IP4 and DHCP4 respectively.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Tapan Shah <tapandshah@hpe.com>
> ---
>  .../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni
> | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> index edadcc5..70c3465 100644
> ---
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> +++
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> @@ -2,6 +2,7 @@
>  //
>  // (C) Copyright 2013-2015 Hewlett-Packard Development Company,
> L.P.<BR>
>  // Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. <BR>
> +// (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
>  // This program and the accompanying materials
>  // are licensed and made available under the terms and conditions of the
> BSD License
>  // which accompanies this distribution. The full text of the license may be
> found at
> @@ -157,7 +158,7 @@
>  "     interfaces or the specified interface.\r\n"
>  "  4. Use '-s <Name> static <IP> <SubnetMask> <GatewayMask>' with \r\n"
>  "     static IPv4 address configuration for specified interface.\r\n"
> -"  5. Use '-s <Name> dhcp' for DHCP4 to request the IP4 address\r\n"
> +"  5. Use '-s <Name> dhcp' for DHCPv4 to request the IPv4 address\r\n"
>  "     configuration dynamically for specified interface.\r\n"
>  "  6. Use '-s <Name> dns <IP>' must under manual policy.\r\n"
>  ".SH EXAMPLES\r\n"
> @@ -166,7 +167,7 @@
>  "  * To list the configuration for the eth0 interface:\r\n"
>  "    fs0:\> ifconfig -l eth0\r\n"
>  " \r\n"
> -"  * To use DHCP4 to request the IPv4 address configuration dynamically for
> the\r\n"
> +"  * To use DHCPv4 to request the IPv4 address configuration dynamically
> for the\r\n"
>  "    eth0 interface:\r\n"
>  "    fs0:\> ifconfig -s eth0 dhcp\r\n"
>  " \r\n"
> --
> 1.9.5.msysgit.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.