BaseTools: fix the typo in function name LanuchPostbuild

[edk2] [Patch] BaseTools: fix the typo in function name LanuchPostbuild

Posted by Yonghong Zhu 7 years, 6 months ago

From: Nikolai SAOUKH <nms@otdel-1.org>

The patch fix function name typo LanuchPostbuild ==> LaunchPostbuild.

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Nikolai SAOUKH <nms@otdel-1.org>
---
 BaseTools/Source/Python/build/build.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py
index 35e7037..45ccac1 100644
--- a/BaseTools/Source/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py
@@ -987,11 +987,10 @@ class Build():
                 PostbuildList[0] = mws.join(self.WorkspaceDir, PostbuildList[0])
             if os.path.isfile(PostbuildList[0]):
                 self.PostbuildScript = PostbuildList[0]
                 self.Postbuild = ' '.join(PostbuildList)
                 self.Postbuild += self.PassCommandOption(self.BuildTargetList, self.ArchList, self.ToolChainList)
-                #self.LanuchPostbuild()
             else:
                 EdkLogger.error("Postbuild", POSTBUILD_ERROR, "the postbuild script %s is not exist.\n If you'd like to disable the Postbuild process, please use the format: -D POSTBUILD=\"\" " %(PostbuildList[0]))
 
     def PassCommandOption(self, BuildTarget, TargetArch, ToolChain):
         BuildStr = ''
@@ -1074,11 +1073,11 @@ class Build():
                 envs = itertools.ifilter(lambda l: len(l) == 2, envs)
                 envs = itertools.imap(lambda l: [i.strip() for i in l], envs)
                 os.environ.update(dict(envs))
             EdkLogger.info("\n- Prebuild Done -\n")
 
-    def LanuchPostbuild(self):
+    def LaunchPostbuild(self):
         if self.Postbuild:
             EdkLogger.info("\n- Postbuild Start -\n")
             if sys.platform == "win32":
                 Process = Popen(self.Postbuild, stdout=PIPE, stderr=PIPE)
             else:
@@ -2329,11 +2328,11 @@ def Main():
         Utils.Progressor.Abort()
         Utils.ClearDuplicatedInf()
 
     if ReturnCode == 0:
         try:
-            MyBuild.LanuchPostbuild()
+            MyBuild.LaunchPostbuild()
             Conclusion = "Done"
         except:
             Conclusion = "Failed"
     elif ReturnCode == ABORT_ERROR:
         Conclusion = "Aborted"
-- 
2.6.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] BaseTools: fix the typo in function name LanuchPostbuild

Posted by Gao, Liming 7 years, 6 months ago

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Zhu, Yonghong
>Sent: Wednesday, April 26, 2017 4:57 PM
>To: edk2-devel@lists.01.org
>Cc: Nikolai SAOUKH <nms@otdel-1.org>; Gao, Liming <liming.gao@intel.com>
>Subject: [Patch] BaseTools: fix the typo in function name LanuchPostbuild
>
>From: Nikolai SAOUKH <nms@otdel-1.org>
>
>The patch fix function name typo LanuchPostbuild ==> LaunchPostbuild.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Nikolai SAOUKH <nms@otdel-1.org>
>---
> BaseTools/Source/Python/build/build.py | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/BaseTools/Source/Python/build/build.py
>b/BaseTools/Source/Python/build/build.py
>index 35e7037..45ccac1 100644
>--- a/BaseTools/Source/Python/build/build.py
>+++ b/BaseTools/Source/Python/build/build.py
>@@ -987,11 +987,10 @@ class Build():
>                 PostbuildList[0] = mws.join(self.WorkspaceDir, PostbuildList[0])
>             if os.path.isfile(PostbuildList[0]):
>                 self.PostbuildScript = PostbuildList[0]
>                 self.Postbuild = ' '.join(PostbuildList)
>                 self.Postbuild += self.PassCommandOption(self.BuildTargetList,
>self.ArchList, self.ToolChainList)
>-                #self.LanuchPostbuild()
>             else:
>                 EdkLogger.error("Postbuild", POSTBUILD_ERROR, "the postbuild
>script %s is not exist.\n If you'd like to disable the Postbuild process, please
>use the format: -D POSTBUILD=\"\" " %(PostbuildList[0]))
>
>     def PassCommandOption(self, BuildTarget, TargetArch, ToolChain):
>         BuildStr = ''
>@@ -1074,11 +1073,11 @@ class Build():
>                 envs = itertools.ifilter(lambda l: len(l) == 2, envs)
>                 envs = itertools.imap(lambda l: [i.strip() for i in l], envs)
>                 os.environ.update(dict(envs))
>             EdkLogger.info("\n- Prebuild Done -\n")
>
>-    def LanuchPostbuild(self):
>+    def LaunchPostbuild(self):
>         if self.Postbuild:
>             EdkLogger.info("\n- Postbuild Start -\n")
>             if sys.platform == "win32":
>                 Process = Popen(self.Postbuild, stdout=PIPE, stderr=PIPE)
>             else:
>@@ -2329,11 +2328,11 @@ def Main():
>         Utils.Progressor.Abort()
>         Utils.ClearDuplicatedInf()
>
>     if ReturnCode == 0:
>         try:
>-            MyBuild.LanuchPostbuild()
>+            MyBuild.LaunchPostbuild()
>             Conclusion = "Done"
>         except:
>             Conclusion = "Failed"
>     elif ReturnCode == ABORT_ERROR:
>         Conclusion = "Aborted"
>--
>2.6.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel