[edk2] [ edk2-DecSpecification PATCH 0/4] Add support for Private declarations in a package

Michael Kinney posted 4 patches 7 years, 6 months ago
Failed in applying to current master (apply log)
2_dec_file_overview/24_[defines]_usage.md          |   2 +-
2_dec_file_overview/25_[includes]_usage.md         |  24 ++-
2_dec_file_overview/26_[guids]_usage.md            |  22 ++-
2_dec_file_overview/27_[protocols]_usage.md        |  24 ++-
2_dec_file_overview/28_[ppis]_usage.md             |  24 ++-
3_edk_ii_dec_file_format/34_[defines]_section.md   |  28 ++-
3_edk_ii_dec_file_format/35_[includes]_sections.md |  30 ++-
3_edk_ii_dec_file_format/36_[guids]_sections.md    |  29 ++-
.../37_[protocols]_sections.md                     |  29 ++-
3_edk_ii_dec_file_format/38_[ppis]_sections.md     |  29 ++-
README.md                                          | 211 +++++++++++----------
11 files changed, 329 insertions(+), 123 deletions(-)
[edk2] [ edk2-DecSpecification PATCH 0/4] Add support for Private declarations in a package
Posted by Michael Kinney 7 years, 6 months ago
https://bugzilla.tianocore.org/show_bug.cgi?id=465
https://bugzilla.tianocore.org/show_bug.cgi?id=482

GitHub word diff view of the patches in this series

* [1/4] https://github.com/mdkinney/edk2-DecSpecification/commit/24a07ae89ef0467c9009633d19d24bb1ba2e115a?w=1
* [2/4] https://github.com/mdkinney/edk2-DecSpecification/commit/65f49d1d86439b6144ff82217349a5145ec42ef0?w=1
* [3/4] https://github.com/mdkinney/edk2-DecSpecification/commit/a28fd82b07521fc7412be75b159a44a0dd3bf1b1?w=1
* [4/4] https://github.com/mdkinney/edk2-DecSpecification/commit/c04e668af9e1aa8c8e49d73fede6df7287b7d454?w=1

Remove trailing spaces from README.md 

Update DEC_SPECIFCATION to 0x0001001A / 1.26 

Add new syntax to the DEC file for specifying
information that can only be used by modules
within the package. When modules outside the
packages attempt to use this content, the EDK
II build system must break with an error
regarding content not found.

The four sections, Includes, Ppis, Guids and
Protocols headers will be modified with a keyword,
Private following the architecture modifier. If
Private is not present, then the content is usable
by modules outside the package.

Clarify restriction that an element is not allowed
to be declared with and without Private modifier.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>


Michael Kinney (4):
  Remove trailing spaces from README.MD
  Update version from 1.25 to 1.26
  Add support for Private declarations in a package
  Declarations not allowed to be both public and private

 2_dec_file_overview/24_[defines]_usage.md          |   2 +-
 2_dec_file_overview/25_[includes]_usage.md         |  24 ++-
 2_dec_file_overview/26_[guids]_usage.md            |  22 ++-
 2_dec_file_overview/27_[protocols]_usage.md        |  24 ++-
 2_dec_file_overview/28_[ppis]_usage.md             |  24 ++-
 3_edk_ii_dec_file_format/34_[defines]_section.md   |  28 ++-
 3_edk_ii_dec_file_format/35_[includes]_sections.md |  30 ++-
 3_edk_ii_dec_file_format/36_[guids]_sections.md    |  29 ++-
 .../37_[protocols]_sections.md                     |  29 ++-
 3_edk_ii_dec_file_format/38_[ppis]_sections.md     |  29 ++-
 README.md                                          | 211 +++++++++++----------
 11 files changed, 329 insertions(+), 123 deletions(-)

-- 
2.6.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [ edk2-DecSpecification PATCH 0/4] Add support for Private declarations in a package
Posted by Zhu, Yonghong 7 years, 6 months ago
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: Kinney, Michael D 
Sent: Tuesday, April 25, 2017 9:10 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>; Shaw, Kevin W <kevin.w.shaw@intel.com>
Subject: [ edk2-DecSpecification PATCH 0/4] Add support for Private declarations in a package

https://bugzilla.tianocore.org/show_bug.cgi?id=465
https://bugzilla.tianocore.org/show_bug.cgi?id=482

GitHub word diff view of the patches in this series

* [1/4] https://github.com/mdkinney/edk2-DecSpecification/commit/24a07ae89ef0467c9009633d19d24bb1ba2e115a?w=1
* [2/4] https://github.com/mdkinney/edk2-DecSpecification/commit/65f49d1d86439b6144ff82217349a5145ec42ef0?w=1
* [3/4] https://github.com/mdkinney/edk2-DecSpecification/commit/a28fd82b07521fc7412be75b159a44a0dd3bf1b1?w=1
* [4/4] https://github.com/mdkinney/edk2-DecSpecification/commit/c04e668af9e1aa8c8e49d73fede6df7287b7d454?w=1

Remove trailing spaces from README.md 

Update DEC_SPECIFCATION to 0x0001001A / 1.26 

Add new syntax to the DEC file for specifying information that can only be used by modules within the package. When modules outside the packages attempt to use this content, the EDK II build system must break with an error regarding content not found.

The four sections, Includes, Ppis, Guids and Protocols headers will be modified with a keyword, Private following the architecture modifier. If Private is not present, then the content is usable by modules outside the package.

Clarify restriction that an element is not allowed to be declared with and without Private modifier.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>


Michael Kinney (4):
  Remove trailing spaces from README.MD
  Update version from 1.25 to 1.26
  Add support for Private declarations in a package
  Declarations not allowed to be both public and private

 2_dec_file_overview/24_[defines]_usage.md          |   2 +-
 2_dec_file_overview/25_[includes]_usage.md         |  24 ++-
 2_dec_file_overview/26_[guids]_usage.md            |  22 ++-
 2_dec_file_overview/27_[protocols]_usage.md        |  24 ++-
 2_dec_file_overview/28_[ppis]_usage.md             |  24 ++-
 3_edk_ii_dec_file_format/34_[defines]_section.md   |  28 ++-
 3_edk_ii_dec_file_format/35_[includes]_sections.md |  30 ++-
 3_edk_ii_dec_file_format/36_[guids]_sections.md    |  29 ++-
 .../37_[protocols]_sections.md                     |  29 ++-
 3_edk_ii_dec_file_format/38_[ppis]_sections.md     |  29 ++-
 README.md                                          | 211 +++++++++++----------
 11 files changed, 329 insertions(+), 123 deletions(-)

--
2.6.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [ edk2-DecSpecification PATCH 0/4] Add support for Private declarations in a package
Posted by Laszlo Ersek 7 years, 6 months ago
On 04/25/17 03:10, Michael Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=465
> https://bugzilla.tianocore.org/show_bug.cgi?id=482
> 
> GitHub word diff view of the patches in this series
> 
> * [1/4] https://github.com/mdkinney/edk2-DecSpecification/commit/24a07ae89ef0467c9009633d19d24bb1ba2e115a?w=1
> * [2/4] https://github.com/mdkinney/edk2-DecSpecification/commit/65f49d1d86439b6144ff82217349a5145ec42ef0?w=1
> * [3/4] https://github.com/mdkinney/edk2-DecSpecification/commit/a28fd82b07521fc7412be75b159a44a0dd3bf1b1?w=1
> * [4/4] https://github.com/mdkinney/edk2-DecSpecification/commit/c04e668af9e1aa8c8e49d73fede6df7287b7d454?w=1
> 
> Remove trailing spaces from README.md 
> 
> Update DEC_SPECIFCATION to 0x0001001A / 1.26 
> 
> Add new syntax to the DEC file for specifying
> information that can only be used by modules
> within the package. When modules outside the
> packages attempt to use this content, the EDK
> II build system must break with an error
> regarding content not found.
> 
> The four sections, Includes, Ppis, Guids and
> Protocols headers will be modified with a keyword,
> Private following the architecture modifier. If
> Private is not present, then the content is usable
> by modules outside the package.
> 
> Clarify restriction that an element is not allowed
> to be declared with and without Private modifier.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
> 
> 
> Michael Kinney (4):
>   Remove trailing spaces from README.MD
>   Update version from 1.25 to 1.26
>   Add support for Private declarations in a package
>   Declarations not allowed to be both public and private
> 
>  2_dec_file_overview/24_[defines]_usage.md          |   2 +-
>  2_dec_file_overview/25_[includes]_usage.md         |  24 ++-
>  2_dec_file_overview/26_[guids]_usage.md            |  22 ++-
>  2_dec_file_overview/27_[protocols]_usage.md        |  24 ++-
>  2_dec_file_overview/28_[ppis]_usage.md             |  24 ++-
>  3_edk_ii_dec_file_format/34_[defines]_section.md   |  28 ++-
>  3_edk_ii_dec_file_format/35_[includes]_sections.md |  30 ++-
>  3_edk_ii_dec_file_format/36_[guids]_sections.md    |  29 ++-
>  .../37_[protocols]_sections.md                     |  29 ++-
>  3_edk_ii_dec_file_format/38_[ppis]_sections.md     |  29 ++-
>  README.md                                          | 211 +++++++++++----------
>  11 files changed, 329 insertions(+), 123 deletions(-)
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel