1. Patchew
  2. EDK2
  3. View series

[edk2] [Patch] MdeModulePkg/Ip4Dxe: Refine the IPv4 configuration help info

Jiaxin Wu posted 1 patch 7 years, 6 months ago
Failed in applying to current master (apply log)
MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2.vfr    | 4 ++--
MdeModulePkg/Universal/Network/Ip4Dxe/Ip4DxeStrings.uni | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
[edk2] [Patch] MdeModulePkg/Ip4Dxe: Refine the IPv4 configuration help info
Posted by Jiaxin Wu 7 years, 6 months ago 
Below value indicate whether network address configured successfully
or not:
Network Device List->MAC->IPv4 Network Configuration->Configured.

This patch is to refine its help info.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2.vfr    | 4 ++--
 MdeModulePkg/Universal/Network/Ip4Dxe/Ip4DxeStrings.uni | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2.vfr b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2.vfr
index a18db22..1f45e9f 100644
--- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2.vfr
+++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2.vfr
@@ -1,9 +1,9 @@
 /** @file
   Vfr file for IP4Dxe.
 
-Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
 http://opensource.org/licenses/bsd-license.php
 
@@ -29,11 +29,11 @@ formset
   form formid = FORMID_MAIN_FORM,
     title  = STRING_TOKEN(STR_IP4_DEVICE_FORM_TITLE);
 
     checkbox varid = IP4_CONFIG2_IFR_NVDATA.Configure,
             prompt = STRING_TOKEN(STR_IP4_CONFIGURE),
-            help   = STRING_TOKEN(STR_IP4_CONFIGURE),
+            help   = STRING_TOKEN(STR_IP4_CONFIGURE_HELP),
             flags  = INTERACTIVE,
             key    = KEY_ENABLE,
     endcheckbox;
 
     suppressif ideqval IP4_CONFIG2_IFR_NVDATA.Configure == 0x00;
diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4DxeStrings.uni b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4DxeStrings.uni
index a491378..0546cea 100644
--- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4DxeStrings.uni
+++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4DxeStrings.uni
@@ -1,9 +1,9 @@
 // /** @file
 //   String definitions for Ip4Config2 formset
 
-// Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
+// Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR>
 // This program and the accompanying materials
 // are licensed and made available under the terms and conditions of the BSD License
 // which accompanies this distribution.  The full text of the license may be found at
 // http://opensource.org/licenses/bsd-license.php
 //
@@ -20,10 +20,11 @@
 #string STR_IP4_CONFIG2_FORM_TITLE    #language en-US "IPv4 Network Configuration"
 #string STR_IP4_CONFIG2_FORM_HELP     #language en-US "Configure network parameters."
 #string STR_IP4_DEVICE_FORM_TITLE     #language en-US ""
 #string STR_IP4_DEVICE_FORM_HELP      #language en-US ""
 #string STR_IP4_CONFIGURE             #language en-US "Configured"
+#string STR_IP4_CONFIGURE_HELP        #language en-US "Indicate whether network address configured successfully or not."
 #string STR_IP4_ENABLE_DHCP           #language en-US "Enable DHCP"
 #string STR_IP4_LOCAL_IP_ADDRESS      #language en-US "Local IP Address"
 #string STR_IP4_IP_ADDRESS_HELP       #language en-US "Enter IP address in dotted-decimal notation. Example: 192.168.10.12\r\n"
 #string STR_IP4_LOCAL_MASK            #language en-US "Local NetMask"
 #string STR_IP4_MASK_HELP             #language en-US "Enter NetMask in dotted-decimal notation. Example: 255.255.255.0\r\n"
-- 
1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Refine the IPv4 configuration help info
Posted by Ye, Ting 7 years, 6 months ago 
Reviewed-by: Ye Ting <ting.ye@intel.com> 

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jiaxin Wu
Sent: Friday, April 21, 2017 12:58 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Refine the IPv4 configuration help info

Below value indicate whether network address configured successfully or not:
Network Device List->MAC->IPv4 Network Configuration->Configured.

This patch is to refine its help info.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2.vfr    | 4 ++--
 MdeModulePkg/Universal/Network/Ip4Dxe/Ip4DxeStrings.uni | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2.vfr b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2.vfr
index a18db22..1f45e9f 100644
--- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2.vfr
+++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2.vfr
@@ -1,9 +1,9 @@
 /** @file
   Vfr file for IP4Dxe.
 
-Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials  are licensed and made available under the terms and conditions of the BSD License  which accompanies this distribution.  The full text of the license may be found at  http://opensource.org/licenses/bsd-license.php
 
@@ -29,11 +29,11 @@ formset
   form formid = FORMID_MAIN_FORM,
     title  = STRING_TOKEN(STR_IP4_DEVICE_FORM_TITLE);
 
     checkbox varid = IP4_CONFIG2_IFR_NVDATA.Configure,
             prompt = STRING_TOKEN(STR_IP4_CONFIGURE),
-            help   = STRING_TOKEN(STR_IP4_CONFIGURE),
+            help   = STRING_TOKEN(STR_IP4_CONFIGURE_HELP),
             flags  = INTERACTIVE,
             key    = KEY_ENABLE,
     endcheckbox;
 
     suppressif ideqval IP4_CONFIG2_IFR_NVDATA.Configure == 0x00; diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4DxeStrings.uni b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4DxeStrings.uni
index a491378..0546cea 100644
--- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4DxeStrings.uni
+++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4DxeStrings.uni
@@ -1,9 +1,9 @@
 // /** @file
 //   String definitions for Ip4Config2 formset
 
-// Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
+// Copyright (c) 2015 - 2017, Intel Corporation. All rights 
+reserved.<BR>
 // This program and the accompanying materials  // are licensed and made available under the terms and conditions of the BSD License  // which accompanies this distribution.  The full text of the license may be found at  // http://opensource.org/licenses/bsd-license.php
 //
@@ -20,10 +20,11 @@
 #string STR_IP4_CONFIG2_FORM_TITLE    #language en-US "IPv4 Network Configuration"
 #string STR_IP4_CONFIG2_FORM_HELP     #language en-US "Configure network parameters."
 #string STR_IP4_DEVICE_FORM_TITLE     #language en-US ""
 #string STR_IP4_DEVICE_FORM_HELP      #language en-US ""
 #string STR_IP4_CONFIGURE             #language en-US "Configured"
+#string STR_IP4_CONFIGURE_HELP        #language en-US "Indicate whether network address configured successfully or not."
 #string STR_IP4_ENABLE_DHCP           #language en-US "Enable DHCP"
 #string STR_IP4_LOCAL_IP_ADDRESS      #language en-US "Local IP Address"
 #string STR_IP4_IP_ADDRESS_HELP       #language en-US "Enter IP address in dotted-decimal notation. Example: 192.168.10.12\r\n"
 #string STR_IP4_LOCAL_MASK            #language en-US "Local NetMask"
 #string STR_IP4_MASK_HELP             #language en-US "Enter NetMask in dotted-decimal notation. Example: 255.255.255.0\r\n"
--
1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.