[v1] MdeModulePkg BrotliLib: Fix the regression logic issue in loop

[edk2] [Patch] MdeModulePkg BrotliLib: Fix the regression logic issue in loop

Liming Gao posted 1 patch 7 years, 6 months ago

Diff against v2
Download mbox

Failed in applying to current master (apply log)

There is a newer version of this series

MdeModulePkg/Library/BrotliCustomDecompressLib/dec/decode.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

Expand all Fold all

[edk2] [Patch] MdeModulePkg BrotliLib: Fix the regression logic issue in loop

Posted by Liming Gao 7 years, 6 months ago

Roll back to previous logic, and use point + offset to get byte value.

Cc: Bell Song <binx.song@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 MdeModulePkg/Library/BrotliCustomDecompressLib/dec/decode.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/MdeModulePkg/Library/BrotliCustomDecompressLib/dec/decode.c b/MdeModulePkg/Library/BrotliCustomDecompressLib/dec/decode.c
index 67f0ff2..420d1bb 100644
--- a/MdeModulePkg/Library/BrotliCustomDecompressLib/dec/decode.c
+++ b/MdeModulePkg/Library/BrotliCustomDecompressLib/dec/decode.c
@@ -872,14 +872,14 @@ static BROTLI_NOINLINE void InverseMoveToFrontTransform(
   upper_bound = 0;
   for (i = 0; i < v_len; ++i) {
     int index = v[i];
-    uint8_t value = mtf[index];
+    uint8_t value = *(mtf + index);
     upper_bound |= (uint32_t)v[i];
     v[i] = value;
-    mtf[-1] = value;
-    while (index > 0) {
+    *(mtf - 1) = value;
+    do {
       index--;
-      mtf[index + 1] = mtf[index];
-    }
+      *(mtf + index + 1) = *(mtf + index);
+    } while (index >= 0);
   }
   /* Remember amount of elements to be reinitialized. */
   state->mtf_upper_bound = upper_bound;
-- 
2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel