[edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option

Liming Gao posted 1 patch 7 years, 7 months ago
Failed in applying to current master (apply log)
MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 1 -
1 file changed, 1 deletion(-)
[edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option
Posted by Liming Gao 7 years, 7 months ago
GCC -fno-builtin option is added into tools_def.template. So, there is
no need to set it in module INF file.

Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
index cfe42a6..d4d9a83 100644
--- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
+++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
@@ -81,7 +81,6 @@
   MSFT:DEBUG_*_IPF_CC_FLAGS    == /nologo /c /WX /GS- /W4 /EHs-c- /GR- /Gy /Os /FIAutoGen.h /QIPF_fr32 /Zi /X 
   MSFT:RELEASE_*_IPF_CC_FLAGS  == /nologo /c /WX /GS- /W4 /EHs-c- /GR- /Gy /Os /FIAutoGen.h /QIPF_fr32 /X 
   INTEL:*_*_*_CC_FLAGS         =  /Oi-
-  GCC:*_*_*_CC_FLAGS           =  -fno-builtin
 
   # Oniguruma: potentially uninitialized local variable used
   MSFT:*_*_*_CC_FLAGS = /wd4701
-- 
2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option
Posted by Zeng, Star 7 years, 7 months ago
How about to indicate the SHA-1: 90defe7198a42b3157ae5d9b93714f891cf06e57 in the commit log like below?

GCC -fno-builtin option is added into tools_def.template at
90defe7198a42b3157ae5d9b93714f891cf06e57.
So, there is no need to set it in module INF file.

Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao
Sent: Thursday, April 6, 2017 4:15 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option

GCC -fno-builtin option is added into tools_def.template. So, there is no need to set it in module INF file.

Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
index cfe42a6..d4d9a83 100644
--- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
+++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.i
+++ nf
@@ -81,7 +81,6 @@
   MSFT:DEBUG_*_IPF_CC_FLAGS    == /nologo /c /WX /GS- /W4 /EHs-c- /GR- /Gy /Os /FIAutoGen.h /QIPF_fr32 /Zi /X 
   MSFT:RELEASE_*_IPF_CC_FLAGS  == /nologo /c /WX /GS- /W4 /EHs-c- /GR- /Gy /Os /FIAutoGen.h /QIPF_fr32 /X 
   INTEL:*_*_*_CC_FLAGS         =  /Oi-
-  GCC:*_*_*_CC_FLAGS           =  -fno-builtin
 
   # Oniguruma: potentially uninitialized local variable used
   MSFT:*_*_*_CC_FLAGS = /wd4701
--
2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel