1. Patchew
  2. EDK2
  3. [edk2] [PATCH v2 0/4] ArmVirtPkg: make DT vs ACPI support mutually exclusive
  4. View patch

[edk2] [PATCH v2 1/4] ArmVirtPkg/FdtClientDxe: supplement missing EFIAPI calling conv specifiers

Ard Biesheuvel posted 4 patches 7 years, 7 months ago
[edk2] [PATCH v2 1/4] ArmVirtPkg/FdtClientDxe: supplement missing EFIAPI calling conv specifiers
Posted by Ard Biesheuvel 7 years, 7 months ago 
From: Laszlo Ersek <lersek@redhat.com>

Add missing EFIAPI calling convention specifiers to STATIC function
that are exposed via the FdtClientProtocol interface.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
index 7cc0c44ca12a..547a29fce62c 100644
--- a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
+++ b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
@@ -29,6 +29,7 @@ STATIC VOID  *mDeviceTreeBase;
 
 STATIC
 EFI_STATUS
+EFIAPI
 GetNodeProperty (
   IN  FDT_CLIENT_PROTOCOL     *This,
   IN  INT32                   Node,
@@ -55,6 +56,7 @@ GetNodeProperty (
 
 STATIC
 EFI_STATUS
+EFIAPI
 SetNodeProperty (
   IN  FDT_CLIENT_PROTOCOL     *This,
   IN  INT32                   Node,
@@ -267,6 +269,7 @@ FindMemoryNodeReg (
 
 STATIC
 EFI_STATUS
+EFIAPI
 GetOrInsertChosenNode (
   IN  FDT_CLIENT_PROTOCOL     *This,
   OUT INT32                   *Node
-- 
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v2 1/4] ArmVirtPkg/FdtClientDxe: supplement missing EFIAPI calling conv specifiers
Posted by Laszlo Ersek 7 years, 7 months ago 
On 03/09/17 18:21, Ard Biesheuvel wrote:
> From: Laszlo Ersek <lersek@redhat.com>
> 
> Add missing EFIAPI calling convention specifiers to STATIC function
> that are exposed via the FdtClientProtocol interface.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
> index 7cc0c44ca12a..547a29fce62c 100644
> --- a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
> +++ b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
> @@ -29,6 +29,7 @@ STATIC VOID  *mDeviceTreeBase;
>  
>  STATIC
>  EFI_STATUS
> +EFIAPI
>  GetNodeProperty (
>    IN  FDT_CLIENT_PROTOCOL     *This,
>    IN  INT32                   Node,
> @@ -55,6 +56,7 @@ GetNodeProperty (
>  
>  STATIC
>  EFI_STATUS
> +EFIAPI
>  SetNodeProperty (
>    IN  FDT_CLIENT_PROTOCOL     *This,
>    IN  INT32                   Node,
> @@ -267,6 +269,7 @@ FindMemoryNodeReg (
>  
>  STATIC
>  EFI_STATUS
> +EFIAPI
>  GetOrInsertChosenNode (
>    IN  FDT_CLIENT_PROTOCOL     *This,
>    OUT INT32                   *Node
> 

Well, I can't exactly "review" or "ACK" my own patch (or patches mostly
derived from my patches). Leif, can you pls R-b this?

Thanks
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v2 1/4] ArmVirtPkg/FdtClientDxe: supplement missing EFIAPI calling conv specifiers
Posted by Leif Lindholm 7 years, 7 months ago 
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

On 9 Mar 2017 6:29 pm, "Laszlo Ersek" <lersek@redhat.com> wrote:

> On 03/09/17 18:21, Ard Biesheuvel wrote:
> > From: Laszlo Ersek <lersek@redhat.com>
> >
> > Add missing EFIAPI calling convention specifiers to STATIC function
> > that are exposed via the FdtClientProtocol interface.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> >  ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
> b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
> > index 7cc0c44ca12a..547a29fce62c 100644
> > --- a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
> > +++ b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
> > @@ -29,6 +29,7 @@ STATIC VOID  *mDeviceTreeBase;
> >
> >  STATIC
> >  EFI_STATUS
> > +EFIAPI
> >  GetNodeProperty (
> >    IN  FDT_CLIENT_PROTOCOL     *This,
> >    IN  INT32                   Node,
> > @@ -55,6 +56,7 @@ GetNodeProperty (
> >
> >  STATIC
> >  EFI_STATUS
> > +EFIAPI
> >  SetNodeProperty (
> >    IN  FDT_CLIENT_PROTOCOL     *This,
> >    IN  INT32                   Node,
> > @@ -267,6 +269,7 @@ FindMemoryNodeReg (
> >
> >  STATIC
> >  EFI_STATUS
> > +EFIAPI
> >  GetOrInsertChosenNode (
> >    IN  FDT_CLIENT_PROTOCOL     *This,
> >    OUT INT32                   *Node
> >
>
> Well, I can't exactly "review" or "ACK" my own patch (or patches mostly
> derived from my patches). Leif, can you pls R-b this?
>
> Thanks
> Laszlo
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.