NetworkPkg/HttpBootDxe: Declare the functions as EFIAPI to pass the GCC build

[edk2] [Patch] NetworkPkg/HttpBootDxe: Declare the functions as EFIAPI to pass the GCC build

Posted by Jiaxin Wu 7 years, 2 months ago

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 NetworkPkg/HttpBootDxe/HttpBootSupport.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.c b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
index d786d72..e831df9 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
@@ -629,10 +629,11 @@ HttpBootSetHeader (
 
   @param[in]  Context         The opaque parameter to the function.
 
 **/
 VOID
+EFIAPI
 HttpIoNotifyDpc (
   IN VOID                *Context
   )
 {
   *((BOOLEAN *) Context) = TRUE;
@@ -644,10 +645,11 @@ HttpIoNotifyDpc (
   @param[in]  Event                 The event signaled.
   @param[in]  Context               The opaque parameter to the function.
 
 **/
 VOID
+EFIAPI
 HttpIoNotify (
   IN EFI_EVENT              Event,
   IN VOID                   *Context
   )
 {
-- 
1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] NetworkPkg/HttpBootDxe: Declare the functions as EFIAPI to pass the GCC build

Posted by Laszlo Ersek 7 years, 2 months ago

On 02/16/17 02:19, Jiaxin Wu wrote:
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  NetworkPkg/HttpBootDxe/HttpBootSupport.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Build-tested-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo

> 
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.c b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> index d786d72..e831df9 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> @@ -629,10 +629,11 @@ HttpBootSetHeader (
>  
>    @param[in]  Context         The opaque parameter to the function.
>  
>  **/
>  VOID
> +EFIAPI
>  HttpIoNotifyDpc (
>    IN VOID                *Context
>    )
>  {
>    *((BOOLEAN *) Context) = TRUE;
> @@ -644,10 +645,11 @@ HttpIoNotifyDpc (
>    @param[in]  Event                 The event signaled.
>    @param[in]  Context               The opaque parameter to the function.
>  
>  **/
>  VOID
> +EFIAPI
>  HttpIoNotify (
>    IN EFI_EVENT              Event,
>    IN VOID                   *Context
>    )
>  {
> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] NetworkPkg/HttpBootDxe: Declare the functions as EFIAPI to pass the GCC build

Posted by Wu, Jiaxin 7 years, 2 months ago

Commit:

https://github.com/tianocore/edk2/commit/6c6452c6e23a89be0e565501500e83c136e3fcbd

Thanks,
Jiaxin

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Thursday, February 16, 2017 5:58 PM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel@ml01.01.org
> Cc: Gerd Hoffmann <kraxel@redhat.com>; Ye, Ting <ting.ye@intel.com>; Fu,
> Siyuan <siyuan.fu@intel.com>
> Subject: Re: [Patch] NetworkPkg/HttpBootDxe: Declare the functions as
> EFIAPI to pass the GCC build
> 
> On 02/16/17 02:19, Jiaxin Wu wrote:
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Ye Ting <ting.ye@intel.com>
> > Cc: Fu Siyuan <siyuan.fu@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> > ---
> >  NetworkPkg/HttpBootDxe/HttpBootSupport.c | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Build-tested-by: Laszlo Ersek <lersek@redhat.com>
> 
> Thanks!
> Laszlo
> 
> >
> > diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> > index d786d72..e831df9 100644
> > --- a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> > +++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> > @@ -629,10 +629,11 @@ HttpBootSetHeader (
> >
> >    @param[in]  Context         The opaque parameter to the function.
> >
> >  **/
> >  VOID
> > +EFIAPI
> >  HttpIoNotifyDpc (
> >    IN VOID                *Context
> >    )
> >  {
> >    *((BOOLEAN *) Context) = TRUE;
> > @@ -644,10 +645,11 @@ HttpIoNotifyDpc (
> >    @param[in]  Event                 The event signaled.
> >    @param[in]  Context               The opaque parameter to the function.
> >
> >  **/
> >  VOID
> > +EFIAPI
> >  HttpIoNotify (
> >    IN EFI_EVENT              Event,
> >    IN VOID                   *Context
> >    )
> >  {
> >

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel