[edk2] [PATCH v2 0/4] PrintLib: Add safe print functions [A|U]ValueToStringS

Hao Wu posted 4 patches 7 years, 8 months ago
Failed in applying to current master (apply log)
MdeModulePkg/Include/Protocol/Print2.h                                       | 150 +++++++++++++-
MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf |   4 +-
MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.uni |  10 +-
MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c                    | 183 ++++++++++++++++--
MdeModulePkg/MdeModulePkg.dec                                                |   3 +-
MdeModulePkg/Universal/PrintDxe/Print.c                                      |  18 +-
MdeModulePkg/Universal/PrintDxe/PrintDxe.inf                                 |   7 +-
MdeModulePkg/Universal/PrintDxe/PrintDxe.uni                                 |  10 +-
MdePkg/Include/Library/PrintLib.h                                            | 121 ++++++++++++
MdePkg/Library/BasePrintLib/PrintLib.c                                       | 128 ++++++++++++
MdePkg/Library/BasePrintLib/PrintLibInternal.c                               | 204 ++++++++++++++++++++
MdePkg/Library/BasePrintLib/PrintLibInternal.h                               |  61 ++++++
12 files changed, 865 insertions(+), 34 deletions(-)
[edk2] [PATCH v2 0/4] PrintLib: Add safe print functions [A|U]ValueToStringS
Posted by Hao Wu 7 years, 8 months ago
V2 changes:
Add the EFI_PRINT2S_PROTOCOL as a safe version of the EFI_PRINT2_PROTOCOL,
the new protocol replaces the following 2 services in EFI_PRINT2_PROTOCOL:
UNICODE_VALUE_TO_STRING
ASCII_VALUE_TO_STRING
with:
UNICODE_VALUE_TO_STRING_S
ASCII_VALUE_TO_STRING_S

Now, the PrintLib instance MdeModulePkg/Library/DxePrintLibPrint2Protocol
will use EFI_PRINT2S_PROTOCOL instead of EFI_PRINT2_PROTOCOL to implement
its APIs.


V1 history:
Add the following 2 safe print functions in PrintLib:
UnicodeValueToStringS
AsciiValueToStringS

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>


Hao Wu (4):
  MdePkg/BasePrintLib: Add safe print functions [A|U]ValueToStringS
  MdeModulePkg: Add the EFI_PRINT2S_PROTOCOL
  MdeModulePkg/PrintLib: Use EFI_PRINT2S_PROTOCOL for this instance
  MdeModulePkg/PrintLib: Add safe print functions [A|U]ValueToStringS

 MdeModulePkg/Include/Protocol/Print2.h                                       | 150 +++++++++++++-
 MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf |   4 +-
 MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.uni |  10 +-
 MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c                    | 183 ++++++++++++++++--
 MdeModulePkg/MdeModulePkg.dec                                                |   3 +-
 MdeModulePkg/Universal/PrintDxe/Print.c                                      |  18 +-
 MdeModulePkg/Universal/PrintDxe/PrintDxe.inf                                 |   7 +-
 MdeModulePkg/Universal/PrintDxe/PrintDxe.uni                                 |  10 +-
 MdePkg/Include/Library/PrintLib.h                                            | 121 ++++++++++++
 MdePkg/Library/BasePrintLib/PrintLib.c                                       | 128 ++++++++++++
 MdePkg/Library/BasePrintLib/PrintLibInternal.c                               | 204 ++++++++++++++++++++
 MdePkg/Library/BasePrintLib/PrintLibInternal.h                               |  61 ++++++
 12 files changed, 865 insertions(+), 34 deletions(-)

-- 
1.9.5.msysgit.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v2 0/4] PrintLib: Add safe print functions [A|U]ValueToStringS
Posted by Gao, Liming 7 years, 8 months ago
Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Wu, Hao A
>Sent: Thursday, February 09, 2017 2:03 PM
>To: edk2-devel@lists.01.org
>Cc: Wu, Hao A <hao.a.wu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
>Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>
>Subject: [PATCH v2 0/4] PrintLib: Add safe print functions
>[A|U]ValueToStringS
>
>V2 changes:
>Add the EFI_PRINT2S_PROTOCOL as a safe version of the
>EFI_PRINT2_PROTOCOL,
>the new protocol replaces the following 2 services in EFI_PRINT2_PROTOCOL:
>UNICODE_VALUE_TO_STRING
>ASCII_VALUE_TO_STRING
>with:
>UNICODE_VALUE_TO_STRING_S
>ASCII_VALUE_TO_STRING_S
>
>Now, the PrintLib instance MdeModulePkg/Library/DxePrintLibPrint2Protocol
>will use EFI_PRINT2S_PROTOCOL instead of EFI_PRINT2_PROTOCOL to
>implement
>its APIs.
>
>
>V1 history:
>Add the following 2 safe print functions in PrintLib:
>UnicodeValueToStringS
>AsciiValueToStringS
>
>Cc: Jiewen Yao <jiewen.yao@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Michael Kinney <michael.d.kinney@intel.com>
>
>
>Hao Wu (4):
>  MdePkg/BasePrintLib: Add safe print functions [A|U]ValueToStringS
>  MdeModulePkg: Add the EFI_PRINT2S_PROTOCOL
>  MdeModulePkg/PrintLib: Use EFI_PRINT2S_PROTOCOL for this instance
>  MdeModulePkg/PrintLib: Add safe print functions [A|U]ValueToStringS
>
> MdeModulePkg/Include/Protocol/Print2.h                                       | 150
>+++++++++++++-
>
>MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.
>inf |   4 +-
>
>MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.
>uni |  10 +-
> MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c                    | 183
>++++++++++++++++--
> MdeModulePkg/MdeModulePkg.dec                                                |   3 +-
> MdeModulePkg/Universal/PrintDxe/Print.c                                      |  18 +-
> MdeModulePkg/Universal/PrintDxe/PrintDxe.inf                                 |   7 +-
> MdeModulePkg/Universal/PrintDxe/PrintDxe.uni                                 |  10 +-
> MdePkg/Include/Library/PrintLib.h                                            | 121
>++++++++++++
> MdePkg/Library/BasePrintLib/PrintLib.c                                       | 128
>++++++++++++
> MdePkg/Library/BasePrintLib/PrintLibInternal.c                               | 204
>++++++++++++++++++++
> MdePkg/Library/BasePrintLib/PrintLibInternal.h                               |  61 ++++++
> 12 files changed, 865 insertions(+), 34 deletions(-)
>
>--
>1.9.5.msysgit.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel