[edk2] [PATCH v2 0/3] PrintLib: Refine the SPrint functions

Hao Wu posted 3 patches 7 years, 8 months ago
Failed in applying to current master (apply log)
MdeModulePkg/Include/Protocol/Print2.h                                       | 361 +++++++------
MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf |   7 +-
MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c                    | 562 ++++++++++++--------
MdePkg/Include/Library/PrintLib.h                                            | 498 +++++++++--------
MdePkg/Library/BasePrintLib/BasePrintLib.inf                                 |   8 +-
MdePkg/Library/BasePrintLib/PrintLib.c                                       | 416 +++++++++------
MdePkg/Library/BasePrintLib/PrintLibInternal.c                               | 101 ++--
MdePkg/Library/BasePrintLib/PrintLibInternal.h                               |   3 +-
8 files changed, 1147 insertions(+), 809 deletions(-)
[edk2] [PATCH v2 0/3] PrintLib: Refine the SPrint functions
Posted by Hao Wu 7 years, 8 months ago
V2 changes:
Update the description of the following services of EFI_PRINT2_PROTOCOL:
UNICODE_BS_PRINT
UNICODE_S_PRINT
UNICODE_BS_PRINT_ASCII_FORMAT
UNICODE_S_PRINT_ASCII_FORMAT
ASCII_BS_PRINT
ASCII_S_PRINT
ASCII_BS_PRINT_UNICODE_FORMAT
ASCII_S_PRINT_UNICODE_FORMAT

Keep them the same as the relating API decriptions in PrintLib.


V1 history:
Refine the ASSERT conditions and the return value when ASSERT triggers
for the following APIs in PrintLib:
UnicodeVSPrint
UnicodeBSPrint
UnicodeSPrint
UnicodeVSPrintAsciiFormat
UnicodeBSPrintAsciiFormat
UnicodeSPrintAsciiFormat
AsciiVSPrint
AsciiBSPrint
AsciiSPrint
AsciiVSPrintUnicodeFormat
AsciiBSPrintUnicodeFormat
AsciiSPrintUnicodeFormat
SPrintLength
SPrintLengthAsciiFormat

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>


Hao Wu (3):
  MdePkg/BasePrintLib: Refine the SPrint functions
  MdeModulePkg/PrintLib: Refine the SPrint functions
  MdeModulePkg: Refine the services comments in EFI_PRINT2_PROTOCOL

 MdeModulePkg/Include/Protocol/Print2.h                                       | 361 +++++++------
 MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf |   7 +-
 MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c                    | 562 ++++++++++++--------
 MdePkg/Include/Library/PrintLib.h                                            | 498 +++++++++--------
 MdePkg/Library/BasePrintLib/BasePrintLib.inf                                 |   8 +-
 MdePkg/Library/BasePrintLib/PrintLib.c                                       | 416 +++++++++------
 MdePkg/Library/BasePrintLib/PrintLibInternal.c                               | 101 ++--
 MdePkg/Library/BasePrintLib/PrintLibInternal.h                               |   3 +-
 8 files changed, 1147 insertions(+), 809 deletions(-)

-- 
1.9.5.msysgit.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v2 0/3] PrintLib: Refine the SPrint functions
Posted by Gao, Liming 7 years, 8 months ago
Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Wu, Hao A
>Sent: Thursday, February 09, 2017 11:33 AM
>To: edk2-devel@lists.01.org
>Cc: Wu, Hao A <hao.a.wu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
>Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>
>Subject: [PATCH v2 0/3] PrintLib: Refine the SPrint functions
>
>V2 changes:
>Update the description of the following services of EFI_PRINT2_PROTOCOL:
>UNICODE_BS_PRINT
>UNICODE_S_PRINT
>UNICODE_BS_PRINT_ASCII_FORMAT
>UNICODE_S_PRINT_ASCII_FORMAT
>ASCII_BS_PRINT
>ASCII_S_PRINT
>ASCII_BS_PRINT_UNICODE_FORMAT
>ASCII_S_PRINT_UNICODE_FORMAT
>
>Keep them the same as the relating API decriptions in PrintLib.
>
>
>V1 history:
>Refine the ASSERT conditions and the return value when ASSERT triggers
>for the following APIs in PrintLib:
>UnicodeVSPrint
>UnicodeBSPrint
>UnicodeSPrint
>UnicodeVSPrintAsciiFormat
>UnicodeBSPrintAsciiFormat
>UnicodeSPrintAsciiFormat
>AsciiVSPrint
>AsciiBSPrint
>AsciiSPrint
>AsciiVSPrintUnicodeFormat
>AsciiBSPrintUnicodeFormat
>AsciiSPrintUnicodeFormat
>SPrintLength
>SPrintLengthAsciiFormat
>
>Cc: Jiewen Yao <jiewen.yao@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Michael Kinney <michael.d.kinney@intel.com>
>
>
>Hao Wu (3):
>  MdePkg/BasePrintLib: Refine the SPrint functions
>  MdeModulePkg/PrintLib: Refine the SPrint functions
>  MdeModulePkg: Refine the services comments in EFI_PRINT2_PROTOCOL
>
> MdeModulePkg/Include/Protocol/Print2.h                                       | 361 +++++++-
>-----
>
>MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.
>inf |   7 +-
> MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c                    | 562
>++++++++++++--------
> MdePkg/Include/Library/PrintLib.h                                            | 498 +++++++++----
>----
> MdePkg/Library/BasePrintLib/BasePrintLib.inf                                 |   8 +-
> MdePkg/Library/BasePrintLib/PrintLib.c                                       | 416 +++++++++-
>-----
> MdePkg/Library/BasePrintLib/PrintLibInternal.c                               | 101 ++--
> MdePkg/Library/BasePrintLib/PrintLibInternal.h                               |   3 +-
> 8 files changed, 1147 insertions(+), 809 deletions(-)
>
>--
>1.9.5.msysgit.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel