1. Patchew
  2. EDK2
  3. [edk2] [staging/edk2-test PATCH V2 0/6] Fix XCODE and GCC build issues
  4. View patch

[edk2] [staging/edk2-test PATCH V2 5/6] TestCasePkg: Fix XCODE compatibility issues

Michael Kinney posted 6 patches 7 years, 9 months ago
[edk2] [staging/edk2-test PATCH V2 5/6] TestCasePkg: Fix XCODE compatibility issues
Posted by Michael Kinney 7 years, 9 months ago 
Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Andrew Fish <afish@apple.com>
---
 TestCasePkg/Timer/ArchTimerBBTestConformance.c | 5 ++---
 TestCasePkg/Timer/ArchTimerBBTestFunction.c    | 8 ++++----
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/TestCasePkg/Timer/ArchTimerBBTestConformance.c b/TestCasePkg/Timer/ArchTimerBBTestConformance.c
index 8a4bd7c..58c4ade 100644
--- a/TestCasePkg/Timer/ArchTimerBBTestConformance.c
+++ b/TestCasePkg/Timer/ArchTimerBBTestConformance.c
@@ -47,7 +47,7 @@ BBTestRegisterHandlerConsistencyTest (
   Status = gtBS->HandleProtocol (
                    SupportHandle,
                    &gEfiStandardTestLibraryGuid,
-                   &StandardLib
+                   (VOID **)&StandardLib
                    );
   if (EFI_ERROR(Status)) {
     StandardLib->RecordAssertion (
@@ -217,7 +217,7 @@ BBTestGetTimerPeriodConsistencyTest (
   Status = gtBS->HandleProtocol (
                    SupportHandle,
                    &gEfiStandardTestLibraryGuid,
-                   &StandardLib
+                   (VOID **)&StandardLib
                    );
   if (EFI_ERROR(Status)) {
     StandardLib->RecordAssertion (
@@ -262,4 +262,3 @@ BBTestGetTimerPeriodConsistencyTest (
 
   return EFI_SUCCESS;
 }
-
diff --git a/TestCasePkg/Timer/ArchTimerBBTestFunction.c b/TestCasePkg/Timer/ArchTimerBBTestFunction.c
index 46be5c7..dc76bec 100644
--- a/TestCasePkg/Timer/ArchTimerBBTestFunction.c
+++ b/TestCasePkg/Timer/ArchTimerBBTestFunction.c
@@ -47,7 +47,7 @@ BBTestRegisterHandlerInterfaceTest (
   Status = gtBS->HandleProtocol (
                    SupportHandle,
                    &gEfiStandardTestLibraryGuid,
-                   &StandardLib
+                   (VOID **)&StandardLib
                    );
   if (EFI_ERROR(Status)) {
     StandardLib->RecordAssertion (
@@ -281,7 +281,7 @@ BBTestSetTimerPeriodInterfaceTest (
   Status = gtBS->HandleProtocol (
                    SupportHandle,
                    &gEfiStandardTestLibraryGuid,
-                   &StandardLib
+                   (VOID **)&StandardLib
                    );
   if (EFI_ERROR(Status)) {
     StandardLib->RecordAssertion (
@@ -609,7 +609,7 @@ BBTestGetTimerPeriodInterfaceTest (
   Status = gtBS->HandleProtocol (
                    SupportHandle,
                    &gEfiStandardTestLibraryGuid,
-                   &StandardLib
+                   (VOID **)&StandardLib
                    );
   if (EFI_ERROR(Status)) {
     StandardLib->RecordAssertion (
@@ -749,7 +749,7 @@ BBTestGenerateSoftInterruptInterfaceTest (
   Status = gtBS->HandleProtocol (
                    SupportHandle,
                    &gEfiStandardTestLibraryGuid,
-                   &StandardLib
+                   (VOID **)&StandardLib
                    );
   if (EFI_ERROR(Status)) {
     StandardLib->RecordAssertion (
-- 
2.6.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [staging/edk2-test PATCH V2 5/6] TestCasePkg: Fix XCODE compatibility issues
Posted by Supreeth Venkatesh 7 years, 9 months ago 
On Wed, 2017-02-01 at 01:49 -0800, Michael Kinney wrote:
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Andrew Fish <afish@apple.com>
This looks fine to me.

Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>

> ---
>  TestCasePkg/Timer/ArchTimerBBTestConformance.c | 5 ++---
>  TestCasePkg/Timer/ArchTimerBBTestFunction.c    | 8 ++++----
>  2 files changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/TestCasePkg/Timer/ArchTimerBBTestConformance.c
> b/TestCasePkg/Timer/ArchTimerBBTestConformance.c
> index 8a4bd7c..58c4ade 100644
> --- a/TestCasePkg/Timer/ArchTimerBBTestConformance.c
> +++ b/TestCasePkg/Timer/ArchTimerBBTestConformance.c
> @@ -47,7 +47,7 @@ BBTestRegisterHandlerConsistencyTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (
> @@ -217,7 +217,7 @@ BBTestGetTimerPeriodConsistencyTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (
> @@ -262,4 +262,3 @@ BBTestGetTimerPeriodConsistencyTest (
>  
>    return EFI_SUCCESS;
>  }
> -
> diff --git a/TestCasePkg/Timer/ArchTimerBBTestFunction.c
> b/TestCasePkg/Timer/ArchTimerBBTestFunction.c
> index 46be5c7..dc76bec 100644
> --- a/TestCasePkg/Timer/ArchTimerBBTestFunction.c
> +++ b/TestCasePkg/Timer/ArchTimerBBTestFunction.c
> @@ -47,7 +47,7 @@ BBTestRegisterHandlerInterfaceTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (
> @@ -281,7 +281,7 @@ BBTestSetTimerPeriodInterfaceTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (
> @@ -609,7 +609,7 @@ BBTestGetTimerPeriodInterfaceTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (
> @@ -749,7 +749,7 @@ BBTestGenerateSoftInterruptInterfaceTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.